[svn-commits] dlee: branch 1.8 r409077 - /branches/1.8/utils/astman.c

[SVN commits to the Digium repositories]

Author: dlee
Date: Thu Feb 27 10:23:11 2014
New Revision: 409077

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=409077
Log:
Fix memory stomping bug in astman.

This memset complained in dev mod on my Ubuntu box. The memset is both
unnecessary and dangerous. At this point, m hasn't been initialized
yet, so the memset will write off to whatever address happens to be
on the stack at the time.

Modified:
    branches/1.8/utils/astman.c

Modified: branches/1.8/utils/astman.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/utils/astman.c?view=diff&rev=409077&r1=409076&r2=409077
==============================================================================
--- branches/1.8/utils/astman.c (original)
+++ branches/1.8/utils/astman.c Thu Feb 27 10:23:11 2014
@@ -738,7 +738,6 @@
 					show_message("Login Failed", get_header(m, "Message"));
 				}
 			} else {
-				memset(m, 0, sizeof(m));
 				manager_action("Login", 
 					"Username: %s\r\n"
 					"Secret: %s\r\n",