[svn-commits] mmichelson: branch 13 r420758 - /branches/13/res/res_pjsip_pubsub.c

SVN commits to the Digium repositories svn-commits at lists.digium.com
Mon Aug 11 10:59:19 CDT 2014


Author: mmichelson
Date: Mon Aug 11 10:59:17 2014
New Revision: 420758

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=420758
Log:
Fix crash encountered by the testsuite.

Running testsuite tests locally produced no errors, but when
run using the continuous integration framework, crashes occurred.

The crashes occurred due to a refcounting error that had been fixed
for a similar situation.


Modified:
    branches/13/res/res_pjsip_pubsub.c

Modified: branches/13/res/res_pjsip_pubsub.c
URL: http://svnview.digium.com/svn/asterisk/branches/13/res/res_pjsip_pubsub.c?view=diff&rev=420758&r1=420757&r2=420758
==============================================================================
--- branches/13/res/res_pjsip_pubsub.c (original)
+++ branches/13/res/res_pjsip_pubsub.c Mon Aug 11 10:59:17 2014
@@ -2032,7 +2032,10 @@
 	if (sub->tree->notification_batch_interval) {
 		return schedule_notification(sub->tree);
 	} else {
+		/* See the note in pubsub_on_rx_refresh() for why sub->tree is refbumped here */
+		ao2_ref(sub->tree, +1);
 		return send_notify(sub->tree, 0);
+		ao2_ref(sub->tree, -1);
 	}
 }
 




More information about the svn-commits mailing list