[svn-commits] jrose: branch 1.8 r401704 - in /branches/1.8: channels/ codecs/ilbc/ main/ ut...

[SVN commits to the Digium repositories]

Author: jrose
Date: Thu Oct 24 11:39:48 2013
New Revision: 401704

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=401704
Log:
memory leaks: Memory leak cleanup patch by Corey Farrell (second set)

Also covers ast_app_parse_timelen-fail-zero-length.patch, but the patch was
replaced with one of my own.

(issue ASTERISK-22467)
Reported by: Corey Farrell
Patches:
    chan_dahdi-cleanup_push.patch uploaded by coreyfarrell (license 5909)
    clicompat-r2.patch uploaded by coreyfarrell (license 5909)
    codecs-ilbc-doCPLC.patch uploaded by coreyfarrell (license 5909)
    data-cleanup-test-registration.patch uploaded by coreyfarrell (license 5909)
    main-asterisk-kill-listener.patch uploaded by coreyfarrell (license 5909)


Modified:
    branches/1.8/channels/chan_dahdi.c
    branches/1.8/codecs/ilbc/doCPLC.c
    branches/1.8/main/app.c
    branches/1.8/main/asterisk.c
    branches/1.8/main/data.c
    branches/1.8/utils/clicompat.c

Modified: branches/1.8/channels/chan_dahdi.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/channels/chan_dahdi.c?view=diff&rev=401704&r1=401703&r2=401704
==============================================================================
--- branches/1.8/channels/chan_dahdi.c (original)
+++ branches/1.8/channels/chan_dahdi.c Thu Oct 24 11:39:48 2013
@@ -11709,6 +11709,11 @@
 	return NULL;
 }
 
+static void monitor_pfds_clean(void *arg) {
+	struct pollfd **pfds = arg;
+	ast_free(*pfds);
+}
+
 static void *do_monitor(void *data)
 {
 	int count, res, res2, spoint, pollres=0;
@@ -11732,6 +11737,7 @@
 #endif
 	pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, NULL);
 
+	pthread_cleanup_push(monitor_pfds_clean, &pfds);
 	for (;;) {
 		/* Lock the interface list */
 		ast_mutex_lock(&iflock);
@@ -11988,6 +11994,7 @@
 		ast_mutex_unlock(&iflock);
 	}
 	/* Never reached */
+	pthread_cleanup_pop(1);
 	return NULL;
 
 }

Modified: branches/1.8/codecs/ilbc/doCPLC.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/codecs/ilbc/doCPLC.c?view=diff&rev=401704&r1=401703&r2=401704
==============================================================================
--- branches/1.8/codecs/ilbc/doCPLC.c (original)
+++ branches/1.8/codecs/ilbc/doCPLC.c Thu Oct 24 11:39:48 2013
@@ -90,7 +90,7 @@
        int lag=20, randlag;
        float gain, maxcc;
        float use_gain;
-       float gain_comp, maxcc_comp, per, max_per;
+       float gain_comp, maxcc_comp, per, max_per=0;
        int i, pick, use_lag;
        float ftmp, randvec[BLOCKL_MAX], pitchfact, energy;
 

Modified: branches/1.8/main/app.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/main/app.c?view=diff&rev=401704&r1=401703&r2=401704
==============================================================================
--- branches/1.8/main/app.c (original)
+++ branches/1.8/main/app.c Thu Oct 24 11:39:48 2013
@@ -2196,7 +2196,9 @@
 		return -1;
 	}
 
-	if ((res = sscanf(timestr, FMT, &amount, u)) == 0) {
+	res = sscanf(timestr, FMT, &amount, u);
+
+	if (res == 0 || res == EOF) {
 #undef FMT
 		return -1;
 	} else if (res == 2) {

Modified: branches/1.8/main/asterisk.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/main/asterisk.c?view=diff&rev=401704&r1=401703&r2=401704
==============================================================================
--- branches/1.8/main/asterisk.c (original)
+++ branches/1.8/main/asterisk.c Thu Oct 24 11:39:48 2013
@@ -1800,11 +1800,17 @@
 		close(ast_socket);
 		ast_socket = -1;
 		unlink(ast_config_AST_SOCKET);
+		pthread_kill(lthread, SIGURG);
+		pthread_join(lthread, NULL);
 	}
 	if (ast_consock > -1)
 		close(ast_consock);
 	if (!ast_opt_remote)
 		unlink(ast_config_AST_PID);
+	if (sig_alert_pipe[0])
+		close(sig_alert_pipe[0]);
+	if (sig_alert_pipe[1])
+		close(sig_alert_pipe[1]);
 	printf("%s", term_quit());
 	if (restart) {
 		int i;

Modified: branches/1.8/main/data.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/main/data.c?view=diff&rev=401704&r1=401703&r2=401704
==============================================================================
--- branches/1.8/main/data.c (original)
+++ branches/1.8/main/data.c Thu Oct 24 11:39:48 2013
@@ -3290,6 +3290,7 @@
 	ao2_t_ref(root_data.container, -1, "Unref root_data.container in data_shutdown");
 	root_data.container = NULL;
 	ast_rwlock_destroy(&root_data.lock);
+	AST_TEST_UNREGISTER(test_data_get);
 }
 
 int ast_data_init(void)
@@ -3307,9 +3308,7 @@
 
 	res |= ast_manager_register_xml("DataGet", 0, manager_data_get);
 
-#ifdef TEST_FRAMEWORK
 	AST_TEST_REGISTER(test_data_get);
-#endif
 
 	ast_register_atexit(data_shutdown);
 

Modified: branches/1.8/utils/clicompat.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/utils/clicompat.c?view=diff&rev=401704&r1=401703&r2=401704
==============================================================================
--- branches/1.8/utils/clicompat.c (original)
+++ branches/1.8/utils/clicompat.c Thu Oct 24 11:39:48 2013
@@ -9,8 +9,18 @@
 
 struct ast_cli_entry;
 
+int ast_register_atexit(void (*func)(void));
+int ast_register_atexit(void (*func)(void))
+{
+	return 0;
+}
 int ast_cli_register_multiple(struct ast_cli_entry *e, int len);
 int ast_cli_register_multiple(struct ast_cli_entry *e, int len)
 {
 	return 0;
 }
+int ast_cli_unregister_multiple(struct ast_cli_entry *e, int len);
+int ast_cli_unregister_multiple(struct ast_cli_entry *e, int len)
+{
+	return 0;
+}