[svn-commits] mjordan: branch 12 r400460 - /branches/12/main/channel_internal_api.c

[SVN commits to the Digium repositories]

Author: mjordan
Date: Thu Oct  3 16:40:20 2013
New Revision: 400460

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=400460
Log:
Remove publication of a channel snapshot when the technology is set

This patch removes said publication for a few reasons:
(1) It is unnecessary. Association of the channel technology with a specific
channel is an implementation detail that should be assumed to "just happen",
and consumers of Stasis don't need to be informed about it.
(2) Publication of said message can now cause crashes, as the actual creation
of a channel in normal locations now stages its messages. As a result, things
that create dummy channels (such as the SIP RTP QOS unit test) and associate
them with a channel technology were now crashing, as the channel itself was
not known by Stasis.


Modified:
    branches/12/main/channel_internal_api.c

Modified: branches/12/main/channel_internal_api.c
URL: http://svnview.digium.com/svn/asterisk/branches/12/main/channel_internal_api.c?view=diff&rev=400460&r1=400459&r2=400460
==============================================================================
--- branches/12/main/channel_internal_api.c (original)
+++ branches/12/main/channel_internal_api.c Thu Oct  3 16:40:20 2013
@@ -879,7 +879,6 @@
 void ast_channel_tech_set(struct ast_channel *chan, const struct ast_channel_tech *value)
 {
 	chan->tech = value;
-	ast_channel_publish_snapshot(chan);
 }
 enum ast_channel_adsicpe ast_channel_adsicpe(const struct ast_channel *chan)
 {