[svn-commits] mjordan: branch 11 r381159 - /branches/11/res/res_xmpp.c

[SVN commits to the Digium repositories]

Author: mjordan
Date: Mon Feb 11 09:03:40 2013
New Revision: 381159

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=381159
Log:
Fix crash in res_xmpp when deleting pubsub node from CLI

An error existed in res_xmpp where it would attempt to delete attributes from
a node that itself was also deleted. Per the iksemel documentation, attributes
added using iks_insert are copied to the parent node's stack, and will be
reclaimed when that node is itself destroyed.

(closes issue ASTERISK-20982)
Reported by: marcelloceschia
patches:
  delete-node-fix.diff uploaded by marcelloceschia (License 6036)


Modified:
    branches/11/res/res_xmpp.c

Modified: branches/11/res/res_xmpp.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/res/res_xmpp.c?view=diff&rev=381159&r1=381158&r2=381159
==============================================================================
--- branches/11/res/res_xmpp.c (original)
+++ branches/11/res/res_xmpp.c Mon Feb 11 09:03:40 2013
@@ -1083,8 +1083,6 @@
 	iks_insert_attrib(delete, "node", node_name);
 	ast_xmpp_client_send(client, request);
 
-	iks_delete(delete);
-	iks_delete(pubsub);
 	iks_delete(request);
 }