[svn-commits] dlee: branch dlee/ari-bridge-tests r4089 - in /asterisk/team/dlee/ari-bridge-...

SVN commits to the Digium repositories svn-commits at lists.digium.com
Tue Aug 27 14:26:51 CDT 2013


Author: dlee
Date: Tue Aug 27 14:26:49 2013
New Revision: 4089

URL: http://svnview.digium.com/svn/testsuite?view=rev&rev=4089
Log:
Addressed review feedback.

* Removed vestigial code
* Replaced nasty caller line printing with simply throwing an exception

Modified:
    asterisk/team/dlee/ari-bridge-tests/tests/rest_api/bridges/hangup/bridge_hangup.py
    asterisk/team/dlee/ari-bridge-tests/tests/rest_api/bridges/unhappy/bridge_unhappy.py

Modified: asterisk/team/dlee/ari-bridge-tests/tests/rest_api/bridges/hangup/bridge_hangup.py
URL: http://svnview.digium.com/svn/testsuite/asterisk/team/dlee/ari-bridge-tests/tests/rest_api/bridges/hangup/bridge_hangup.py?view=diff&rev=4089&r1=4088&r2=4089
==============================================================================
--- asterisk/team/dlee/ari-bridge-tests/tests/rest_api/bridges/hangup/bridge_hangup.py (original)
+++ asterisk/team/dlee/ari-bridge-tests/tests/rest_api/bridges/hangup/bridge_hangup.py Tue Aug 27 14:26:49 2013
@@ -34,6 +34,3 @@
 
 def on_enter(ari, event):
     return TEST.on_enter(ari, event)
-
-def on_leave(ari, event):
-    return TEST.on_leave(ari, event)

Modified: asterisk/team/dlee/ari-bridge-tests/tests/rest_api/bridges/unhappy/bridge_unhappy.py
URL: http://svnview.digium.com/svn/testsuite/asterisk/team/dlee/ari-bridge-tests/tests/rest_api/bridges/unhappy/bridge_unhappy.py?view=diff&rev=4089&r1=4088&r2=4089
==============================================================================
--- asterisk/team/dlee/ari-bridge-tests/tests/rest_api/bridges/unhappy/bridge_unhappy.py (original)
+++ asterisk/team/dlee/ari-bridge-tests/tests/rest_api/bridges/unhappy/bridge_unhappy.py Tue Aug 27 14:26:49 2013
@@ -79,11 +79,7 @@
                 self.passing = False
                 LOGGER.error("Expected %d (%s), got %s (%r)", expected_code,
                              expected, resp.status_code, resp.json())
-                # Log current stack frame
-                frame = inspect.currentframe()
-                lines = traceback.format_stack(frame)[-2:-4:-1]
-                for line in lines:
-                        LOGGER.error('"%s"' % line.strip())
+                raise ValueError("Test failed")
 
         # Disable auto-exceptions on HTTP errors.
         ari.set_allow_errors(True)




More information about the svn-commits mailing list