[svn-commits] dlee: branch 1.8 r384544 - /branches/1.8/Makefile

[SVN commits to the Digium repositories]

Author: dlee
Date: Tue Apr  2 12:33:53 2013
New Revision: 384544

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=384544
Log:
Fixed spurious rebuilds of func_version.

func_version.so was being rebuilt every time, because build.h was
changing every build, because of the cleantest dependency that was
added in r384410 to fix parallel make bugs.

Now build.h will only be created if it does not exist, which was the
original behavior of the Makefile.

Modified:
    branches/1.8/Makefile

Modified: branches/1.8/Makefile
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/Makefile?view=diff&rev=384544&r1=384543&r2=384544
==============================================================================
--- branches/1.8/Makefile (original)
+++ branches/1.8/Makefile Tue Apr  2 12:33:53 2013
@@ -370,10 +370,11 @@
 	@cmp -s $@.tmp $@ || mv $@.tmp $@
 	@rm -f $@.tmp
 
+# build.h must depend on cleantest, or parallel make may wipe it out after it's
+# been created. But since build.h contains a timestamp, the cmp trick used above
+# won't work. Just testing for existence is good enough.
 include/asterisk/build.h: cleantest
-	@build_tools/make_build_h > $@.tmp
-	@cmp -s $@.tmp $@ || mv $@.tmp $@
-	@rm -f $@.tmp
+	@test -f $@ || build_tools/make_build_h > $@
 
 $(SUBDIRS_CLEAN):
 	+@$(SUBMAKE) -C $(@:-clean=) clean