[svn-commits] russell: trunk r370541 - /trunk/tests/test_event.c

SVN commits to the Digium repositories svn-commits at lists.digium.com
Mon Jul 30 08:45:47 CDT 2012


Author: russell
Date: Mon Jul 30 08:45:42 2012
New Revision: 370541

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=370541
Log:
Fix ast_event_new unit test.

One of my recent commits broke this test.  The error was:

[test_event.c:event_new_test:214]: Events expected to be identical
have different size: 69 != 59

The difference in size occurred because the first event had
the EID IE added to the event twice.  ast_event_new() now always
adds it automatically.  Previously it only added it if there
were no IEs specified, which was kind of weird.


Modified:
    trunk/tests/test_event.c

Modified: trunk/tests/test_event.c
URL: http://svnview.digium.com/svn/asterisk/trunk/tests/test_event.c?view=diff&rev=370541&r1=370540&r2=370541
==============================================================================
--- trunk/tests/test_event.c (original)
+++ trunk/tests/test_event.c Mon Jul 30 08:45:42 2012
@@ -174,12 +174,6 @@
 
 	if (ast_event_append_ie_bitflags(&event, AST_EVENT_IE_OLDMSGS, bitflags)) {
 		ast_test_status_update(test, "Failed to append bitflags IE\n");
-		res = AST_TEST_FAIL;
-		goto return_cleanup;
-	}
-
-	if (ast_event_append_eid(&event)) {
-		ast_test_status_update(test, "Failed to append EID\n");
 		res = AST_TEST_FAIL;
 		goto return_cleanup;
 	}




More information about the svn-commits mailing list