[svn-commits] mmichelson: branch 1.8 r369731 - /branches/1.8/main/tcptls.c

[SVN commits to the Digium repositories]

Author: mmichelson
Date: Fri Jul  6 13:40:06 2012
New Revision: 369731

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=369731
Log:
Remove a superfluous and dangerous freeing of an SSL_CTX.

The problem here is that multiple server sessions share
a SSL_CTX. When one session ended, the SSL_CTX would be
freed and set NULL, leaving the other sessions unable to
function.

The code being removed is superfluous because the SSL_CTX
structures for servers will be properly freed when ast_ssl_teardown
is called.

(closes issue ASTERISK-20074)
Reported by Trevor Helmsley
Patches:
	ASTERISK-20074.diff uploaded by Mark Michelson (license #5049)
Testers:
	Trevor Helmsley


Modified:
    branches/1.8/main/tcptls.c

Modified: branches/1.8/main/tcptls.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/main/tcptls.c?view=diff&rev=369731&r1=369730&r2=369731
==============================================================================
--- branches/1.8/main/tcptls.c (original)
+++ branches/1.8/main/tcptls.c Fri Jul  6 13:40:06 2012
@@ -134,9 +134,6 @@
 static void session_instance_destructor(void *obj)
 {
 	struct ast_tcptls_session_instance *i = obj;
-	if (i->parent && i->parent->tls_cfg) {
-		ast_ssl_teardown(i->parent->tls_cfg);
-	}
 	ast_mutex_destroy(&i->lock);
 }