[svn-commits] mmichelson: branch mmichelson/bridge-tests r3564 - /asterisk/team/mmichelson/...

[SVN commits to the Digium repositories]

Author: mmichelson
Date: Tue Dec 11 16:00:21 2012
New Revision: 3564

URL: http://svnview.digium.com/svn/testsuite?view=rev&rev=3564
Log:
Address reviewboard feedback.

* Moved docstring to inside the method.
* Changed some levels log messages.


Modified:
    asterisk/team/mmichelson/bridge-tests/lib/python/asterisk/BridgeTestCase.py

Modified: asterisk/team/mmichelson/bridge-tests/lib/python/asterisk/BridgeTestCase.py
URL: http://svnview.digium.com/svn/testsuite/asterisk/team/mmichelson/bridge-tests/lib/python/asterisk/BridgeTestCase.py?view=diff&rev=3564&r1=3563&r2=3564
==============================================================================
--- asterisk/team/mmichelson/bridge-tests/lib/python/asterisk/BridgeTestCase.py (original)
+++ asterisk/team/mmichelson/bridge-tests/lib/python/asterisk/BridgeTestCase.py Tue Dec 11 16:00:21 2012
@@ -30,14 +30,14 @@
             'parkcall' : 6
             }
 
-    '''
-    Class that handles tests involving two-party bridges.
-    There are three Asterisk instances used for this test.
-    0 : the unit under test "UUT"
-    1 : the unit from which calls originate, also known as "Alice"
-    2 : the unit where calls terminate, also known as "Bob"
-    '''
     def __init__(self, test_path = '', test_config = None):
+        '''
+        Class that handles tests involving two-party bridges.
+        There are three Asterisk instances used for this test.
+        0 : the unit under test "UUT"
+        1 : the unit from which calls originate, also known as "Alice"
+        2 : the unit where calls terminate, also known as "Bob"
+        '''
         TestCase.__init__(self, test_path)
         self.create_asterisk(3, "%s/configs/bridge" % os.getcwd())
         self.test_runs = []
@@ -142,7 +142,7 @@
                 self.audio_detected = True
                 self.check_identities()
             else:
-                LOGGER.info("Audio issues on bridged call")
+                LOGGER.warning("Audio issues on bridged call")
                 self.stop_reactor()
 
     def hangup_callback(self, ami, event):
@@ -169,15 +169,15 @@
             self.run_tests()
 
     def uut_bridge_callback(self, ami, event):
-        LOGGER.info("Got bridge callback")
+        LOGGER.debug("Got bridge callback")
         self.uut_alice_channel = event.get('channel1')
         self.uut_bob_channel = event.get('channel2')
         if event.get('bridgestate') == 'Link':
-            LOGGER.info("Bridge is up")
-            LOGGER.info("Type of bridge is %s" % event.get('bridgetype'))
+            LOGGER.debug("Bridge is up")
+            LOGGER.debug("Type of bridge is %s" % event.get('bridgetype'))
             self.bridged = True
         else:
-            LOGGER.info("Bridge is down")
+            LOGGER.debug("Bridge is down")
             self.bridged = False
 
     def check_identities(self):