[svn-commits] rmudgett: branch 10 r377807 - in /branches/10: ./ main/pbx.c

[SVN commits to the Digium repositories]

Author: rmudgett
Date: Tue Dec 11 13:54:50 2012
New Revision: 377807

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=377807
Log:
Cleanup pbx on exit.

* Cleanup CLI commands on exit.

* Unreference hints and statecbs containers on exit.

(issue ASTERISK-20649)
Reported by: Corey Farrell
Patches:
      pbx-cleanup-1_8.patch (license #5909) patch uploaded by Corey Farrell
      pbx-cleanup-10.patch (license #5909) patch uploaded by Corey Farrell
      pbx-cleanup-11-trunk.patch (license #5909) patch uploaded by Corey Farrell
      Modified
........

Merged revisions 377806 from http://svn.asterisk.org/svn/asterisk/branches/1.8

Modified:
    branches/10/   (props changed)
    branches/10/main/pbx.c

Propchange: branches/10/
------------------------------------------------------------------------------
Binary property 'branch-1.8-merged' - no diff available.

Modified: branches/10/main/pbx.c
URL: http://svnview.digium.com/svn/asterisk/branches/10/main/pbx.c?view=diff&rev=377807&r1=377806&r2=377807
==============================================================================
--- branches/10/main/pbx.c (original)
+++ branches/10/main/pbx.c Tue Dec 11 13:54:50 2012
@@ -10716,12 +10716,17 @@
 	if (device_state_sub) {
 		device_state_sub = ast_event_unsubscribe(device_state_sub);
 	}
+	if (device_state_tps) {
+		ast_taskprocessor_unreference(device_state_tps);
+		device_state_tps = NULL;
+	}
 
 	/* Unregister builtin applications */
 	for (x = 0; x < ARRAY_LEN(builtins); x++) {
 		ast_unregister_application(builtins[x].name);
 	}
 	ast_manager_unregister("ShowDialPlan");
+	ast_cli_unregister_multiple(pbx_cli, ARRAY_LEN(pbx_cli));
 	ast_custom_function_unregister(&exception_function);
 	ast_custom_function_unregister(&testtime_function);
 	ast_data_unregister(NULL);
@@ -10730,6 +10735,8 @@
 int load_pbx(void)
 {
 	int x;
+
+	ast_register_atexit(unload_pbx);
 
 	/* Initialize the PBX */
 	ast_verb(1, "Asterisk PBX Core Initializing\n");
@@ -10760,7 +10767,6 @@
 		return -1;
 	}
 
-	ast_register_atexit(unload_pbx);
 	return 0;
 }
 
@@ -11121,17 +11127,23 @@
 	return (state_cb->change_cb == change_cb) ? CMP_MATCH | CMP_STOP : 0;
 }
 
-/*! \internal \brief Clean up resources on Asterisk shutdown */
+/*!
+ * \internal
+ * \brief Clean up resources on Asterisk shutdown
+ */
 static void pbx_shutdown(void)
 {
 	if (hints) {
 		ao2_ref(hints, -1);
+		hints = NULL;
 	}
 	if (hintdevices) {
 		ao2_ref(hintdevices, -1);
+		hintdevices = NULL;
 	}
 	if (statecbs) {
 		ao2_ref(statecbs, -1);
+		statecbs = NULL;
 	}
 }
 
@@ -11142,5 +11154,6 @@
 	statecbs = ao2_container_alloc(1, NULL, statecbs_cmp);
 
 	ast_register_atexit(pbx_shutdown);
+
 	return (hints && hintdevices && statecbs) ? 0 : -1;
 }