[svn-commits] sruffell: linux/trunk r9939 - /linux/trunk/drivers/dahdi/dahdi-base.c

[SVN commits to the Digium repositories]

Author: sruffell
Date: Thu Jun  2 15:01:29 2011
New Revision: 9939

URL: http://svnview.digium.com/svn/dahdi?view=rev&rev=9939
Log:
dahdi: Do not release the echocan under lock.

This allows any echocan cleanup to block if necessary. Especially useful
for hardware echocans that may need to wait for hardware to complete the
cleanup process.

Signed-off-by: Shaun Ruffell <sruffell at digium.com>
Acked-by: Tzafrir Cohen <tzafrir.cohen at xorcom.com>

Modified:
    linux/trunk/drivers/dahdi/dahdi-base.c

Modified: linux/trunk/drivers/dahdi/dahdi-base.c
URL: http://svnview.digium.com/svn/dahdi/linux/trunk/drivers/dahdi/dahdi-base.c?view=diff&rev=9939&r1=9938&r2=9939
==============================================================================
--- linux/trunk/drivers/dahdi/dahdi-base.c (original)
+++ linux/trunk/drivers/dahdi/dahdi-base.c Thu Jun  2 15:01:29 2011
@@ -1430,12 +1430,12 @@
 	if (chan->span && oldconf)
 		dahdi_disable_dacs(chan);
 
+	spin_unlock_irqrestore(&chan->lock, flags);
+
 	if (ec_state) {
 		ec_state->ops->echocan_free(chan, ec_state);
 		release_echocan(ec_current);
 	}
-
-	spin_unlock_irqrestore(&chan->lock, flags);
 
 	/* release conference resource, if any to release */
 	if (oldconf)