[svn-commits] sruffell: branch linux/2.4 r10049 - /linux/branches/2.4/drivers/dahdi/wcte12xp/

SVN commits to the Digium repositories svn-commits at lists.digium.com
Tue Jul 19 14:45:05 CDT 2011


Author: sruffell
Date: Tue Jul 19 14:45:01 2011
New Revision: 10049

URL: http://svnview.digium.com/svn/dahdi?view=rev&rev=10049
Log:
wcte12xp: Close a potential race on driver unload.

The shutdown logic requires that all CPUs see that the INITIALIZED bit
has been cleared. Otherwise it may be possible for the workqueue to run
after the hardware resources have been released.

Signed-off-by: Shaun Ruffell <sruffell at digium.com>
Acked-by: Russ Meyerriecks <rmeyerriecks at digium.com>

Origin: http://svnview.digium.com/svn/dahdi?view=rev&rev=10047

Modified:
    linux/branches/2.4/drivers/dahdi/wcte12xp/base.c

Modified: linux/branches/2.4/drivers/dahdi/wcte12xp/base.c
URL: http://svnview.digium.com/svn/dahdi/linux/branches/2.4/drivers/dahdi/wcte12xp/base.c?view=diff&rev=10049&r1=10048&r2=10049
==============================================================================
--- linux/branches/2.4/drivers/dahdi/wcte12xp/base.c (original)
+++ linux/branches/2.4/drivers/dahdi/wcte12xp/base.c Tue Jul 19 14:45:01 2011
@@ -2381,6 +2381,7 @@
 	remove_sysfs_files(wc);
 
 	clear_bit(INITIALIZED, &wc->bit_flags);
+	smp_mb__after_clear_bit();
 
 	del_timer_sync(&wc->timer);
 	flush_workqueue(wc->wq);




More information about the svn-commits mailing list