[svn-commits] sruffell: linux/trunk r10138 - /linux/trunk/drivers/dahdi/wctc4xxp/base.c

SVN commits to the Digium repositories svn-commits at lists.digium.com
Mon Aug 15 16:49:40 CDT 2011


Author: sruffell
Date: Mon Aug 15 16:49:36 2011
New Revision: 10138

URL: http://svnview.digium.com/svn/dahdi?view=rev&rev=10138
Log:
wctc4xxp: Fix lock imbalance in wctc4xxp_watchdog.

r10082 "wctc4xxp: Cleanup in-flight commands when halting due to
hardware error." introduced a lock imblance on the error path where the
cmd_list_lock would be unlocked twice when the board is halted due to a
hardware error. Thanks sparse.

Signed-off-by: Shaun Ruffell <sruffell at digium.com>

Modified:
    linux/trunk/drivers/dahdi/wctc4xxp/base.c

Modified: linux/trunk/drivers/dahdi/wctc4xxp/base.c
URL: http://svnview.digium.com/svn/dahdi/linux/trunk/drivers/dahdi/wctc4xxp/base.c?view=diff&rev=10138&r1=10137&r2=10138
==============================================================================
--- linux/trunk/drivers/dahdi/wctc4xxp/base.c (original)
+++ linux/trunk/drivers/dahdi/wctc4xxp/base.c Mon Aug 15 16:49:36 2011
@@ -3321,6 +3321,7 @@
 					  "Board malfunctioning.  " \
 					  "Halting operation.\n");
 					reschedule_timer = 0;
+					spin_lock(&wc->cmd_list_lock);
 					break;
 				}
 				/* ERROR:  We've retried the command and




More information about the svn-commits mailing list