[svn-commits] rmudgett: branch rmudgett/parking r330823 - in /team/rmudgett/parking: channe...

[SVN commits to the Digium repositories]

Author: rmudgett
Date: Wed Aug  3 14:16:16 2011
New Revision: 330823

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=330823
Log:
Update BUGBUG comments.

Modified:
    team/rmudgett/parking/channels/chan_iax2.c
    team/rmudgett/parking/main/features.c

Modified: team/rmudgett/parking/channels/chan_iax2.c
URL: http://svnview.digium.com/svn/asterisk/team/rmudgett/parking/channels/chan_iax2.c?view=diff&rev=330823&r1=330822&r2=330823
==============================================================================
--- team/rmudgett/parking/channels/chan_iax2.c (original)
+++ team/rmudgett/parking/channels/chan_iax2.c Wed Aug  3 14:16:16 2011
@@ -10695,8 +10695,7 @@
 					pbx_builtin_setvar_helper(owner, "BLINDTRANSFER", bridged_chan->name);
 					pbx_builtin_setvar_helper(bridged_chan, "BLINDTRANSFER", owner->name);
 
-/* BUGBUG c cannot be right.  C is likely NULL.  owner should probably be used instead. */
-					if (ast_parking_ext_valid(ies.called_number, c, iaxs[fr->callno]->context)) {
+					if (ast_parking_ext_valid(ies.called_number, owner, iaxs[fr->callno]->context)) {
 						ast_debug(1, "Parking call '%s'\n", bridged_chan->name);
 						if (iax_park(bridged_chan, owner, ies.called_number)) {
 							ast_log(LOG_WARNING, "Failed to park call '%s'\n",

Modified: team/rmudgett/parking/main/features.c
URL: http://svnview.digium.com/svn/asterisk/team/rmudgett/parking/main/features.c?view=diff&rev=330823&r1=330822&r2=330823
==============================================================================
--- team/rmudgett/parking/main/features.c (original)
+++ team/rmudgett/parking/main/features.c Wed Aug  3 14:16:16 2011
@@ -4398,7 +4398,6 @@
 	struct pollfd *pfds = NULL, *new_pfds = NULL;
 	int nfds = 0, new_nfds = 0;
 
-/* BUGBUG we should see about asterisk graceful shutdown of parked calls. */
 	for (;;) {
 		struct ao2_iterator iter;
 		struct ast_parkinglot *curlot;
@@ -4638,6 +4637,7 @@
 	}
 	AST_LIST_UNLOCK(&parkinglot->parkings);
 
+/* BUGBUG updating connected line for parked calls could be considered a feature enhancement or bug. */
 	if (peer) {
 		/* Update connected line between retrieving call and parked call. */
 		struct ast_party_connected_line connected;