[svn-commits] sruffell: linux/trunk r9367 - /linux/trunk/drivers/dahdi/dahdi-base.c

[SVN commits to the Digium repositories]

Author: sruffell
Date: Mon Sep 20 15:33:27 2010
New Revision: 9367

URL: http://svnview.digium.com/svn/dahdi?view=rev&rev=9367
Log:
dahdi: Modify "is_monitor_mode" to be usable by dahdi_chan_unreg.

Review: https://reviewboard.asterisk.org/r/905/

Signed-off-by: Shaun Ruffell <sruffell at digium.com>

Modified:
    linux/trunk/drivers/dahdi/dahdi-base.c

Modified: linux/trunk/drivers/dahdi/dahdi-base.c
URL: http://svnview.digium.com/svn/dahdi/linux/trunk/drivers/dahdi/dahdi-base.c?view=diff&rev=9367&r1=9366&r2=9367
==============================================================================
--- linux/trunk/drivers/dahdi/dahdi-base.c (original)
+++ linux/trunk/drivers/dahdi/dahdi-base.c Mon Sep 20 15:33:27 2010
@@ -1985,6 +1985,26 @@
 
 #endif
 
+/**
+ * is_monitor_mode() - True if the confmode indicates that one channel is monitoring another.
+ *
+ */
+static bool is_monitor_mode(int confmode)
+{
+	confmode &= DAHDI_CONF_MODE_MASK;
+	if ((confmode == DAHDI_CONF_MONITOR) ||
+	    (confmode == DAHDI_CONF_MONITORTX) ||
+	    (confmode == DAHDI_CONF_MONITORBOTH) ||
+	    (confmode == DAHDI_CONF_MONITOR_RX_PREECHO) ||
+	    (confmode == DAHDI_CONF_MONITOR_TX_PREECHO) ||
+	    (confmode == DAHDI_CONF_MONITORBOTH_PREECHO)) {
+		return true;
+	} else {
+		return false;
+	}
+}
+
+
 static void dahdi_chan_unreg(struct dahdi_chan *chan)
 {
 	int x;
@@ -2031,13 +2051,8 @@
 				chans[x]->master = chans[x];
 			}
 			if ((chans[x]->confna == chan->channo) &&
-				((chans[x]->confmode & DAHDI_CONF_MODE_MASK) == DAHDI_CONF_MONITOR ||
-				(chans[x]->confmode & DAHDI_CONF_MODE_MASK) == DAHDI_CONF_MONITORTX ||
-				(chans[x]->confmode & DAHDI_CONF_MODE_MASK) == DAHDI_CONF_MONITORBOTH ||
-				(chans[x]->confmode & DAHDI_CONF_MODE_MASK) == DAHDI_CONF_MONITOR_RX_PREECHO ||
-				(chans[x]->confmode & DAHDI_CONF_MODE_MASK) == DAHDI_CONF_MONITOR_TX_PREECHO ||
-				(chans[x]->confmode & DAHDI_CONF_MODE_MASK) == DAHDI_CONF_MONITORBOTH_PREECHO ||
-				(chans[x]->confmode & DAHDI_CONF_MODE_MASK) == DAHDI_CONF_DIGITALMON)) {
+			    is_monitor_mode(chans[x]->confmode) &&
+			    ((chans[x]->confmode & DAHDI_CONF_MODE_MASK) == DAHDI_CONF_DIGITALMON)) {
 				/* Take them out of conference with us */
 				/* release conference resource if any */
 				if (chans[x]->confna) {
@@ -4834,25 +4849,6 @@
 	return rv;
 }
 
-/**
- * is_monitor_mode() - true if dahdi_confinfo is putting chan in monitor mode
- *
- */
-static bool is_monitor_mode(const struct dahdi_confinfo *conf)
-{
-	const int confmode = conf->confmode & DAHDI_CONF_MODE_MASK;
-	if ((confmode == DAHDI_CONF_MONITOR) ||
-	    (confmode == DAHDI_CONF_MONITORTX) ||
-	    (confmode == DAHDI_CONF_MONITORBOTH) ||
-	    (confmode == DAHDI_CONF_MONITOR_RX_PREECHO) ||
-	    (confmode == DAHDI_CONF_MONITOR_TX_PREECHO) ||
-	    (confmode == DAHDI_CONF_MONITORBOTH_PREECHO)) {
-		return true;
-	} else {
-		return false;
-	}
-}
-
 static int dahdi_ioctl_setconf(struct file *file, unsigned long data)
 {
 	struct dahdi_confinfo conf;
@@ -4881,7 +4877,7 @@
 	if (!(chan->flags & DAHDI_FLAG_AUDIO))
 		return -EINVAL;
 
-	if (is_monitor_mode(&conf)) {
+	if (is_monitor_mode(conf.confmode)) {
 		/* Monitor mode -- it's a channel */
 		if ((conf.confno < 0) || (conf.confno >= DAHDI_MAX_CHANNELS) ||
 		    !chans[conf.confno])