[svn-commits] sruffell: linux/trunk r9435 - /linux/trunk/drivers/dahdi/wctc4xxp/base.c

SVN commits to the Digium repositories svn-commits at lists.digium.com
Wed Oct 20 07:22:49 CDT 2010


Author: sruffell
Date: Wed Oct 20 07:22:47 2010
New Revision: 9435

URL: http://svnview.digium.com/svn/dahdi?view=rev&rev=9435
Log:
wctc4xxp: Remove 'service_dte' function and a few inline keywords.

'service_dte' was only called in one place and is only two lines.  I do
not think it is adding much anymore. Also, let compiler should decide if
'service_rx_ring' and 'service_tx_ring' should be inlined.

Signed-off-by: Shaun Ruffell <sruffell at digium.com>
Acked-by: Kinsey Moore <kmoore at digium.com>
Acked-by: Russ Meyerriecks <rmeyerriecks at digium.com>

Modified:
    linux/trunk/drivers/dahdi/wctc4xxp/base.c

Modified: linux/trunk/drivers/dahdi/wctc4xxp/base.c
URL: http://svnview.digium.com/svn/dahdi/linux/trunk/drivers/dahdi/wctc4xxp/base.c?view=diff&rev=9435&r1=9434&r2=9435
==============================================================================
--- linux/trunk/drivers/dahdi/wctc4xxp/base.c (original)
+++ linux/trunk/drivers/dahdi/wctc4xxp/base.c Wed Oct 20 07:22:47 2010
@@ -2500,7 +2500,7 @@
 	}
 }
 
-static inline void service_tx_ring(struct wcdte *wc)
+static void service_tx_ring(struct wcdte *wc)
 {
 	struct tcb *cmd;
 	unsigned long flags;
@@ -2541,7 +2541,7 @@
 	}
 }
 
-static inline void service_rx_ring(struct wcdte *wc)
+static void service_rx_ring(struct wcdte *wc)
 {
 	struct tcb *cmd;
 	unsigned long flags;
@@ -2563,13 +2563,6 @@
 	wctc4xxp_receive_demand_poll(wc);
 }
 
-static inline void service_dte(struct wcdte *wc)
-{
-	service_tx_ring(wc);
-	service_rx_ring(wc);
-}
-
-
 #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 20)
 static void deferred_work_func(void *param)
 {
@@ -2579,7 +2572,8 @@
 {
 	struct wcdte *wc = container_of(work, struct wcdte, deferred_work);
 #endif
-	service_dte(wc);
+	service_tx_ring(wc);
+	service_rx_ring(wc);
 }
 
 DAHDI_IRQ_HANDLER(wctc4xxp_interrupt)




More information about the svn-commits mailing list