[svn-commits] mmichelson: branch group/CCSS r224572 - /team/group/CCSS/include/asterisk/ccss.h

SVN commits to the Digium repositories svn-commits at lists.digium.com
Mon Oct 19 14:55:34 CDT 2009


Author: mmichelson
Date: Mon Oct 19 14:55:30 2009
New Revision: 224572

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=224572
Log:
Add new XXX comment for future improvement.


Modified:
    team/group/CCSS/include/asterisk/ccss.h

Modified: team/group/CCSS/include/asterisk/ccss.h
URL: http://svnview.digium.com/svn/asterisk/team/group/CCSS/include/asterisk/ccss.h?view=diff&rev=224572&r1=224571&r2=224572
==============================================================================
--- team/group/CCSS/include/asterisk/ccss.h (original)
+++ team/group/CCSS/include/asterisk/ccss.h Mon Oct 19 14:55:30 2009
@@ -940,6 +940,12 @@
 
 /*!
  * \since 1.6.4
+ *
+ * XXX In retrospect, I think it's a bad idea to expose the internals of the state machine.
+ * Instead, what I want to do is to make individual API calls for each state change. The names
+ * of the functions will more easily convey the use. Furthermore, it allows for the state machine
+ * to be altered transparently. For initial code review, since this works, I'll leave it as is.
+ *
  * \brief Request that the core change states
  * \param state The state to which we wish to change
  * \param core_id The unique identifier for this instance of the CCSS core state machine




More information about the svn-commits mailing list