[svn-commits] rmudgett: trunk r222799 - in /trunk: ./ channels/misdn_config.c

[SVN commits to the Digium repositories]

Author: rmudgett
Date: Thu Oct  8 11:44:33 2009
New Revision: 222799

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=222799
Log:
Merged revisions 222797 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r222797 | rmudgett | 2009-10-08 11:33:06 -0500 (Thu, 08 Oct 2009) | 12 lines
  
  Fix memory leak if chan_misdn config parameter is repeated.
  
  Memory leak when the same config option is set more than once in an
  misdn.conf section.  Why must this be considered?  Templates!  Defining a
  template with default port options and later adding to or overriding some
  of them.
  
  Patches:
        memleak-misdn.patch
  
  JIRA ABE-1998
........

Modified:
    trunk/   (props changed)
    trunk/channels/misdn_config.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-1.4-merged' - no diff available.

Modified: trunk/channels/misdn_config.c
URL: http://svnview.digium.com/svn/asterisk/trunk/channels/misdn_config.c?view=diff&rev=222799&r1=222798&r2=222799
==============================================================================
--- trunk/channels/misdn_config.c (original)
+++ trunk/channels/misdn_config.c Thu Oct  8 11:44:33 2009
@@ -908,6 +908,9 @@
 
 	switch (type) {
 	case MISDN_CTYPE_STR:
+		if (dest->str) {
+			ast_free(dest->str);
+		}
 		if ((len = strlen(value))) {
 			dest->str = ast_malloc((len + 1) * sizeof(char));
 			strncpy(dest->str, value, len);
@@ -927,18 +930,24 @@
 			res = sscanf(value, "%30d", &tmp);
 		}
 		if (res) {
-			dest->num = ast_malloc(sizeof(int));
+			if (!dest->num) {
+				dest->num = ast_malloc(sizeof(int));
+			}
 			memcpy(dest->num, &tmp, sizeof(int));
 		} else
 			re = -1;
 	}
 		break;
 	case MISDN_CTYPE_BOOL:
-		dest->num = ast_malloc(sizeof(int));
+		if (!dest->num) {
+			dest->num = ast_malloc(sizeof(int));
+		}
 		*(dest->num) = (ast_true(value) ? 1 : 0);
 		break;
 	case MISDN_CTYPE_BOOLINT:
-		dest->num = ast_malloc(sizeof(int));
+		if (!dest->num) {
+			dest->num = ast_malloc(sizeof(int));
+		}
 		if (sscanf(value, "%30d", &tmp)) {
 			memcpy(dest->num, &tmp, sizeof(int));
 		} else {
@@ -957,7 +966,9 @@
 		}
 		break;
 	case MISDN_CTYPE_ASTGROUP:
-		dest->grp = ast_malloc(sizeof(ast_group_t));
+		if (!dest->grp) {
+			dest->grp = ast_malloc(sizeof(ast_group_t));
+		}
 		*(dest->grp) = ast_get_group(value);
 		break;
 	}