[svn-commits] mmichelson: branch group/CCSS r231739 - /team/group/CCSS/channels/chan_sip.c

[SVN commits to the Digium repositories]

Author: mmichelson
Date: Mon Nov 30 17:24:31 2009
New Revision: 231739

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=231739
Log:
Add XXX comment to transmit_cc_notify about some
incredibly crappy and lazy URI handling.


Modified:
    team/group/CCSS/channels/chan_sip.c

Modified: team/group/CCSS/channels/chan_sip.c
URL: http://svnview.digium.com/svn/asterisk/team/group/CCSS/channels/chan_sip.c?view=diff&rev=231739&r1=231738&r2=231739
==============================================================================
--- team/group/CCSS/channels/chan_sip.c (original)
+++ team/group/CCSS/channels/chan_sip.c Mon Nov 30 17:24:31 2009
@@ -12511,6 +12511,11 @@
 	add_header(&req, "Content-Type", "application/call-completion");
 	add_header_contentLength(&req, strlen(state_str) + strlen(agent_pvt->notify_uri));
 	add_line(&req, state_str);
+	/* XXX This is a bit haphazard. The URI should be of the form
+	 * cc-URI: <URI>, so that's lacking. Of course the URI can't just
+	 * be a random string, it needs to be an actual SIP URI. Take care of this
+	 * ASAP
+	 */
 	add_line(&req, agent_pvt->notify_uri);
 	return send_request(subscription, &req, XMIT_RELIABLE, subscription->ocseq);
 }