[svn-commits] mmichelson: branch group/CCSS r229605 - /team/group/CCSS/channels/chan_sip.c

[SVN commits to the Digium repositories]

Author: mmichelson
Date: Wed Nov 11 18:12:36 2009
New Revision: 229605

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=229605
Log:
Added some todo-esque comments with what to do
for the two unhandled PUBLISH request types.

I'm strongly considering modifying ESCs to have
callbacks for handling the specific PUBLISH request
types.


Modified:
    team/group/CCSS/channels/chan_sip.c

Modified: team/group/CCSS/channels/chan_sip.c
URL: http://svnview.digium.com/svn/asterisk/team/group/CCSS/channels/chan_sip.c?view=diff&rev=229605&r1=229604&r2=229605
==============================================================================
--- team/group/CCSS/channels/chan_sip.c (original)
+++ team/group/CCSS/channels/chan_sip.c Wed Nov 11 18:12:36 2009
@@ -22503,12 +22503,21 @@
 
 static int handle_sip_publish_modify(struct sip_pvt *p, struct sip_request *req, struct event_state_compositor *esc, const char * const eid, const int expires)
 {
+	/* This is where some real work can be done. When a PUBLISH modifies state, that's when the ESC
+	 * actually has to take some sort of action. In the case of the CC ESC, this means reporting to the
+	 * CC core that a caller is either busy or available, depending on the circumstances
+	 */
+
 	/* XXX STUB */
 	return 0;
 }
 
 static int handle_sip_publish_remove(struct sip_pvt *p, struct sip_request *req, struct event_state_compositor *esc, const char * const eid)
 {
+	/* This should be relatively simple. Just find the esc entry, delete its scheduler entry, unlink it, unref it, and it
+	 * goes away automatically. Now, there of course may be specific actions to be taken by ESCs as a result of receiving
+	 * a PUBLISH remove request.
+	 */
 	/* XXX STUB */
 	return 0;
 }