[svn-commits] russell: branch group/security_events r199738 - in /team/group/security_event...

[SVN commits to the Digium repositories]

Author: russell
Date: Tue Jun  9 07:45:52 2009
New Revision: 199738

URL: http://svn.asterisk.org/svn-view/asterisk?view=rev&rev=199738
Log:
Minor doc updates

Modified:
    team/group/security_events/include/asterisk/security_events.h
    team/group/security_events/security_events.txt

Modified: team/group/security_events/include/asterisk/security_events.h
URL: http://svn.asterisk.org/svn-view/asterisk/team/group/security_events/include/asterisk/security_events.h?view=diff&rev=199738&r1=199737&r2=199738
==============================================================================
--- team/group/security_events/include/asterisk/security_events.h (original)
+++ team/group/security_events/include/asterisk/security_events.h Tue Jun  9 07:45:52 2009
@@ -22,9 +22,6 @@
  * \brief Security Event Reporting API
  *
  * \author Russell Bryant <russell at digium.com>
- *
- * \todo Differentiate between informational and error security events
- * \todo Implement all events in security_events.txt
  */
 
 #ifndef __AST_SECURITY_EVENTS_H__

Modified: team/group/security_events/security_events.txt
URL: http://svn.asterisk.org/svn-view/asterisk/team/group/security_events/security_events.txt?view=diff&rev=199738&r1=199737&r2=199738
==============================================================================
--- team/group/security_events/security_events.txt (original)
+++ team/group/security_events/security_events.txt Tue Jun  9 07:45:52 2009
@@ -103,10 +103,6 @@
 (-) required
 (+) optional
 
-DevNotes: TODO
-  -> add definitions, test code, for all events
-  -> Add events to chan_sip as appropriate
-
 Invalid Account ID
   (-) Local address family/IP/addr/port/transport
   (-) Remote address family/IP/addr/port/transport
@@ -117,72 +113,60 @@
   (+) Session ID (CallID, etc)
   (+) Session timestamp (required if Session ID present)
   (-) Event timestamp (sub-second precision)
-  DevNotes: defined, has test code
 
 Failed ACL match
   -> everything from invalid account ID
   (+) Name of ACL (when we have named ACLs)
-  DevNotes: defined, has test code, implemented in chan_sip
 
 Invalid Challenge/Response
   -> everything from invalid account ID
   (-) Challenge
   (-) Response
   (-) Expected Response
-  DevNotes: defined, has test code
 
 Invalid Password
   -> everything from invalid account ID
-  DevNotes: defined, has test code
 
 Successful Auth
   -> informational event
   -> everything from inval account ID
-  DevNotes: defined, has test code
 
 Invalid formatting of Request
   -> everything from inval account ID
   -> account ID optional
   (-) Request Type
   (+) Request parameters
-  DevNotes: defined, has test code
 
 Session Limit Reached (such as a call limit)
   -> everything from inval account ID
-  DevNotes: defined, has test code
 
 Mem Limit Reached
   -> everything from inval account ID
-  DevNotes: defined, has test code
 
 Max Load Avg Reached
   -> everything from inval account ID
-  DevNotes: defined, has test code
 
 Request Not Allowed
   -> everything from inval account ID
   (-) Request Type
   (+) Request parameters
-  DevNotes: defined, has test code
 
 Request Not Supported
   -> everything from inval account ID
   (-) Request Type
-  DevNotes: defined, has test code
 
 Auth Method Not Allowed
   -> everything from inval account ID
   (-) Auth Method attempted
-  DevNotes: defined, has test code
-
-Custom Events (from dialplan)
-  -> driven by config file?
-  DevNotes:
 
 In dialog message from unexpected host
   -> everything from inval account ID
   (-) expected host
-  DevNotes: defined, has test code
+
+
+TODO:
+  Custom Events (from dialplan)
+    -> driven by config file?
 
 --------------------------------------------------------------------------------
 --------------------------------------------------------------------------------
@@ -222,7 +206,7 @@
 
 IE: Service
 Content: This is the Asterisk service that generated the event.
-Values: SIP
+Values: TEST, SIP, AMI
 
 IE: Module
 Content: This is the Asterisk module that generated the event.
@@ -309,8 +293,9 @@
     Security event logger
      - res/res_security_log.c
 
-    Modules partially updated to generate security events:
-     - channels/chan_sip.c
+    Modules updated to generate security events:
+     - channels/chan_sip.c (partially complete)
+     - main/manager.c
 
     Test module:
      - tests/test_security_events.c