[svn-commits] russell: branch 1.0 r477 - /branches/1.0/

[SVN commits to the Digium repositories]

Author: russell
Date: Thu Feb 12 13:23:34 2009
New Revision: 477

URL: http://svn.digium.com/svn-view/menuselect?view=rev&rev=477
Log:
Revert back to revision 464, as I am still having problems with the changes.

(related to issue #14137)

Modified:
    branches/1.0/menuselect.c
    branches/1.0/menuselect.h
    branches/1.0/menuselect_curses.c

Modified: branches/1.0/menuselect.c
URL: http://svn.digium.com/svn-view/menuselect/branches/1.0/menuselect.c?view=diff&rev=477&r1=476&r2=477
==============================================================================
--- branches/1.0/menuselect.c (original)
+++ branches/1.0/menuselect.c Thu Feb 12 13:23:34 2009
@@ -652,7 +652,6 @@
 		AST_LIST_TRAVERSE(&cat->members, mem, list) {
 			if (!strcmp(member, mem->name)) {
 				mem->was_enabled = mem->enabled = (negate ? !cat->positive_output : cat->positive_output);
-				mem->was_present = 1;
 				break;
 			}
 		}
@@ -1181,17 +1180,14 @@
 
 	AST_LIST_TRAVERSE(&categories, cat, list) {
 		AST_LIST_TRAVERSE(&cat->members, mem, list) {
-			if (!mem->defaultenabled || mem->was_present) {
+			if (!mem->defaultenabled)
 				continue;
-			}
-
-			if (mem->depsfailed == HARD_FAILURE) {
+
+			if (mem->depsfailed == HARD_FAILURE)
 				continue;
-			}
-
-			if (mem->conflictsfailed == HARD_FAILURE) {
+
+			if (mem->conflictsfailed == HARD_FAILURE)
 				continue;
-			}
 			
 			if (!strcasecmp(mem->defaultenabled, "yes")) {
 				mem->enabled = 1;
@@ -1241,9 +1237,8 @@
 			check_deps = 1;
 		else {
 			res = parse_existing_config(argv[x]);
-			if (!res && !strcasecmp(argv[x], OUTPUT_MAKEOPTS_DEFAULT)) {
+			if (!res && !strcasecmp(argv[x], OUTPUT_MAKEOPTS_DEFAULT))
 				existing_config = 1;
-			}
 			res = 0;
 		}
 	}
@@ -1255,11 +1250,10 @@
 
 	while (calc_dep_failures(0) || calc_conflict_failures(0));
 
-	process_defaults();
-	
-	if (check_deps && existing_config) {
+	if (!existing_config)
+		process_defaults();
+	else if (check_deps)
 		res = sanity_check();
-	}
 
 	while (calc_dep_failures(0) || calc_conflict_failures(0));
 	

Modified: branches/1.0/menuselect.h
URL: http://svn.digium.com/svn-view/menuselect/branches/1.0/menuselect.h?view=diff&rev=477&r1=476&r2=477
==============================================================================
--- branches/1.0/menuselect.h (original)
+++ branches/1.0/menuselect.h Thu Feb 12 13:23:34 2009
@@ -90,9 +90,6 @@
 	  we have included it in the MENUSELECT_BUILD_DEPS line
 	  in the output file */
 	unsigned int build_deps_output:1;
-	/*! This member was present in an existing configuration file, so don't
-	 * mess with it when processing default values. */
-	unsigned int was_present:1;
 	/*! dependencies of this module */
 	AST_LIST_HEAD_NOLOCK(, depend) deps;
 	/*! conflicts of this module */

Modified: branches/1.0/menuselect_curses.c
URL: http://svn.digium.com/svn-view/menuselect/branches/1.0/menuselect_curses.c?view=diff&rev=477&r1=476&r2=477
==============================================================================
--- branches/1.0/menuselect_curses.c (original)
+++ branches/1.0/menuselect_curses.c Thu Feb 12 13:23:34 2009
@@ -857,7 +857,7 @@
 		}
 		repaint_screen();
 		jiffies++;
-		usleep(2000);
+		usleep(1000);
 	}
 
 	while ((blip = AST_LIST_REMOVE_HEAD(&blips, entry)))