[svn-commits] sruffell: branch linux/sruffell/dahdi-linux-stackreduction r7079 - /linux/tea...

SVN commits to the Digium repositories svn-commits at lists.digium.com
Tue Aug 25 13:53:56 CDT 2009


Author: sruffell
Date: Tue Aug 25 13:53:53 2009
New Revision: 7079

URL: http://svn.asterisk.org/svn-view/dahdi?view=rev&rev=7079
Log:
wct4xxp-wip: Shouldn't need to lock interrupts anymore.

Modified:
    linux/team/sruffell/dahdi-linux-stackreduction/drivers/dahdi/wct4xxp/vpm450m.c

Modified: linux/team/sruffell/dahdi-linux-stackreduction/drivers/dahdi/wct4xxp/vpm450m.c
URL: http://svn.asterisk.org/svn-view/dahdi/linux/team/sruffell/dahdi-linux-stackreduction/drivers/dahdi/wct4xxp/vpm450m.c?view=diff&rev=7079&r1=7078&r2=7079
==============================================================================
--- linux/team/sruffell/dahdi-linux-stackreduction/drivers/dahdi/wct4xxp/vpm450m.c (original)
+++ linux/team/sruffell/dahdi-linux-stackreduction/drivers/dahdi/wct4xxp/vpm450m.c Tue Aug 25 13:53:53 2009
@@ -427,9 +427,6 @@
 	UINT32 ulResult;
 	struct vpm450m *vpm450m;
 	int x,y,law;
-#ifdef CONFIG_4KSTACKS
-	unsigned long flags;
-#endif
 	
 	if (!(vpm450m = kmalloc(sizeof(struct vpm450m), GFP_KERNEL)))
 		return NULL;
@@ -499,20 +496,9 @@
 		return NULL;
 	}
 
-	/* I don't know what to curse more in this comment, the problems caused by
-	 * the 4K kernel stack limit change or the octasic API for being so darn
-	 * stack unfriendly.  Stupid, stupid, stupid.  So we disable IRQs so we
-	 * don't run the risk of overflowing the stack while we initialize the
-	 * octasic. */
-#ifdef CONFIG_4KSTACKS
-	local_irq_save(flags);
-#endif
 	ulResult = Oct6100ChipOpen(vpm450m->pApiInstance, ChipOpen);
 	if (ulResult != cOCT6100_ERR_OK) {
 		printk(KERN_NOTICE "Failed to open chip, code %08x!\n", ulResult);
-#ifdef CONFIG_4KSTACKS
-		local_irq_restore(flags);
-#endif
 		kfree(vpm450m);
 		kfree(ChipOpen);
 		kfree(ChannelOpen);
@@ -567,9 +553,6 @@
 		}
 	}
 
-#ifdef CONFIG_4KSTACKS
-	local_irq_restore(flags);
-#endif
 	kfree(ChipOpen);
 	kfree(ChannelOpen);
 	return vpm450m;




More information about the svn-commits mailing list