[svn-commits] tilghman: branch 1.4 r211038 - /branches/1.4/apps/app_queue.c

SVN commits to the Digium repositories svn-commits at lists.digium.com
Fri Aug 7 13:16:33 CDT 2009


Author: tilghman
Date: Fri Aug  7 13:16:28 2009
New Revision: 211038

URL: http://svn.asterisk.org/svn-view/asterisk?view=rev&rev=211038
Log:
QUEUE_MEMBER_LIST _really_ wants the interface name, not the membername.

This is a partial revert of revision 82590, which was an attempted cleanup,
but in reality, it broke QUEUE_MEMBER_LIST, which has always been intended
as a method by which component interfaces could be queried from the queue.
Membername isn't useful here, because that field cannot be used to obtain
further information about the member.  See the documentation on
QUEUE_MEMBER_LIST, RemoveQueueMember, QUEUE_MEMBER_PENALTY, and the various
AMI commands which take a member argument for further justification.
(closes issue #15664)
 Reported by: rain
 Patches: 
       app_queue-queue_member_list.diff uploaded by rain (license 327)

Modified:
    branches/1.4/apps/app_queue.c

Modified: branches/1.4/apps/app_queue.c
URL: http://svn.asterisk.org/svn-view/asterisk/branches/1.4/apps/app_queue.c?view=diff&rev=211038&r1=211037&r2=211038
==============================================================================
--- branches/1.4/apps/app_queue.c (original)
+++ branches/1.4/apps/app_queue.c Fri Aug  7 13:16:28 2009
@@ -4297,8 +4297,8 @@
 				strncat(buf + buflen, ",", len - buflen - 1);
 				buflen++;
 			}
-			strncat(buf + buflen, m->membername, len - buflen - 1);
-			buflen += strlen(m->membername);
+			strncat(buf + buflen, m->interface, len - buflen - 1);
+			buflen += strlen(m->interface);
 			/* Safeguard against overflow (negative length) */
 			if (buflen >= len - 2) {
 				ao2_ref(m, -1);




More information about the svn-commits mailing list