[svn-commits] tilghman: tag 1.4.23-rc1 r153220 - /tags/1.4.23-rc1/
SVN commits to the Digium repositories
svn-commits at lists.digium.com
Fri Oct 31 14:35:45 CDT 2008
Author: tilghman
Date: Fri Oct 31 14:35:44 2008
New Revision: 153220
URL: http://svn.digium.com/view/asterisk?view=rev&rev=153220
Log:
Importing files for 1.4.23-rc1 release
Added:
tags/1.4.23-rc1/.lastclean (with props)
tags/1.4.23-rc1/.version (with props)
tags/1.4.23-rc1/ChangeLog (with props)
Added: tags/1.4.23-rc1/.lastclean
URL: http://svn.digium.com/view/asterisk/tags/1.4.23-rc1/.lastclean?view=auto&rev=153220
==============================================================================
--- tags/1.4.23-rc1/.lastclean (added)
+++ tags/1.4.23-rc1/.lastclean Fri Oct 31 14:35:44 2008
@@ -1,0 +1,1 @@
+32
Propchange: tags/1.4.23-rc1/.lastclean
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: tags/1.4.23-rc1/.lastclean
------------------------------------------------------------------------------
svn:keywords = none
Propchange: tags/1.4.23-rc1/.lastclean
------------------------------------------------------------------------------
svn:mime-type = text/plain
Added: tags/1.4.23-rc1/.version
URL: http://svn.digium.com/view/asterisk/tags/1.4.23-rc1/.version?view=auto&rev=153220
==============================================================================
--- tags/1.4.23-rc1/.version (added)
+++ tags/1.4.23-rc1/.version Fri Oct 31 14:35:44 2008
@@ -1,0 +1,1 @@
+1.4.23-rc1
Propchange: tags/1.4.23-rc1/.version
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: tags/1.4.23-rc1/.version
------------------------------------------------------------------------------
svn:keywords = none
Propchange: tags/1.4.23-rc1/.version
------------------------------------------------------------------------------
svn:mime-type = text/plain
Added: tags/1.4.23-rc1/ChangeLog
URL: http://svn.digium.com/view/asterisk/tags/1.4.23-rc1/ChangeLog?view=auto&rev=153220
==============================================================================
--- tags/1.4.23-rc1/ChangeLog (added)
+++ tags/1.4.23-rc1/ChangeLog Fri Oct 31 14:35:44 2008
@@ -1,0 +1,20590 @@
+2008-10-31 Tilghman Lesher <tlesher at digium.com>
+
+ * Asterisk 1.4.23-rc1 released.
+
+2008-10-31 16:30 +0000 [r153114] Tilghman Lesher <tlesher at digium.com>
+
+ * channels/chan_sip.c: Turn off qualify on uncached realtime peers.
+ (Closes issue #13383)
+
+2008-10-31 15:45 +0000 [r153095] Terry Wilson <twilson at digium.com>
+
+ * apps/app_dial.c, res/res_features.c, include/asterisk/channel.h:
+ Recent CDR fixes moved execution of the 'h' exten into the
+ bridging code, so variables that were set after ast_bridge_call
+ was called would not show up in the 'h' exten. Added a callback
+ function to handle setting variables, etc. from w/in the bridging
+ code. Calls back into a nested function within the function
+ calling ast_bridge_call (closes issue #13793) Reported by:
+ greenfieldtech
+
+2008-10-30 20:58 +0000 [r152992] Sean Bright <sean.bright at gmail.com>
+
+ * bootstrap.sh: The -I argument to aclocal needs a space before the
+ include directory name.
+
+2008-10-30 20:33 +0000 [r152922-152958] Tilghman Lesher <tlesher at digium.com>
+
+ * channels/chan_h323.c: Cannot join detached threads. See
+ http://www.opengroup.org/onlinepubs/000095399/functions/pthread_join.html
+ (Closes issue #13400)
+
+ * channels/chan_local.c: Unlock before returning, when extension
+ doesn't exist. (closes issue #13807) Reported by: eliel Patches:
+ chan_local.c.patch uploaded by eliel (license 64)
+
+2008-10-30 16:53 +0000 [r152811] Kevin P. Fleming <kpfleming at digium.com>
+
+ * main/cdr.c: instead of comparing the string pointer to 0, let's
+ compare the value that was actually parsed out of the string
+ (found by sparse)
+
+2008-10-29 05:23 +0000 [r152539] Russell Bryant <russell at digium.com>
+
+ * channels/chan_sip.c: Fix an incorrect usage of sizeof() (closes
+ issue #13795) Reported by: andrew53 Patches:
+ chan_sip_sizeof.patch uploaded by andrew53 (license 519)
+
+2008-10-29 05:19 +0000 [r152535-152538] Steve Murphy <murf at digium.com>
+
+ * configs/features.conf.sample, apps/app_dial.c, apps/app_queue.c:
+ A little documentation cross-ref between features and dial and
+ queue... I wasted some time (stupidly) trying to get the
+ one-touch parking stuff working, because it didn't occur to me
+ that I had to also have the corresponding options in the dial
+ command! Duh! (In all this time, I never set this up before!) So,
+ to keep some poor fool from suffering the same fate, I made the
+ features.conf.sample file mention the corresponding opts in
+ dial/queue; and the docs for dial/app specifically mention the
+ corresponding decls in the feature.conf file. I hope this doesn't
+ spoil some vast, eternal plan...
+
+ * apps/app_dial.c, res/res_features.c, funcs/func_channel.c,
+ include/asterisk/pbx.h, apps/app_queue.c: The magic trick to
+ avoid this crash is not to try to find the channel by name in the
+ list, which is slow and resource consuming, but rather to pay
+ attention to the result codes from the ast_bridge_call, to which
+ I added the AST_PBX_NO_HANGUP_PEER_PARKED value, which now are
+ returned when a channel is parked. If you get AST_PBX_KEEPALIVE,
+ then don't touch the channel pointer. If you get
+ AST_PBX_NO_HANGUP_PEER, or AST_PBX_NO_HANGUP_PEER_PARKED, then
+ don't touch the peer pointer. Updated the several places where
+ the results from a bridge were not being properly obeyed, and
+ fixed some code I had introduced so that the results of the
+ bridge were not overridden (in trunk). All the places that
+ previously tested for AST_PBX_NO_HANGUP_PEER now have to check
+ for both AST_PBX_NO_HANGUP_PEER and
+ AST_PBX_NO_HANGUP_PEER_PARKED. I tested this against the 4 common
+ parking scenarios: 1. A calls B; B answers; A parks B; B hangs up
+ while A is getting the parking slot announcement, immediately
+ after being put on hold. 2. A calls B; B answers; A parks B; B
+ hangs up after A has been hung up, but before the park times out.
+ 3. A calls B; B answers; B parks A; A hangs up while B is getting
+ the parking slot announcement, immediately after being put on
+ hold. 4. A calls B; B answers; B parks A; A hangs up after B has
+ been hung up, but before the park times out. No crash. I also ran
+ the scenarios above against valgrind, and accesses looked good.
+
+2008-10-28 22:32 +0000 [r152368-152463] Tilghman Lesher <tlesher at digium.com>
+
+ * apps/app_voicemail.c: Quoting in the wrong direction (Fixes
+ AST-107)
+
+ * apps/app_dial.c: Reset all DIAL variables back to blank, in case
+ Dial is called multiple times per call (which could otherwise
+ lead to inconsistent status reports). (closes issue #13216)
+ Reported by: ruddy Patches: 20081014__bug13216.diff.txt uploaded
+ by Corydon76 (license 14) Tested by: ruddy
+
+2008-10-27 23:28 +0000 [r152286] Jeff Peeler <jpeeler at digium.com>
+
+ * channels/chan_dahdi.c: Buffer policy setting for half is not
+ needed.
+
+2008-10-27 21:32 +0000 [r152215] Tilghman Lesher <tlesher at digium.com>
+
+ * channels/chan_local.c: Inherit ALL elements of CallerID across a
+ local channel. (closes issue #13368) Reported by: Peter Schlaile
+ Patches: 20080826__bug13368.diff.txt uploaded by Corydon76
+ (license 14)
+
+2008-10-26 20:23 +0000 [r152059] Sean Bright <sean.bright at gmail.com>
+
+ * funcs/func_strings.c: Since passing \0 as the second argument to
+ strchr is valid (and will match the trailing \0 of a string) we
+ need to check that first, otherwise we end up with incorrect
+ results. Fix suggested by reporter. (closes issue #13787)
+ Reported by: meitinger
+
+2008-10-25 10:59 +0000 [r151905] Russell Bryant <russell at digium.com>
+
+ * main/asterisk.c: Move AMI initialization to occur after loading
+ modules. This prevents a deadlock when someone tries to initiate
+ a module reload from the AMI just as Asterisk is starting.
+ (closes issue #13778) Reported by: hotsblanc Fix suggested by
+ hotsblanc
+
+2008-10-23 16:04 +0000 [r151763] Terry Wilson <twilson at digium.com>
+
+ * configs/features.conf.sample, res/res_features.c, CHANGES:
+ Backport fix from 1.6.0 that allows you to set
+ parkedcalltransfers=no|caller|callee|both, but default to both
+ which would be the equivalent of the existing behaviour. The
+ problem was that if someone parked a call, the callee and caller
+ would both get assigned the builtin transfer feature, which would
+ not only be potentially giving someone the ability to transfer
+ themselves when they shouldn't have it, but would also dissallow
+ reinviting the media off of the call. (closes issue #12854)
+ Reported by: davidw Patches: parkingfix4.diff.txt uploaded by
+ otherwiseguy Tested by: davidw, otherwiseguy
+
+2008-10-20 04:57 +0000 [r151240-151241] Kevin P. Fleming <kpfleming at digium.com>
+
+ * autoconf/ast_check_pwlib.m4, autoconf/ast_check_openh323.m4,
+ configure.ac: rename this macro to properly reflect what it does
+
+ * autoconf/ast_check_pwlib.m4 (added), autoconf (added),
+ autoconf/acx_pthread.m4 (added), autoconf/ast_func_fork.m4
+ (added), configure, autoconf/ast_gcc_attribute.m4 (added),
+ bootstrap.sh, autoconf/ast_check_gnu_make.m4 (added),
+ autoconf/ast_ext_lib.m4 (added), autoconf/ast_prog_ld.m4 (added),
+ autoconf/ast_c_compile_check.m4 (added),
+ autoconf/ast_c_define_check.m4 (added),
+ autoconf/ast_prog_egrep.m4 (added),
+ autoconf/ast_check_openh323.m4 (added),
+ autoconf/ast_prog_ld_gnu.m4 (added), autoconf/ast_prog_sed.m4
+ (added), acinclude.m4 (removed): break up acinclude.m4 into
+ individual files, which will make it easier to maintain, easier
+ to add new macros (less patching) and will ease maintenance of
+ these macros across Asterisk branches
+
+2008-10-19 19:51 +0000 [r151100-151167] BJ Weschke <bweschke at btwtech.com>
+
+ * main/asterisk.c: As per kpfleming's comments to the prior commit,
+ I'm reverting some of the changes here. A comment was made in bug
+ #13726 "3. The same mistake as in (2) is done in a few other
+ places in the code that check for: #if defined(HAVE_ZAPTEL) ||
+ defined(HAVE_DAHDI) Harmless, but still incorrect." In the case
+ of main/asterisk.c, this is not incorrect because without
+ HAVE_ZAPTEL defined, we're missing the include for ioctl and the
+ namespace that defines DAHDI_TIMERCONFIG which is still required
+ when using Zaptel with the 1.4 branch.
+
+ * main/asterisk.c: Fix the 1.4 branch compile again broken with
+ r150557 when using with Zaptel and not DAHDI (closes issue
+ #13740) reported by: jmls patch by: bweschke
+
+2008-10-18 01:42 +0000 [r150816] BJ Weschke <bweschke at btwtech.com>
+
+ * main/manager.c: Using the GetVar handler in AMI is potentially
+ dangerous (insta-crash [tm]) when you use a dialplan function
+ that requires a channel and then you don't provide one or provide
+ an invalid one in the Channel: parameter. We'll handle this
+ situation exactly the same way it was handled in pbx.c back on
+ r61766. We'll create a bogus channel for the function call and
+ destroy it when we're done. If we have trouble allocating the
+ bogus channel then we're not going to try executing the function
+ call at all and run the risk of crashing. (closes issue #13715)
+ reported by: makoto patch by: bweschke
+
+2008-10-17 17:18 +0000 [r150637] Steve Murphy <murf at digium.com>
+
+ * res/res_features.c: Interesting crash. In this case, you exit the
+ bridge with peer completely GONE. I moved the channel find call
+ up to cover the whole peer CDR reset code segment. This appears
+ to solve the crash without changing the logic at all.
+
+2008-10-17 15:31 +0000 [r150557] Jason Parker <jparker at digium.com>
+
+ * main/asterisk.c, main/channel.c, channels/chan_dahdi.c,
+ configure, configure.ac: Correctly allow chan_dahdi to compile
+ against older versions of Zaptel. Don't always define
+ HAVE_ZAPTEL_CHANALARMS (since we check if it's defined..) Minor
+ cleanup to make things clear. (closes issue #13726) Reported by:
+ tzafrir Patches: dahdi_def.diff uploaded by tzafrir (license 46)
+
+2008-10-16 23:40 +0000 [r150298-150304] Mark Michelson <mmichelson at digium.com>
+
+ * main/manager.c: Reverting changes from commits 150298 and 150301
+ since I was mistakenly under the assumption that dialplan
+ functions *always* required that a channel be present. I need to
+ go home earlier, I think :)
+
+ * main/manager.c: And don't forget to return on the error condition
+
+ * main/manager.c: Don't try to call a dialplan function's read
+ callback from the manager's GetVar handler if an invalid channel
+ has been specified. Several dialplan functions, including CHANNEL
+ and SIP_HEADER, do not check for NULL-ness of the channel being
+ passed in. (closes issue #13715) Reported by: makoto
+
+2008-10-16 15:56 +0000 [r150124] Richard Mudgett <rmudgett at digium.com>
+
+ * channels/chan_misdn.c: Fix memory leak found by customer
+
+2008-10-16 15:26 +0000 [r150056] Steve Murphy <murf at digium.com>
+
+ * cdr/cdr_odbc.c: This patch is relevant to: ABE-1628 and
+ RYM-150398 and AST-103 in internal Digium bug trackers. These
+ fixes address a really subtle memory corruption problem that
+ would happen in machines heavily loaded in production
+ environments. The corruption would always take the form of the
+ STMT object getting nulled out and one of the unixODBC calls
+ would crash trying to access statement->connection. It isn't
+ fully proven yet, but the server has now been running 2.5 days
+ without appreciable memory growth, or any gain of %cpu, and no
+ crashes. Whether this is the problem or not on that server, these
+ fixes are still warranted. As it turns out, **I** introduced
+ these errors unwittingly, when I corrected another crash earlier.
+ I had formed the build_query routine, and failed to remove
+ mutex_unlock calls in 3 places in the transplanted code. These
+ unlocks would only happen in error situations, but unlocking the
+ mutex early set the code up for a catastrophic failure, it
+ appears. It would happen only once every 100K-200K or more calls,
+ under heavy load... but that is enough. If another crash occurs,
+ with the same MO, I'll come back and remove my confession from
+ the log, and we'll keep searching, but the fact that we have
+ Asterisk dying from an asynchronous wiping of the STMT object,
+ only on some connection error, and that the server has lived for
+ 2.5 days on this code without a crash, sure make it look like
+ this was the problem! Also, in several points, Statement handles
+ are set to NULL after SQLFreeHandle. This was mainly for
+ insurance, to guarantee a crash. As it turns out, the code does
+ not appear to be attempting to use these freed pointers. Asterisk
+ owes a debt of gratitude to Federico Alves and Frediano Ziglio
+ for their untiring efforts in finding this bug, among others.
+
+2008-10-15 21:34 +0000 [r149683-149840] BJ Weschke <bweschke at btwtech.com>
+
+ * CHANGES: Another documentation fix. (closes issue #13708)
+
+ * configs/agents.conf.sample: An update to the
+ documentation/example of agents.conf.sample with the correct
+ parameter for this feature as defined in chan_agent.c (closes
+ issue #13709)
+
+2008-10-15 10:30 +0000 [r149452] Kevin P. Fleming <kpfleming at digium.com>
+
+ * channels/chan_sip.c: fix some problems when parsing SIP messages
+ that have the maximum number of headers or body lines that we
+ support
+
+2008-10-14 23:43 +0000 [r149130-149266] Mark Michelson <mmichelson at digium.com>
+
+ * channels/chan_sip.c: Change this warning to an error message.
+ Suggestion comes from Sean Bright. Thanks Sean!
+
+ * channels/chan_sip.c: Call register_peer_exten even in the case
+ that the peer's IP/port does not change. (closes issue #13309)
+ Reported by: dimas Patches: v2-13309.patch uploaded by dimas
+ (license 88)
+
+ * include/asterisk/audiohook.h, main/audiohook.c: Add a tolerance
+ period for sync-triggered audiohooks so that if packetization of
+ audio is close (but not equal) we don't end up flushing the
+ audiohooks over small inconsistencies in synchronization. Related
+ to issue #13005, and solves the issue for most people who were
+ experiencing the problem. However, a small number of people are
+ still experiencing the problem on long calls, so I am not closing
+ the issue yet
+
+ * apps/app_queue.c: Update the queue with the correct number of
+ calls and whether the call was completed within the service level
+ when a transfer takes place. This way, we do not "break" the
+ leastrecent and fewestcalls strategies by not logging a call
+ until after the transferred call has ended. (closes issue #13395)
+ Reported by: Marquis Patches: app_queue.c.transfer.patch uploaded
+ by Marquis (license 32)
+
+ * channels/chan_sip.c: Don't allow reserved characters to be used
+ in register lines in sip.conf. (closes issue #13570) Reported by:
+ putnopvut
+
+2008-10-14 20:09 +0000 [r149061] Tilghman Lesher <tlesher at digium.com>
+
+ * apps/app_waitforsilence.c: Check correct values in the return of
+ ast_waitfor(); also, get rid of a possible memory leak. (closes
+ issue #13658) Reported by: explidous Patch by: me
+
+2008-10-14 19:05 +0000 [r148990] Leif Madsen <lmadsen at digium.com>
+
+ * CHANGES: Add in some missing updates to the CHANGES file for
+ sip.conf (closes issue #13100) Reported and patch by:
+ gknispel_proformatique
+
+2008-10-14 19:03 +0000 [r148916-148987] Tilghman Lesher <tlesher at digium.com>
+
+ * apps/app_voicemail.c: Some compilers warn, some don't. Fixing.
+
+ * apps/app_voicemail.c: Ensure that mail headers are 7-bit clean,
+ even when UTF-8 characters are used in headers like 'Subject' and
+ 'To'. Closes AST-107.
+
+2008-10-14 17:33 +0000 [r148912] Mark Michelson <mmichelson at digium.com>
+
+ * channels/chan_local.c: Deadlock prevention in chan_local. (closes
+ issue #13676) Reported by: tacvbo Patches: 13676.patch uploaded
+ by putnopvut (license 60) Tested by: tacvbo
+
+2008-10-14 10:30 +0000 [r148611-148736] Kevin P. Fleming <kpfleming at digium.com>
+
+ * Makefile: on Ubuntu (at least), recent versions of ld in binutils
+ delete all debugging symbols when -x is supplied; since the
+ reasons why -x is being passed are lost in the mists of time,
+ remove it so debugging will work properly
+
+ * main/translate.c: it would be nice if this message printing code
+ had actually been tested before it was committed...
+
+2008-10-10 16:25 +0000 [r147997-148257] Tilghman Lesher <tlesher at digium.com>
+
+ * apps/app_voicemail.c: User not notified of temporary greeting, if
+ ODBC storage is in use. (closes issue #13659) Reported by:
+ moliveras Patches: 20081009__bug13659.diff.txt uploaded by
+ Corydon76 (license 14) Tested by: moliveras
+
+ * apps/app_voicemail.c: When blank, callerid name and number should
+ display "unknown caller" in voicemail emails. (Closes issue
+ #13643)
+
+2008-10-09 18:56 +0000 [r147941] Jeff Peeler <jpeeler at digium.com>
+
+ * res/res_features.c: (closes issue #13139) Reported by: krisk84
+ Tested by: krisk84 This change prevents a call that is placed in
+ the parkinglot to be picked up before the PBX is finished. If
+ another extension dials the parking extension before the PBX
+ thread has completed at minimum warnings will occur about the PBX
+ not properly being terminated. At worst, a crash could occur.
+
+2008-10-08 22:22 +0000 [r147681] Kevin P. Fleming <kpfleming at digium.com>
+
+ * channels/chan_dahdi.c: when parsing a text configuration option,
+ ensure that the buffer on the stack is actually large enough to
+ hold the legal values of that option, and also ensure that
+ sscanf() knows to stop parsing if it would overrun the buffer
+ (without these changes, specifying "buffers=...,immediate" would
+ overflow the buffer on the stack, and could not have worked as
+ expected)
+
+2008-10-08 14:51 +0000 [r147517] Joshua Colp <jcolp at digium.com>
+
+ * apps/app_speech_utils.c: If we receive DTMF make sure that the
+ state of the speech structure goes back to being not ready.
+ (issue #LUMENVOX-8)
+
+2008-10-07 23:14 +0000 [r147429-147430] Kevin P. Fleming <kpfleming at digium.com>
+
+ * channels/chan_dahdi.c: revert this change until i can understand
+ why it results in locking order changes
+
+ * channels/chan_dahdi.c: don't start a PBX on incoming PRI call
+ channels until after we're done setting channel variables and
+ other things on the channel, otherwise the channel might go away
+ (if the dialplan hangs up quickly) before we are done, which
+ results in a spectacular crash
+
+2008-10-07 16:48 +0000 [r147193] Sean Bright <sean.bright at gmail.com>
+
+ * apps/app_voicemail.c: Make 'imapsecret' an alias to
+ 'imappassword' in voicemail.conf.
+
+2008-10-06 20:52 +0000 [r146711-146799] Tilghman Lesher <tlesher at digium.com>
+
+ * funcs/func_callerid.c, apps/app_speech_utils.c,
+ funcs/func_curl.c, funcs/func_groupcount.c, res/res_smdi.c,
+ channels/chan_sip.c, funcs/func_timeout.c, funcs/func_odbc.c,
+ funcs/func_cdr.c, funcs/func_math.c, channels/chan_iax2.c:
+ Dialplan functions should not actually return 0, unless they have
+ modified the workspace. To signal an error (and no change to the
+ workspace), -1 should be returned instead. (closes issue #13340)
+ Reported by: kryptolus Patches: 20080827__bug13340__2.diff.txt
+ uploaded by Corydon76 (license 14)
+
+ * channels/chan_local.c: Check whether an extension exists in the
+ _call method, rather than the _alloc method, because we need to
+ evaluate the callerid (since that data affects whether an
+ extension exists). (closes issue #13343) Reported by: efutch
+ Patches: 20080915__bug13343.diff.txt uploaded by Corydon76
+ (license 14) Tested by: efutch
+
+2008-10-06 15:57 +0000 [r146643] Kevin P. Fleming <kpfleming at digium.com>
+
+ * channels/chan_dahdi.c: ensure that the private structure for
+ pseudo channels is created without 'leaking' configuration data
+ from other configured channels (closes issue #13555) Reported by:
+ jeffg Patches: issue_13555.patch uploaded by kpfleming (license
+ 421) Tested by: jeffg
+
+2008-10-05 21:17 +0000 [r146448] Jason Parker <jparker at digium.com>
+
+ * channels/chan_sip.c: Fix silly formatting.
+
+2008-10-03 22:51 +0000 [r146244] Sean Bright <sean.bright at gmail.com>
+
+ * apps/app_rpt.c: Change some preprocessor macros to struct
+ definitions so that we get app_rpt to build with DAHDI. (closes
+ issue #13576) Reported by: blitzrage
+
+2008-10-03 20:44 +0000 [r146129] Jeff Peeler <jpeeler at digium.com>
+
+ * include/asterisk/features.h, res/res_features.c, res/res_agi.c:
+ (closes issue #13425) Reported by: mdu113 Tested by: mdu113
+ Similar to r143204, masquerade the channel in the case of Park
+ being called from AGI.
+
+2008-10-03 17:12 +0000 [r146026] Steve Murphy <murf at digium.com>
+
+ * res/res_features.c: (closes issue #13579) Reported by: dwagner
+ (closes issue #13584) Reported by: dwagner Tested by: murf,
+ putnopvut The thought occurred to me that the res= from the
+ extension spawn was ending up being returned from the bridge.
+ "Thou shalt not poison the return value". Made the change and it
+ appears to allow blind xfers to work as normal. If I'm wrong,
+ reopen the bugs. But it looks good to me! Many thanks to
+ putnopvut for helping me reproduce this!
+
+2008-10-02 16:39 +0000 [r145751-145839] Tilghman Lesher <tlesher at digium.com>
+
+ * funcs/func_odbc.c: Backport support for some of the keyword
+ modifications used in 1.6 (while warning that some options aren't
+ really supported) and add some warning messages. Some credit to
+ oej, who was complaining in #asterisk-dev.
+
+ * res/res_odbc.c: Some sanity checks that may have led to prior
+ crashes, found by codefreeze-lap (murf) on IRC. Also some cleanup
+ of incorrectly-used constants.
+
+2008-10-01 17:18 +0000 [r145479] Leif Madsen <lmadsen at digium.com>
+
+ * contrib/scripts/realtime_pgsql.sql: Update the realtime_pgsql.sql
+ script to create the setinterfacevar column. (closes issue
+ #13549) Reported by: fiddur
+
+2008-10-01 Russell Bryant <russell at digium.com>
+
+ * Asterisk 1.4.22 released.
+
+2008-09-09 Russell Bryant <russell at digium.com>
+
+ * Asterisk 1.4.22-rc5 released.
+
+2008-09-09 15:40 +0000 [r142063] Russell Bryant <russell at digium.com>
+
+ * res/res_features.c: Ensure that the stored CDR reference is still
+ valid after the bridge before poking at it. Also, keep the
+ channel locked while messing with this CDR. (fixes crashes
+ reported in issue #13409)
+
+2008-09-08 21:10 +0000 [r141809] Mark Michelson <mmichelson at digium.com>
+
+ * channels/chan_sip.c: Fix pedantic mode of chan_sip to only check
+ the remote tag of an endpoint once a dialog has been confirmed.
+ Up until that point, it is possible and legal for the far-end to
+ send provisional responses with a different To: tag each time.
+ With this patch applied, these provisional messages will not
+ cause a matching problem. (closes issue #11536) Reported by: ibc
+ Patches: 11536v2.patch uploaded by putnopvut (license 60)
+
+2008-09-08 21:02 +0000 [r141806] Russell Bryant <russell at digium.com>
+
+ * main/pbx.c: When doing an async goto, detect if the channel is
+ already in the middle of a masquerade. This can happen when
+ chan_local is trying to optimize itself out. If this happens,
+ fail the async goto instead of bursting into flames. (closes
+ issue #13435) Reported by: geoff2010
+
+2008-09-08 Russell Bryant <russell at digium.com>
+
+ * Asterisk 1.4.22-rc4 released.
+
+2008-09-08 20:15 +0000 [r141741] Jason Parker <jparker at digium.com>
+
+ * Makefile, redhat (removed): Remove RPM package targets from
+ Makefile (and all associated parts). This has never worked in
+ 1.4, and we decided that it makes no sense to be done here. There
+ are many distros out there that already have "proper" spec files
+ that can be (re)used. Closes issue #13113 Closes issue #10950
+ Closes issue #10952
+
+2008-09-08 16:26 +0000 [r141678] Russell Bryant <russell at digium.com>
+
+ * configure, configure.ac: Actually use Zaptel CFLAGS if using
+ Zaptel instead of DAHDI This fixes building against Zaptel when
+ using a custom path
+
+2008-09-06 20:13 +0000 [r141565] Steve Murphy <murf at digium.com>
+
+ * channels/chan_sip.c: This fix comes from Joshua Colp The
+ Brilliant, who, given the trace, came up with a solution. This
+ will most likely will close 13235 and 13409. I'll wait till
+ Monday to verify, and then close these bugs.
+
+2008-09-06 15:23 +0000 [r141503] Tilghman Lesher <tlesher at digium.com>
+
+ * res/res_agi.c: Reverting behavior change (AGI should not exit
+ non-zero on SUCCESS) (closes issue #13434) Reported by:
+ francesco_r
+
+2008-09-05 21:10 +0000 [r141217-141366] Mark Michelson <mmichelson at digium.com>
+
+ * channels/chan_agent.c: Agent's should not try to call a channel's
+ indicate callback if the channel has been hung up. It will likely
+ crash otherwise ABE-1159
+
+ * apps/app_voicemail.c: Since greetings are not stored in IMAP, we
+ should not be DISPOSE'ing of them the same way we do with other
+ messages. (closes issue #13414) Reported by: mthomasslo Patches:
+ 13414v2.patch uploaded by putnopvut (license 60) Tested by:
+ mthomasslo
+
+ * channels/chan_sip.c: Commit 140417 had a logic flaw in it which
+ caused port 5060 to always be used when dialing a peer if no
+ explicit port was specified. This broke the behavior of
+ implicitly using the port from which the peer registered if no
+ port is specified. This commit fixes the logic flaw. (closes
+ issue #13424) Reported by: mdu113 Patches: 13424.patch uploaded
+ by putnopvut (license 60) Tested by: mdu113
+
+2008-09-05 14:15 +0000 [r141094-141156] Steve Murphy <murf at digium.com>
+
+ * main/channel.c: A small change to prevent double-posting of
+ CDR's; thanks to Daniel Ferrer for bringing it to our attention
+
+ * pbx/ael/ael-test/ref.ael-vtest25 (added),
+ pbx/ael/ael-test/ael-vtest25/extensions.ael (added),
+ pbx/ael/ael-test/ael-vtest25 (added), pbx/ael/ael_lex.c,
+ pbx/ael/ael-test/ref.ael-test6, pbx/ael/ael.flex: (closes issue
+ #13357) Reported by: pj Tested by: murf (closes issue #13416)
+ Reported by: yarns Tested by: murf If you find this message
+ overly verbose, relax, it's probably not meant for you. This
+ message is meant for probably only two people in the whole world:
+ me, or the poor schnook that has to maintain this code because
+ I'm either dead or unavailable at the moment. This fix solves two
+ reports, both having to do with embedding a function call in a
+ ${} construct. It was tricky because the funccall syntax has
+ parenthesis () in it. And up till now, the 'word' token in the
+ flex stuff didn't allow that, because it would tend to steal the
+ LP and RP tokens. To be truthful, the "word" token was the
+ trickiest, most unstable thing in the whole lexer. I was lucky it
+ made this long without complaints. I had to choose every
+ character in the pattern with extreme care, and I knew that
+ someday I'd have to revisit it. Well, the day has come. So, my
+ brilliant idea (and I'm being modest), was to use the surrounding
+ ${} construct to make a state machine and capture everything in
+ it, no matter what it contains. But, I have to now treat the word
+ token like I did with comments, in that I turn the whole thing
+ into a state-machine sort of spec, with new contexts
+ "curlystate", "wordstate", and "brackstate". Wait a minute,
+ "brackstate"? Yes, well, it didn't take very many regression
+ tests to point out if I do this for ${} constructs, I also have
+ to do it with the $[] constructs, too. I had to create a separate
+ pcbstack2 and pcbstack3 because these constructs can occur inside
+ macro argument lists, and when we have two state machines
+ operating on the same structures we'd get problems otherwise. I
+ guess I could have stopped at pcbstack2 and had the brackstate
+ stuff share it, but it doesn't hurt to be safe. So, the pcbpush
+ and pcbpop routines also now have versions for "2" and "3". I had
+ to add the {KEYWORD} construct to the initial pattern for "word",
+ because previously word would match stuff like "default7",
+ because it was a longer match than the keyword "default". But,
+ not any more, because the word pattern only matches only one or
+ two characters now, and it will always lose. So, I made it the
+ winner again by making an optional match on any of the keywords
+ before it's normal pattern. I added another regression test to
+ make sure we don't lose this in future edits, and had to fix just
+ one regression, where it no longer reports a 'cascaded' error,
+ which I guess is a plus. I've given some thought as to whether to
+ apply these fixes to 1.4 and the 1.6.x releases, vs trunk; I
+ decided to put it in 1.4 because one of the bug reports was
+ against 1.4; and it is unexpected that AEL cannot handle this
+ situation. It actually reduced the amount of useless "cascade"
+ error messages that appeared in the regressions (by one line,
+ ehhem). There is a possible side-effect in that it does now do
+ more careful checking of what's in those ${} constructs, as far
+ as matching parens, and brackets are concerned. Some users may
+ find a an insidious problem and correct it this way. This should
+ be exceedingly rare, I hope.
+
+2008-09-04 17:00 +0000 [r141028] Jeff Peeler <jpeeler at digium.com>
+
+ * res/res_features.c, res/res_agi.c: (closes issue #11979) Fixes
+ multiple parking problems: Crash when executing a park on an
+ extension dialed by AGI due to not returning the proper return
+ code. Crash when using a builtin feature that was a subset of a
+ enabled dynamic feature. Crash due to always hanging up the peer
+ despite the fact that the peer was supposed to be parked.
+
+2008-09-03 Russell Bryant <russell at digium.com>
+
+ * Asterisk 1.4.22-rc3 released.
+
+2008-09-03 14:29 +0000 [r140850] Mark Michelson <mmichelson at digium.com>
+
+ * apps/app_voicemail.c: Fix voicemail forwarding when using ODBC
+ storage. (closes issue #13387) Reported by: moliveras Patches:
+ 13387.patch uploaded by putnopvut (license 60) Tested by:
+ putnopvut, moliveras
+
+2008-09-03 13:24 +0000 [r140816] Russell Bryant <russell at digium.com>
+
+ * main/poll.c: Don't freak out if the poll emulation receives NULL
+ for the pollfds array (closes issue #13307) Reported by: jcovert
+
+2008-09-02 23:47 +0000 [r140751] Mark Michelson <mmichelson at digium.com>
+
+ * apps/app_voicemail.c: After adding the context checking to
+ app_voicemail for IMAP storage, I left out a crucial place to
+ copy the context to the vm_state structure. This is the
+ correction.
+
+2008-09-02 23:36 +0000 [r140670-140747] Steve Murphy <murf at digium.com>
+
+ * main/cdr.c: I am turning the warnings generated in ast_cdr_free
+ and post_cdr into verbose level 2 messages. Really, they matter
+ little to end users. You either get the CDR's you wanted, or you
+ don't, and it is a bug.
+
+ * main/channel.c: After reconsidering, with respect to 13409,
+ ast_cdr_detach should be OK, better in fact, than ast_cdr_free,
+ which generates lots of useless warnings that will undoubtably
+ generate complaints.
+
+ * main/channel.c, main/pbx.c: (closes issue #13409) Reported by:
+ tomaso Patches: asterisk-1.6.0-rc2-cdrmemleak.patch uploaded by
+ tomaso (license 564) I basically spent the day, verifying that
+ this patch solves the problem, and doesn't hurt in non-problem
+ cases. Why valgrind did not plainly reveal this leak absolutely
+ mystifies and stuns me. Many, many thanks to tomaso for finding
+ and providing the fix.
+
+2008-09-02 18:14 +0000 [r140605] Sean Bright <sean.bright at gmail.com>
+
+ * channels/chan_iax2.c: Make sure to use the correct length of the
+ mohinterpret and mohsuggest buffers when copying configuration
+ values. (closes issue #13336) Reported by:
+ decryptus_proformatique Patches:
+ chan_iax2_mohinterpret_mohsuggest_general_settings.patch uploaded
+ by decryptus (license 555)
+
+2008-08-29 17:34 +0000 [r140417-140488] Mark Michelson <mmichelson at digium.com>
+
+ * main/manager.c, apps/app_queue.c, channels/chan_iax2.c: After
+ working on the ao2_containers branch, I noticed something a bit
+ strange. In all cases where we provide a callback function to
+ ao2_container_alloc, the callback function would only return 0 or
+ CMP_MATCH. After inspecting the ao2_callback() code carefully, I
+ found that if you're only looking for one specific item, then you
+ should return CMP_MATCH | CMP_STOP. Otherwise, astobj2 will
+ continue traversing the current bucket until the end searching
+ for more matches. In cases like chan_iax2 where in 1.4, all the
+ peers are shoved into a single bucket, this makes for potentially
+ terrible performance since the entire bucket will be traversed
+ even if the peer is one of the first ones come across in the
+ bucket. All the changes I have made were for cases where the
+ callback function defined was passed to ao2_container_alloc so
+ that calls to ao2_find could find a unique instance of whatever
+ object was being stored in the container.
+
+ * apps/app_voicemail.c: Add context checking when retrieving a
+ vm_state. This was causing a problem for people who had
+ identically named mailboxes in separate voicemail contexts. This
+ commit affects IMAP storage only. (closes issue #13194) Reported
+ by: moliveras Patches: 13194.patch uploaded by putnopvut (license
+ 60) Tested by: putnopvut, moliveras
+
+ * channels/chan_sip.c: Fix SIP's parsing so that if a port is
+ specified in a string to Dial(), it is not ignored. (closes issue
+ #13355) Reported by: acunningham Patches: 13355v2.patch uploaded
+ by putnopvut (license 60) Tested by: acunningham
+
+2008-08-27 19:49 +0000 [r140299] Mark Michelson <mmichelson at digium.com>
+
+ * channels/chan_sip.c: Fix tag checking in get_sip_pvt_byid_locked
+ when in pedantic mode. The problem was that the wrong tags would
+ be compared depending on the direction of the call. (closes issue
+ #13353) Reported by: flefoll Patches:
+ chan_sip.c.br14.139015.patch-refer-pedantic uploaded by flefoll
+ (license 244)
+
+2008-08-26 16:49 +0000 [r140115] Jeff Peeler <jpeeler at digium.com>
+
+ * channels/chan_dahdi.c: add HAVE_PRI if define around
+ dahdi_close_pri_fd
+
+2008-08-26 16:07 +0000 [r140060] Russell Bryant <russell at digium.com>
+
+ * channels/chan_sip.c: Fix some bogus scheduler usage in chan_sip.
+ This code used the return value of a completely unrelated
+ function to determine whether the scheduler should be run or not.
+ This would have caused the scheduler to not run in cases where it
+ should have. Also, leave a note about another scheduler issue
+ that needs to be addressed at some point.
+
+2008-08-26 15:57 +0000 [r140056] Jeff Peeler <jpeeler at digium.com>
+
+ * channels/chan_dahdi.c: (closes issue #12071) Reported by: tzafrir
+ Patches: dahdi_close.diff uploaded by tzafrir (license 46) Tested
+ by: tzafrir, jpeeler This patch fixes closing open file
+ descriptors in the case of an error.
+
+2008-08-26 15:27 +0000 [r140051] Russell Bryant <russell at digium.com>
+
+ * channels/chan_iax2.c: Fix a race condition with the IAX scheduler
+ thread. A lock and condition are used here to allow newly
+ scheduled tasks to wake up the scheduler just in case the new
+ task needs to run sooner than the current wakeup time when the
+ thread is sleeping. However, there was a race condition such that
+ a newly scheduled task would not properly wake up the scheduler
+ or affect the wake up period. The order of execution would have
+ been: 1) Scheduler thread determines wake up time of N ms. 2)
+ Another thread schedules a task and signals the condition, with
+ an execution time of < N ms. 3) Scheduler thread locks and goes
+ to sleep for N ms. By moving the sleep time determination to
+ inside the critical section, this possibility is avoided.
+
+2008-08-26 15:22 +0000 [r140050] Terry Wilson <twilson at digium.com>
+
+ * Makefile: sounds/Makefile installs sounds using the "new"
+ language directory structure, but languageprefix needs to be set
+ = yes for sounds in subdirectories (digits/1, etc.) to play as
+ the correct language. Fix the generation of asterisk.conf to
+ include languageprefix=yes
+
+2008-08-26 14:09 +0000 [r140029] Kevin P. Fleming <kpfleming at digium.com>
+
+ * channels/chan_dahdi.c: correct a file location in an error
+ message
+
+2008-08-25 21:47 +0000 [r139927] Jeff Peeler <jpeeler at digium.com>
+
+ * main/manager.c: Fix a typo I made. Lesson learned, apply the
+ patch if one exists.
+
+2008-08-25 21:31 +0000 [r139909] Sean Bright <sean.bright at gmail.com>
+
+ * build_tools/get_moduleinfo, build_tools/get_makeopts: Some
+ versions of awk (nawk, for example) don't like empty regular
+ expressions so be slightly more verbose. (closes issue #13374)
+ Reported by: dougm Patches: 13374.diff uploaded by seanbright
+ (license 71) Tested by: dougm
+
+2008-08-25 20:46 +0000 [r139869] Terry Wilson <twilson at digium.com>
+
+ * channels/chan_sip.c: Make SIPADDHEADER() propagate indefinitely
+
+2008-08-25 15:52 +0000 [r139769] Mark Michelson <mmichelson at digium.com>
+
+ * main/config.c: Fix the logic in config_text_file_save so that if
+ an UpdateConfig manager action is issued and the file specified
[... 19825 lines stripped ...]
More information about the svn-commits
mailing list