[svn-commits] tilghman: branch 1.4 r125793 - in /branches/1.4: include/asterisk/ main/

[SVN commits to the Digium repositories]

Author: tilghman
Date: Fri Jun 27 08:45:03 2008
New Revision: 125793

URL: http://svn.digium.com/view/asterisk?view=rev&rev=125793
Log:
In this debugging function, copy to a buffer instead of using potentially unsafe pointers.

Modified:
    branches/1.4/include/asterisk/lock.h
    branches/1.4/main/utils.c

Modified: branches/1.4/include/asterisk/lock.h
URL: http://svn.digium.com/view/asterisk/branches/1.4/include/asterisk/lock.h?view=diff&rev=125793&r1=125792&r2=125793
==============================================================================
--- branches/1.4/include/asterisk/lock.h (original)
+++ branches/1.4/include/asterisk/lock.h Fri Jun 27 08:45:03 2008
@@ -186,9 +186,9 @@
  * be preserved as to what location originally acquired the lock.
  */
 #if !defined(LOW_MEMORY)
-int ast_find_lock_info(void *lock_addr, const char **filename, int *lineno, const char **func, const char **mutex_name);
+int ast_find_lock_info(void *lock_addr, char *filename, size_t filename_size, int *lineno, char *func, size_t func_size, char *mutex_name, size_t mutex_name_size);
 #else
-#define ast_find_lock_info(a,b,c,d,e) -1
+#define ast_find_lock_info(a,b,c,d,e,f,g,h) -1
 #endif
 
 /*!
@@ -199,9 +199,9 @@
  */
 #define DEADLOCK_AVOIDANCE(lock) \
 	do { \
-		const char *__filename, *__func, *__mutex_name; \
+		char __filename[80], __func[80], __mutex_name[80]; \
 		int __lineno; \
-		int __res = ast_find_lock_info(lock, &__filename, &__lineno, &__func, &__mutex_name); \
+		int __res = ast_find_lock_info(lock, __filename, sizeof(__filename), &__lineno, __func, sizeof(__func), __mutex_name, sizeof(__mutex_name)); \
 		ast_mutex_unlock(lock); \
 		usleep(1); \
 		if (__res < 0) { /* Shouldn't ever happen, but just in case... */ \

Modified: branches/1.4/main/utils.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/main/utils.c?view=diff&rev=125793&r1=125792&r2=125793
==============================================================================
--- branches/1.4/main/utils.c (original)
+++ branches/1.4/main/utils.c Fri Jun 27 08:45:03 2008
@@ -676,7 +676,7 @@
 	pthread_mutex_unlock(&lock_info->lock);
 }
 
-int ast_find_lock_info(void *lock_addr, const char **filename, int *lineno, const char **func, const char **mutex_name)
+int ast_find_lock_info(void *lock_addr, char *filename, size_t filename_size, int *lineno, char *func, size_t func_size, char *mutex_name, size_t mutex_name_size)
 {
 	struct thr_lock_info *lock_info;
 	int i = 0;
@@ -697,10 +697,10 @@
 		return -1;
 	}
 
-	*filename = lock_info->locks[i].file;
+	ast_copy_string(filename, lock_info->locks[i].file, filename_size);
 	*lineno = lock_info->locks[i].line_num;
-	*func = lock_info->locks[i].func;
-	*mutex_name = lock_info->locks[i].lock_name;
+	ast_copy_string(func, lock_info->locks[i].func, func_size);
+	ast_copy_string(mutex_name, lock_info->locks[i].lock_name, mutex_name_size);
 
 	pthread_mutex_unlock(&lock_info->lock);