[svn-commits] tilghman: trunk r102190 - /trunk/main/manager.c
SVN commits to the Digium repositories
svn-commits at lists.digium.com
Sun Feb 3 11:40:48 CST 2008
Author: tilghman
Date: Sun Feb 3 11:40:48 2008
New Revision: 102190
URL: http://svn.digium.com/view/asterisk?view=rev&rev=102190
Log:
CoreSettings and CoreStatus are missing the terminating "\r\n". Also, some
miscellaneous spacing and initialization issues.
(closes issue #11909)
Reported by: srt
Patches:
patch-11909-2.diff uploaded by srt (license 378)
Tested by: srt
Modified:
trunk/main/manager.c
Modified: trunk/main/manager.c
URL: http://svn.digium.com/view/asterisk/trunk/main/manager.c?view=diff&rev=102190&r1=102189&r2=102190
==============================================================================
--- trunk/main/manager.c (original)
+++ trunk/main/manager.c Sun Feb 3 11:40:48 2008
@@ -559,7 +559,7 @@
return CLI_SUCCESS;
}
- ast_cli(a->fd,"\n");
+ ast_cli(a->fd, "\n");
ast_cli(a->fd,
" username: %s\n"
" secret: %s\n"
@@ -616,8 +616,8 @@
AST_RWLIST_UNLOCK(&users);
- ast_cli(a->fd,"-------------------\n");
- ast_cli(a->fd,"%d manager users configured.\n", count_amu);
+ ast_cli(a->fd, "-------------------\n");
+ ast_cli(a->fd, "%d manager users configured.\n", count_amu);
return CLI_SUCCESS;
}
@@ -703,7 +703,7 @@
}
AST_LIST_LOCK(&all_events);
AST_LIST_TRAVERSE(&all_events, s, eq_next) {
- ast_cli(a->fd, "Usecount: %d\n",s->usecount);
+ ast_cli(a->fd, "Usecount: %d\n", s->usecount);
ast_cli(a->fd, "Category: %d\n", s->category);
ast_cli(a->fd, "Event:\n%s", s->eventdata);
}
@@ -915,7 +915,7 @@
#define MSG_MOREDATA ((char *)astman_send_response)
static void astman_send_response_full(struct mansession *s, const struct message *m, char *resp, char *msg, char *listflag)
{
- const char *id = astman_get_header(m,"ActionID");
+ const char *id = astman_get_header(m, "ActionID");
astman_append(s, "Response: %s\r\n", resp);
if (!ast_strlen_zero(id))
@@ -1223,7 +1223,7 @@
} else if (!strcasecmp(action, "append")) {
if (!ast_strlen_zero(cat) && !ast_strlen_zero(var) &&
(category = ast_category_get(cfg, cat)) &&
- (v = ast_variable_new(var, value, dfn))){
+ (v = ast_variable_new(var, value, dfn))) {
if (object || (match && !strcasecmp(match, "object")))
v->object = 1;
ast_variable_append(category, v);
@@ -1293,11 +1293,13 @@
int timeout = -1;
int x;
int needexit = 0;
- const char *id = astman_get_header(m,"ActionID");
- char idText[256] = "";
+ const char *id = astman_get_header(m, "ActionID");
+ char idText[256];
if (!ast_strlen_zero(id))
snprintf(idText, sizeof(idText), "ActionID: %s\r\n", id);
+ else
+ idText[0] = '\0';
if (!ast_strlen_zero(timeouts)) {
sscanf(timeouts, "%i", &timeout);
@@ -1574,18 +1576,20 @@
/* Needs documentation... */
static int action_status(struct mansession *s, const struct message *m)
{
- const char *name = astman_get_header(m,"Channel");
+ const char *name = astman_get_header(m, "Channel");
struct ast_channel *c;
char bridge[256];
struct timeval now = ast_tvnow();
long elapsed_seconds = 0;
int channels = 0;
int all = ast_strlen_zero(name); /* set if we want all channels */
- const char *id = astman_get_header(m,"ActionID");
- char idText[256] = "";
+ const char *id = astman_get_header(m, "ActionID");
+ char idText[256];
if (!ast_strlen_zero(id))
snprintf(idText, sizeof(idText), "ActionID: %s\r\n", id);
+ else
+ idText[0] = '\0';
if (all)
c = ast_channel_walk_locked(NULL);
@@ -1661,7 +1665,7 @@
"Event: StatusComplete\r\n"
"%s"
"Items: %d\r\n"
- "\r\n",idText, channels);
+ "\r\n", idText, channels);
return 0;
}
@@ -1997,10 +2001,10 @@
}
}
} else if (!ast_strlen_zero(app)) {
- res = ast_pbx_outgoing_app(tech, AST_FORMAT_SLINEAR, data, to, app, appdata, &reason, 1, l, n, vars, account, NULL);
+ res = ast_pbx_outgoing_app(tech, AST_FORMAT_SLINEAR, data, to, app, appdata, &reason, 1, l, n, vars, account, NULL);
} else {
if (exten && context && pi)
- res = ast_pbx_outgoing_exten(tech, AST_FORMAT_SLINEAR, data, to, context, exten, pi, &reason, 1, l, n, vars, account, NULL);
+ res = ast_pbx_outgoing_exten(tech, AST_FORMAT_SLINEAR, data, to, context, exten, pi, &reason, 1, l, n, vars, account, NULL);
else {
astman_send_error(s, m, "Originate with 'Exten' requires 'Context' and 'Priority'");
return 0;
@@ -2203,10 +2207,12 @@
static int action_coresettings(struct mansession *s, const struct message *m)
{
const char *actionid = astman_get_header(m, "ActionID");
- char idText[150] = "";
+ char idText[150];
if (!ast_strlen_zero(actionid))
snprintf(idText, sizeof(idText), "ActionID: %s\r\n", actionid);
+ else
+ idText[0] = '\0';
astman_append(s, "Response: Success\r\n"
"%s"
@@ -2221,8 +2227,8 @@
"CoreRealTimeEnabled: %s\r\n"
"CoreCDRenabled: %s\r\n"
"CoreHTTPenabled: %s\r\n"
- ,
- idText,
+ "\r\n",
+ idText,
AMI_VERSION,
ast_get_version(),
ast_config_AST_SYSTEM_NAME,
@@ -2254,6 +2260,8 @@
if (!ast_strlen_zero(actionid))
snprintf(idText, sizeof(idText), "ActionID: %s\r\n", actionid);
+ else
+ idText[0] = '\0';
ast_localtime(&ast_startuptime, &tm, NULL);
ast_strftime(startuptime, sizeof(startuptime), "%H:%M:%S", &tm);
@@ -2265,7 +2273,7 @@
"CoreStartupTime: %s\r\n"
"CoreReloadTime: %s\r\n"
"CoreCurrentCalls: %d\r\n"
- "",
+ "\r\n",
idText,
startuptime,
reloadtime,
@@ -2283,15 +2291,11 @@
/*! \brief Send a reload event */
static int action_reload(struct mansession *s, const struct message *m)
{
- const char *actionid = astman_get_header(m, "ActionID");
const char *module = astman_get_header(m, "Module");
int res = ast_module_reload(S_OR(module, NULL));
- char idText[80] = "";
-
- if (!ast_strlen_zero(actionid))
- snprintf(idText, sizeof(idText), "ActionID: %s\r\n", actionid);
+
if (res == 2)
- astman_append(s, "Response: Success\r\n%s", idText);
+ astman_send_ack(s, m, "Module Reloaded");
else
astman_send_error(s, m, s == 0 ? "No such module" : "Module does not support reload");
return 0;
@@ -2308,13 +2312,15 @@
static int action_coreshowchannels(struct mansession *s, const struct message *m)
{
const char *actionid = astman_get_header(m, "ActionID");
- char actionidtext[256] = "";
+ char actionidtext[256];
struct ast_channel *c = NULL;
int numchans = 0;
int duration, durh, durm, durs;
if (!ast_strlen_zero(actionid))
snprintf(actionidtext, sizeof(actionidtext), "ActionID: %s\r\n", actionid);
+ else
+ actionidtext[0] = '\0';
astman_send_listack(s, m, "Channels will follow", "start");
@@ -2353,11 +2359,11 @@
}
astman_append(s,
- "Event: CoreShowChannelsComplete\r\n"
- "EventList: Complete\r\n"
- "ListItems: %d\r\n"
- "%s"
- "\r\n", numchans, actionidtext);
+ "Event: CoreShowChannelsComplete\r\n"
+ "EventList: Complete\r\n"
+ "ListItems: %d\r\n"
+ "%s"
+ "\r\n", numchans, actionidtext);
return 0;
}
@@ -2376,7 +2382,7 @@
{
int res;
const char *module = astman_get_header(m, "Module");
- const char *id = astman_get_header(m,"ActionID");
+ const char *id = astman_get_header(m, "ActionID");
char idText[BUFSIZ];
const char *version;
char filename[BUFSIZ/2];
@@ -2401,6 +2407,8 @@
if (!ast_strlen_zero(id))
snprintf(idText, sizeof(idText), "ActionID: %s\r\n", id);
+ else
+ idText[0] = '\0';
astman_append(s, "Response: Success\r\n%s", idText);
astman_append(s, "Version: %s\r\n\r\n", version ? version : "");
return 0;
@@ -3428,24 +3436,24 @@
struct ast_tls_config ami_tls_cfg;
static struct server_args ami_desc = {
- .accept_fd = -1,
- .master = AST_PTHREADT_NULL,
- .tls_cfg = NULL,
- .poll_timeout = 5000, /* wake up every 5 seconds */
+ .accept_fd = -1,
+ .master = AST_PTHREADT_NULL,
+ .tls_cfg = NULL,
+ .poll_timeout = 5000, /* wake up every 5 seconds */
.periodic_fn = purge_old_stuff,
- .name = "AMI server",
- .accept_fn = server_root, /* thread doing the accept() */
- .worker_fn = session_do, /* thread handling the session */
+ .name = "AMI server",
+ .accept_fn = server_root, /* thread doing the accept() */
+ .worker_fn = session_do, /* thread handling the session */
};
static struct server_args amis_desc = {
- .accept_fd = -1,
- .master = AST_PTHREADT_NULL,
- .tls_cfg = &ami_tls_cfg,
- .poll_timeout = -1, /* the other does the periodic cleanup */
- .name = "AMI TLS server",
- .accept_fn = server_root, /* thread doing the accept() */
- .worker_fn = session_do, /* thread handling the session */
+ .accept_fd = -1,
+ .master = AST_PTHREADT_NULL,
+ .tls_cfg = &ami_tls_cfg,
+ .poll_timeout = -1, /* the other does the periodic cleanup */
+ .name = "AMI TLS server",
+ .accept_fn = server_root, /* thread doing the accept() */
+ .worker_fn = session_do, /* thread handling the session */
};
static int __init_manager(int reload)
More information about the svn-commits
mailing list