[svn-commits] kpfleming: branch 1.4 r46526 - /branches/1.4/main/translate.c

[svn-commits at lists.digium.com]

Author: kpfleming
Date: Mon Oct 30 16:19:55 2006
New Revision: 46526

URL: http://svn.digium.com/view/asterisk?rev=46526&view=rev
Log:
when unregistering a translator, don't rebuild the translation matrix unless needed
when filtering formats out of an offer, ensure we check for translation ability in both directions

Modified:
    branches/1.4/main/translate.c

Modified: branches/1.4/main/translate.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/main/translate.c?rev=46526&r1=46525&r2=46526&view=diff
==============================================================================
--- branches/1.4/main/translate.c (original)
+++ branches/1.4/main/translate.c Mon Oct 30 16:19:55 2006
@@ -729,18 +729,25 @@
 {
 	char tmp[80];
 	struct ast_translator *u;
+	int found = 0;
+
 	AST_LIST_LOCK(&translators);
 	AST_LIST_TRAVERSE_SAFE_BEGIN(&translators, u, list) {
 		if (u == t) {
 			AST_LIST_REMOVE_CURRENT(&translators, list);
 			if (option_verbose > 1)
 				ast_verbose(VERBOSE_PREFIX_2 "Unregistered translator '%s' from format %s to %s\n", term_color(tmp, t->name, COLOR_MAGENTA, COLOR_BLACK, sizeof(tmp)), ast_getformatname(1 << t->srcfmt), ast_getformatname(1 << t->dstfmt));
+			found = 1;
 			break;
 		}
 	}
 	AST_LIST_TRAVERSE_SAFE_END;
-	rebuild_matrix(0);
+
+	if (found)
+		rebuild_matrix(0);
+
 	AST_LIST_UNLOCK(&translators);
+
 	return (u ? 0 : -1);
 }
 
@@ -850,6 +857,11 @@
 		   to this format, remove it from the result */
 		if (!tr_matrix[src_audio][powerof(x)].step)
 			res &= ~x;
+
+		/* now check the opposite direction */
+		if (!tr_matrix[powerof(x)][src_audio].step)
+			res &= ~x;
+
 	}
 
 	/* For a given source video format, traverse the list of
@@ -870,6 +882,10 @@
 		   to this format, remove it from the result */
 		if (!tr_matrix[src_video][powerof(x)].step)
 			res &= ~x;
+
+		/* now check the opposite direction */
+		if (!tr_matrix[powerof(x)][src_video].step)
+			res &= ~x;
 	}
 
 	AST_LIST_UNLOCK(&translators);