[svn-commits] nadi: branch group/trunk-cm-csel-hash r46318 - in
/team/group/trunk-cm-csel-h...
svn-commits at lists.digium.com
svn-commits at lists.digium.com
Thu Oct 26 05:32:21 MST 2006
Author: nadi
Date: Thu Oct 26 07:32:20 2006
New Revision: 46318
URL: http://svn.digium.com/view/asterisk?rev=46318&view=rev
Log:
Merged revisions 45028-45029,45032,45047,45050,45052,45067,45078,45080,45089,45105,45107,45109,45126,45142,45151-45152,45160-45161,45169,45177,45185,45194,45204,45209,45219,45224,45234,45247,45263,45281-45282,45286,45295,45315-45316,45325,45328,45330-45331,45333-45335,45351,45365,45379,45382,45398,45409,45411,45426,45440,45442,45453,45463,45474-45475,45485,45495,45505,45515-45516,45518,45528-45530,45540-45541,45551,45561,45571-45572,45582-45583,45596-45599,45610-45611,45623-45624,45634,45647-45648,45658,45668,45679,45690,45693,45695-45696,45712,45724,45742-45743,45753,45764,45776,45786,45819-45820,45836,45847,45858,45869,45892-45893,45904-45905,45915,45917,45929,45945,45955,45965-45966,45976-45977,45989,46000,46003-46004,46015,46025-46026,46035,46045,46055,46066,46068,46079,46081,46094,46104,46120,46131,46141,46155,46166,46183-46184,46195,46197-46199,46201-46203,46215,46224,46238,46250-46251,46254,46256-46257,46259,46275,46277,46288,46299,46308 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk
................
r45028 | crichter | 2006-10-13 17:42:09 +0200 (Fr, 13 Okt 2006) | 17 lines
Merged revisions 45026 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r45026 | crichter | 2006-10-13 16:45:39 +0200 (Fr, 13 Okt 2006) | 9 lines
Merged revisions 45020 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r45020 | crichter | 2006-10-13 15:11:13 +0200 (Fr, 13 Okt 2006) | 1 line
fixed some echocandisable issues when bridged. this caused a kernel panic sometimes..also some minor formatting fixes
........
................
................
r45029 | kpfleming | 2006-10-13 17:47:42 +0200 (Fr, 13 Okt 2006) | 10 lines
Merged revisions 45027 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45027 | kpfleming | 2006-10-13 10:41:14 -0500 (Fri, 13 Oct 2006) | 2 lines
use a configure script test for PMTU discovery control instead of just assuming it's available on Linux
........
................
r45032 | file | 2006-10-13 17:56:17 +0200 (Fr, 13 Okt 2006) | 18 lines
Merged revisions 45031 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r45031 | file | 2006-10-13 11:53:22 -0400 (Fri, 13 Oct 2006) | 10 lines
Merged revisions 45030 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r45030 | file | 2006-10-13 11:49:53 -0400 (Fri, 13 Oct 2006) | 2 lines
Pass the right value to usleep for sleeping, and always add the background refresh item back into the scheduler if enabled since it is deleted during reload. (issue #8142 reported by p_lindheimer)
........
................
................
r45047 | file | 2006-10-13 18:02:27 +0200 (Fr, 13 Okt 2006) | 10 lines
Merged revisions 45040 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45040 | file | 2006-10-13 12:01:17 -0400 (Fri, 13 Oct 2006) | 2 lines
Complete merging in RPID screen changes (issue #8101 reported by hristo, patch by oej in revision 44757)
........
................
r45050 | kpfleming | 2006-10-13 18:20:26 +0200 (Fr, 13 Okt 2006) | 18 lines
Merged revisions 45049 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r45049 | kpfleming | 2006-10-13 11:19:35 -0500 (Fri, 13 Oct 2006) | 10 lines
Merged revisions 45048 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r45048 | kpfleming | 2006-10-13 11:18:08 -0500 (Fri, 13 Oct 2006) | 2 lines
when sending a call to a peer, use the proper socket if we have multiple bindings (reported on asterisk-dev)
........
................
................
r45052 | file | 2006-10-13 18:22:17 +0200 (Fr, 13 Okt 2006) | 10 lines
Merged revisions 45051 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45051 | file | 2006-10-13 12:20:58 -0400 (Fri, 13 Oct 2006) | 2 lines
Move say.conf existence check to do_say function since it is called from multiple places (issue #8144 reported by kshumard)
........
................
r45067 | file | 2006-10-13 19:06:19 +0200 (Fr, 13 Okt 2006) | 18 lines
Merged revisions 45066 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r45066 | file | 2006-10-13 13:05:02 -0400 (Fri, 13 Oct 2006) | 10 lines
Merged revisions 45060 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r45060 | file | 2006-10-13 13:01:22 -0400 (Fri, 13 Oct 2006) | 2 lines
Turn on volume adjustment if it needs to be on (issue #8136 reported by mnicholson)
........
................
................
r45078 | murf | 2006-10-13 20:08:33 +0200 (Fr, 13 Okt 2006) | 1 line
Correction for bug 8128 in trunk
................
r45080 | file | 2006-10-13 20:45:44 +0200 (Fr, 13 Okt 2006) | 10 lines
Merged revisions 45079 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45079 | file | 2006-10-13 14:42:49 -0400 (Fri, 13 Oct 2006) | 2 lines
And file said... let the compiler warnings STOP!
........
................
r45089 | crichter | 2006-10-13 21:24:02 +0200 (Fr, 13 Okt 2006) | 9 lines
Merged revisions 45088 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45088 | crichter | 2006-10-13 21:19:46 +0200 (Fr, 13 Okt 2006) | 1 line
avoiding warning, fixing potential bug
........
................
r45105 | file | 2006-10-13 23:03:05 +0200 (Fr, 13 Okt 2006) | 10 lines
Merged revisions 45104 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45104 | file | 2006-10-13 17:01:13 -0400 (Fri, 13 Oct 2006) | 2 lines
Check return value from engine in case of failure (ie: out of licenses) (reported on -dev mailing list)
........
................
r45107 | file | 2006-10-13 23:07:06 +0200 (Fr, 13 Okt 2006) | 10 lines
Merged revisions 45106 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45106 | file | 2006-10-13 17:06:09 -0400 (Fri, 13 Oct 2006) | 2 lines
Clear the quiet flag too since we are restarting a recognition again (reported on -dev by Stephan Edelman)
........
................
r45109 | file | 2006-10-13 23:20:18 +0200 (Fr, 13 Okt 2006) | 2 lines
Inherit the context and extension until the channel is answered
................
r45126 | kpfleming | 2006-10-14 01:03:36 +0200 (Sa, 14 Okt 2006) | 15 lines
Merged revisions 45125 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45125 | kpfleming | 2006-10-13 18:02:48 -0500 (Fri, 13 Oct 2006) | 7 lines
------------------------------------------------------------------------
r45119 | kpfleming | 2006-10-13 17:57:42 -0500 (Fri, 13 Oct 2006) | 2 lines
don't drop the entire permit/deny list when an attempt is made to add an invalid entry (BE-92)
------------------------------------------------------------------------
........
................
r45142 | murf | 2006-10-14 06:36:21 +0200 (Sa, 14 Okt 2006) | 1 line
update the doc string for both AEL and extensions.conf users.
................
r45151 | rizzo | 2006-10-15 22:37:42 +0200 (So, 15 Okt 2006) | 3 lines
typo: serer -> server
................
r45152 | rizzo | 2006-10-15 22:54:15 +0200 (So, 15 Okt 2006) | 7 lines
don't forget to close a descriptor on a malloc failure.
On passing, small rearrangement of the code to reduce indentation.
There is a bit more cleanup planned for this file, so a merge to 1.4
will be done when it is all done.
................
r45160 | rizzo | 2006-10-16 08:30:51 +0200 (Mo, 16 Okt 2006) | 3 lines
simplify string parsing routines using ast_skip_*() functions.
................
r45161 | rizzo | 2006-10-16 08:55:14 +0200 (Mo, 16 Okt 2006) | 4 lines
fix indentation of a large block after changes in previous commit
(basically whitespace only).
................
r45169 | rizzo | 2006-10-16 10:38:35 +0200 (Mo, 16 Okt 2006) | 3 lines
comment some functions, and more small code simplifications
................
r45177 | rizzo | 2006-10-16 11:33:00 +0200 (Mo, 16 Okt 2006) | 11 lines
protect access to first_action with actionlock.
Mark with XXX one place (during command execution) where
navigation should be protected with actionlock, but is not
because it would block requests for a long time.
To solve this properly we need to put reference counts in
the struct manager_action.
A suboptimal fix is to copy the record on a search and then
unlock the list while we work on the copy.
................
r45185 | rizzo | 2006-10-16 13:29:22 +0200 (Mo, 16 Okt 2006) | 6 lines
+ comment some unclear requirements for master_eventq
+ remove the need for an snprintf in astman_get_header()
+ fix comment for manager list eventq
+ localize one variable and minor code simplifications.
................
r45194 | oej | 2006-10-16 14:28:18 +0200 (Mo, 16 Okt 2006) | 2 lines
A B2BUA should *not* issue proxy auth.
................
r45204 | oej | 2006-10-16 15:03:02 +0200 (Mo, 16 Okt 2006) | 2 lines
Importing rev 45196 from 1.4 - don't kill dialog for a bad response
................
r45209 | oej | 2006-10-16 15:20:21 +0200 (Mo, 16 Okt 2006) | 6 lines
When adding new functions, please add a forward declaration.
I *know* it is not required, but it makes navigation easier and will help
when splitting up this large source code file.
Thank you!
................
r45219 | rizzo | 2006-10-16 16:00:53 +0200 (Mo, 16 Okt 2006) | 11 lines
+ comment some unclear fields of struct mansession;
+ let some commands (Challenge, Login) be processed even if
already authenticated, as it doesn't harm and prevents some
incorrect error messages
+ remove custom code for Logoff - the existing handler was ok.
Some indentation fixes may be necessary
................
r45224 | oej | 2006-10-16 16:03:48 +0200 (Mo, 16 Okt 2006) | 2 lines
Update
................
r45234 | file | 2006-10-16 18:26:23 +0200 (Mo, 16 Okt 2006) | 2 lines
It's new directed pickup! This now features a more sane way of finding the channel to pick up (I snuck it into the tree on Friday... bet you didn't know I'd actually use it eh?). PICKUPMARK now also works in a different way, you should prefix it with _ when setting it so it gets inherited onto the channel(s) created in app_dial as directed pickup will now look for it on the target channel, not the originating channel. (BE-85)
................
r45247 | file | 2006-10-16 19:25:41 +0200 (Mo, 16 Okt 2006) | 9 lines
Blocked revisions 45246 via svnmerge
........
r45246 | file | 2006-10-16 13:24:35 -0400 (Mon, 16 Oct 2006) | 2 lines
Backport of new directed pickup (BE-85).
........
................
r45263 | file | 2006-10-16 21:43:33 +0200 (Mo, 16 Okt 2006) | 18 lines
Merged revisions 45262 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r45262 | file | 2006-10-16 15:37:34 -0400 (Mon, 16 Oct 2006) | 10 lines
Merged revisions 45260 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r45260 | file | 2006-10-16 15:28:18 -0400 (Mon, 16 Oct 2006) | 2 lines
Add 'ignoreoodreplies' option which will not create a pvt structure on a SIP response but instead basically drop it.
........
................
................
r45281 | file | 2006-10-16 22:08:23 +0200 (Mo, 16 Okt 2006) | 18 lines
Merged revisions 45280 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r45280 | file | 2006-10-16 16:06:18 -0400 (Mon, 16 Oct 2006) | 10 lines
Merged revisions 45265 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r45265 | file | 2006-10-16 15:59:54 -0400 (Mon, 16 Oct 2006) | 2 lines
Use responses rather then replies even though they mean the same thing.
........
................
................
r45282 | file | 2006-10-16 22:10:05 +0200 (Mo, 16 Okt 2006) | 2 lines
Woof.
................
r45286 | file | 2006-10-16 22:26:56 +0200 (Mo, 16 Okt 2006) | 2 lines
In the course of a data this has been turned into an option to ignore replies, then ignore responses and finally I'm just getting rid of the option altogether and making it the default no matter what. C'est la vie!
................
r45295 | oej | 2006-10-17 08:47:02 +0200 (Di, 17 Okt 2006) | 3 lines
Get rid of the ignore variable that was only partially replaced
by the flag.
................
r45315 | oej | 2006-10-17 18:25:03 +0200 (Di, 17 Okt 2006) | 2 lines
Block patch from 1.4 that does not apply here.
................
r45316 | oej | 2006-10-17 18:27:01 +0200 (Di, 17 Okt 2006) | 2 lines
...block this one too... Only applies to 1.4 since the fix for trunk was different.
................
r45325 | rizzo | 2006-10-17 19:19:31 +0200 (Di, 17 Okt 2006) | 5 lines
document xml_copy_escape() and add an extra function, namely
replace non-alphanum chars with underscore.
This is useful when building field names in xml formatting.
................
r45328 | kpfleming | 2006-10-17 19:22:52 +0200 (Di, 17 Okt 2006) | 18 lines
Merged revisions 45327 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r45327 | kpfleming | 2006-10-17 12:22:25 -0500 (Tue, 17 Oct 2006) | 10 lines
Merged revisions 45326 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r45326 | kpfleming | 2006-10-17 12:22:01 -0500 (Tue, 17 Oct 2006) | 2 lines
provide licensing language for IAXy firmware file
........
................
................
r45330 | rizzo | 2006-10-17 19:41:59 +0200 (Di, 17 Okt 2006) | 7 lines
open a temporary file to receive the output from cli commands
invoked through the http interface.
It is not terribly efficient but better than no output at all.
Todo: use a configurable /tmp directory instead of a hardwired one.
................
r45331 | oej | 2006-10-17 19:47:09 +0200 (Di, 17 Okt 2006) | 4 lines
- Remove unneeded code that won't be reached now that we kill responses
to unkonwn dialogs earlier in the process.
- move debug message.
................
r45333 | oej | 2006-10-17 19:51:34 +0200 (Di, 17 Okt 2006) | 2 lines
Update of docs
................
r45334 | rizzo | 2006-10-17 19:51:34 +0200 (Di, 17 Okt 2006) | 21 lines
Improve the XML formatting of responses coming from web interface.
Normal responses are sequences of lines of the form "Name: value",
with \r\n as line terminators and an empty line as a response
terminator.
Generi CLI commands, however, do not have such a clean formatting,
and the existing code failed to generate valid XML for them.
Obviously we can only use heuristics here, and we do the following:
- accept either \r or \n as a line terminator, trimming trailing whitespace;
- if a line does not have a ":" in it, assume that from this point on
we have unformatted data, and use "Opaque-data:" as a name;
- if a line does have a ":" in it, the Name field is not always
a legal identifier, so replace non-alphanum characters with underscores;
All the above is to be refined as we improve the formatting of
responses from the CLI.
And, all the above ought to go as a comment in the code rather than
just in a commit message...
................
r45335 | oej | 2006-10-17 19:54:59 +0200 (Di, 17 Okt 2006) | 3 lines
Issue #7254 - Add support of "423 Interval too brief" to outbound SIP registrations.
Thanks, tardieu!
................
r45351 | rizzo | 2006-10-17 20:08:51 +0200 (Di, 17 Okt 2006) | 3 lines
simplify authority_to_str() using ast_build_string()
................
r45365 | oej | 2006-10-17 21:57:35 +0200 (Di, 17 Okt 2006) | 3 lines
Issue #5484 (branch sipdiversion) - Support for Diversion header in redirects of calls
with 302 redirection. (tinning)
................
r45379 | file | 2006-10-17 22:34:22 +0200 (Di, 17 Okt 2006) | 10 lines
Merged revisions 45378 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45378 | file | 2006-10-17 16:30:34 -0400 (Tue, 17 Oct 2006) | 2 lines
Don't create a "real" pvt structure for requests that shouldn't be able to create one. Instead use a temporary pvt and fill it with enough information so we can send a reply.
........
................
r45382 | file | 2006-10-17 22:38:55 +0200 (Di, 17 Okt 2006) | 16 lines
Blocked revisions 45381 via svnmerge
................
r45381 | file | 2006-10-17 16:38:15 -0400 (Tue, 17 Oct 2006) | 9 lines
Blocked revisions 45380 via svnmerge
........
r45380 | file | 2006-10-17 16:37:17 -0400 (Tue, 17 Oct 2006) | 2 lines
Don't create a "real" pvt structure for requests that shouldn't be able to create one. Instead use a temporary pvt and fill it with enough information so we can send a reply.
........
................
................
r45398 | file | 2006-10-17 23:09:49 +0200 (Di, 17 Okt 2006) | 2 lines
Warning be gone!
................
r45409 | kpfleming | 2006-10-18 00:24:45 +0200 (Mi, 18 Okt 2006) | 11 lines
Merged revisions 45408 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45408 | kpfleming | 2006-10-17 17:24:10 -0500 (Tue, 17 Oct 2006) | 3 lines
optimize the 'quick response' code a bit more... no more malloc() or memset() for each response
expand stringfields API a bit to allow reusing the stringfield pool on a structure when needed, and remove some unnecessary code when the structure was being freed
........
................
r45411 | kpfleming | 2006-10-18 00:32:19 +0200 (Mi, 18 Okt 2006) | 10 lines
Merged revisions 45410 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45410 | kpfleming | 2006-10-17 17:31:54 -0500 (Tue, 17 Oct 2006) | 2 lines
add a project-specific script to be used during release preparation
........
................
r45426 | murf | 2006-10-18 01:06:13 +0200 (Mi, 18 Okt 2006) | 1 line
As per bug 6779, this patch is now applied to trunk; while I was at it, I corrected a reference to a CLI command, to follow the new regime.
................
r45440 | russell | 2006-10-18 04:19:55 +0200 (Mi, 18 Okt 2006) | 10 lines
Merged revisions 45439 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45439 | russell | 2006-10-17 22:19:07 -0400 (Tue, 17 Oct 2006) | 2 lines
update entry to reboot a snom phone (issue #7850, pnlarsson)
........
................
r45442 | russell | 2006-10-18 04:46:39 +0200 (Mi, 18 Okt 2006) | 15 lines
Merged revisions 45441 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45441 | russell | 2006-10-17 22:41:36 -0400 (Tue, 17 Oct 2006) | 7 lines
Don't attempt to access private data members of the pthread_mutex_t object,
because this does not work on all linux systems. Instead, just access
the reentrancy field in the ast_mutex_info struct when DEBUG_THREADS is
enabled. If DEBUG_CHANNEL_LOCKS is enabled, the developer probably has
DEBUG_THREADS on as well.
(issue #8139, me)
........
................
r45453 | file | 2006-10-18 05:03:37 +0200 (Mi, 18 Okt 2006) | 10 lines
Merged revisions 45452 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45452 | file | 2006-10-17 23:02:08 -0400 (Tue, 17 Oct 2006) | 2 lines
Don't segfault if you're using a channel driver that doesn't turn RTCP on
........
................
r45463 | rizzo | 2006-10-18 06:05:56 +0200 (Mi, 18 Okt 2006) | 9 lines
various code simplifications to reduce nesting depth,
minor optimizations to avoid extra calls of strlen(),
and some variable localization.
One feature worth backporting is the move of ast_variables_destroy()
to a different place in handle_uri() to avoid leaking memory
in case a uri is not found.
................
r45474 | rizzo | 2006-10-18 07:27:22 +0200 (Mi, 18 Okt 2006) | 4 lines
introduce uri_decode() so that '+' are translated into ' '
(e.g. browsers do this when they encode input strings from a form).
................
r45475 | rizzo | 2006-10-18 07:31:54 +0200 (Mi, 18 Okt 2006) | 13 lines
merge xml_translate() and html_translate() into one function since
they do similar things.
Add a small form on top of the html output so request like
http://foo:8088/asterisk/manager will suggest you what to do.
Note: i suspect there is still a bug somewhere in the session matching
code, as sometimes you have to login twice in order for the following
commands to be recognised.
Apart from this, the cli now is basically usable from a web form!
................
r45485 | rizzo | 2006-10-18 08:28:34 +0200 (Mi, 18 Okt 2006) | 9 lines
+ move the enum declaration for output formats near the head
of the file, so it can be used from more places;
+ make the declaration of contenttype[] more robust;
+ remove the wrappers around __xml_translate(), since they were
used only in one place, and rename to xml_translate().
This allows for a bit of simplifications.
+ document the output produced by the above function.
................
r45495 | rizzo | 2006-10-18 10:48:50 +0200 (Mi, 18 Okt 2006) | 4 lines
add a comment to remember that a block of code is
completely redundant.
................
r45505 | rizzo | 2006-10-18 12:14:58 +0200 (Mi, 18 Okt 2006) | 3 lines
simplify ast_strings_to_mask
................
r45515 | rizzo | 2006-10-18 13:43:31 +0200 (Mi, 18 Okt 2006) | 3 lines
more code simplifications
................
r45516 | rizzo | 2006-10-18 13:54:06 +0200 (Mi, 18 Okt 2006) | 3 lines
first pass as simplifying authenticate(), avoiding whitespace changes
................
r45518 | rizzo | 2006-10-18 13:59:08 +0200 (Mi, 18 Okt 2006) | 3 lines
remove unused fields and unimplemented options.
................
r45528 | oej | 2006-10-18 14:15:23 +0200 (Mi, 18 Okt 2006) | 2 lines
Remove duplicate declarations...
................
r45529 | rizzo | 2006-10-18 14:38:24 +0200 (Mi, 18 Okt 2006) | 6 lines
another batch of simplifications to authenticate()
(they are committed a bit at a time so it is easier to
revert them in case we find a bug at a later time).
................
r45530 | rizzo | 2006-10-18 14:55:12 +0200 (Mi, 18 Okt 2006) | 3 lines
fix indentation from a commit of a couple of days ago
................
r45540 | rizzo | 2006-10-18 15:23:22 +0200 (Mi, 18 Okt 2006) | 6 lines
create proper handlers for "Challenge" and "Login" actions,
rather than use inline code for them.
Things are more readable this way, and also error processing
is more consistent.
................
r45541 | rizzo | 2006-10-18 15:42:14 +0200 (Mi, 18 Okt 2006) | 5 lines
more indentation cleanup from previous commits,
and remove the "busy" field from struct mansession
as it was not used correctly anyways.
................
r45551 | rizzo | 2006-10-18 16:21:15 +0200 (Mi, 18 Okt 2006) | 15 lines
create a new (internal, for the time being) function astman_start_ack()
to start manager responses that need further lines.
This removes a lot of duplicate code from the various handlers
that at the moment build an ActionID string themselves.
Once settled, the function should move to manager.h so
it can be used by other files (chan_agent, chan_iax2, chan_sip,
chan_zap, res_jabber and app_queue).
I am not totally clear if there is a preferred position for
the ActionID: line in a message. Some instances put it at
the end, but one would argue that it is preferable to have
it at the beginning.
................
r45561 | rizzo | 2006-10-18 17:49:40 +0200 (Mi, 18 Okt 2006) | 6 lines
comment and cleanup the main thread.
On passing, fix a bug: close the socket if the allocation
of a structure for the new session fails.
(the bugfix is a candidate for 1.4)
................
r45571 | mogorman | 2006-10-18 18:45:22 +0200 (Mi, 18 Okt 2006) | 2 lines
rizzo compile then commit, maybe even run it too ^_^
................
r45572 | rizzo | 2006-10-18 18:52:13 +0200 (Mi, 18 Okt 2006) | 4 lines
more comment and formatting fixes, small simplifications
to functions get_input() and session_do()
................
r45582 | rizzo | 2006-10-18 19:45:50 +0200 (Mi, 18 Okt 2006) | 16 lines
despite the large changes, this commit only moves functions
around so that functions belonging to the same group are
close to each other.
At the beginning of each group i have added a bit of documentation
to explain what the group does and what is the typical flow - basically,
all i have learned by code inspection over the past few days should
be documented for you to read.
I have not put many doxygen annotations just because i am not
sure what are the proper ones. Hopefully some doxygen experts will jump in.
Next on the plate: try to figure out how "struct eventqent"
are supposed to work.
................
r45583 | rizzo | 2006-10-18 19:53:47 +0200 (Mi, 18 Okt 2006) | 3 lines
another bunch of comments on the data structures.
................
r45596 | file | 2006-10-18 23:05:52 +0200 (Mi, 18 Okt 2006) | 10 lines
Merged revisions 45595 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45595 | file | 2006-10-18 17:03:34 -0400 (Wed, 18 Oct 2006) | 2 lines
Don't modify things if we are using vfork as this is very bad and may cause unexpected behavior (issue #7970 reported by Nick Gavrikov)
........
................
r45597 | rizzo | 2006-10-18 23:30:21 +0200 (Mi, 18 Okt 2006) | 6 lines
+ move output_format variables in the http section of the file;
+ more comments on struct mansession and global variables;
+ small improvements to the session matching code so it supports
multiple sessions from the same IP
................
r45598 | rizzo | 2006-10-18 23:36:20 +0200 (Mi, 18 Okt 2006) | 3 lines
ouch! remember to unlink temporary files once done with them.
................
r45599 | rizzo | 2006-10-18 23:41:09 +0200 (Mi, 18 Okt 2006) | 3 lines
remove trailing whitespace
................
r45610 | file | 2006-10-19 00:19:57 +0200 (Do, 19 Okt 2006) | 2 lines
Just for Nicholson - here's an option, C, to Meetme that will allow it to continue in the dialplan if the person is kicked out. (issue #7994 reported by mnicholson with mods by myself)
................
r45611 | rizzo | 2006-10-19 00:40:02 +0200 (Do, 19 Okt 2006) | 4 lines
silent warning from a debugging message (which will go away
soon, anyways)
................
r45623 | russell | 2006-10-19 03:00:57 +0200 (Do, 19 Okt 2006) | 9 lines
Extend the thread storage API such that a custom initialization function can
be called for each thread specific object after they are allocated. Note that
there was already the ability to define a custom cleanup function. Also, if
the custom cleanup function is used, it *MUST* call free on the thread
specific object at the end. There is no way to have this magically done that
I can think of because the cleanup function registered with the pthread
implementation will only call the function back with a pointer to the
thread specific object, not the parent ast_threadstorage object.
................
r45624 | russell | 2006-10-19 03:04:18 +0200 (Do, 19 Okt 2006) | 14 lines
Merge fix to not leak the stringfields of a thread speicif sip_pvt. This also
includes the fix not to leak the actual sip_pvt.
Merged revisions 45622 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45622 | russell | 2006-10-18 20:59:51 -0400 (Wed, 18 Oct 2006) | 2 lines
Don't leak the actual thread-specific sip_pvt struct
........
................
r45634 | kpfleming | 2006-10-19 04:16:34 +0200 (Do, 19 Okt 2006) | 4 lines
restore freeing of threadstorage objects without custom cleanup functions
allow custom threadstorage init functions to return failure
use a custom init function for chan_sip's temp_pvt, to improve performance a bit
................
r45647 | oej | 2006-10-19 09:17:13 +0200 (Do, 19 Okt 2006) | 2 lines
Cleaning up... Removing duplicate (again)
................
r45648 | rizzo | 2006-10-19 09:43:43 +0200 (Do, 19 Okt 2006) | 12 lines
more documentation of data structure and functions.
Of interest:
+ ast_get_manager_by_name_locked() is now without the ast_
prefix as it is a local function;
+ unuse_eventqent() renamed to unref_event(), and returns
the pointer to the next entry.
+ marked with XXX a couple of usages of unref_event()
because i suspect we are addressing the wrong entry.
................
r45658 | rizzo | 2006-10-19 11:54:51 +0200 (Do, 19 Okt 2006) | 6 lines
+ move the definition of netlock as it was not related to the
comment just above;
+ decouple the struct definition and variable declaration (iflist);
................
r45668 | rizzo | 2006-10-19 12:05:02 +0200 (Do, 19 Okt 2006) | 4 lines
move a large block out of do_monitor() and into a function,
to improve readability.
................
r45679 | file | 2006-10-19 18:06:14 +0200 (Do, 19 Okt 2006) | 10 lines
Merged revisions 45678 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45678 | file | 2006-10-19 12:03:09 -0400 (Thu, 19 Oct 2006) | 2 lines
If the jitterbuffer is forced on then we can't partially bridge (reported by wangster on #asterisk-dev)
........
................
r45690 | rizzo | 2006-10-19 19:07:08 +0200 (Do, 19 Okt 2006) | 6 lines
implement proper XML/HTML formatting of multiple messages
(e.g. the result of waitevent).
Also fix some comments.
................
r45693 | file | 2006-10-19 19:22:13 +0200 (Do, 19 Okt 2006) | 18 lines
Merged revisions 45692 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r45692 | file | 2006-10-19 13:19:47 -0400 (Thu, 19 Oct 2006) | 10 lines
Merged revisions 45691 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r45691 | file | 2006-10-19 13:16:37 -0400 (Thu, 19 Oct 2006) | 2 lines
Respect language selection when seeing if the file exists (issue #8178 reported by mnicholson)
........
................
................
r45695 | file | 2006-10-19 19:25:43 +0200 (Do, 19 Okt 2006) | 10 lines
Merged revisions 45694 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45694 | file | 2006-10-19 13:24:40 -0400 (Thu, 19 Oct 2006) | 2 lines
Let's remember to unregister JabberStatus too (issue #8184 reported by jmls)
........
................
r45696 | rizzo | 2006-10-19 19:26:20 +0200 (Do, 19 Okt 2006) | 3 lines
more fixes to comments and very minor code rearrangement.
................
r45712 | murf | 2006-10-19 21:32:25 +0200 (Do, 19 Okt 2006) | 1 line
astman was slightly weirding out over the new Dial and Newcallerid events
................
r45724 | murf | 2006-10-20 00:06:27 +0200 (Fr, 20 Okt 2006) | 1 line
This new function, VERSION(), created via bug report 8176, may help dialplan programmers in the future. In the meantime, they can use the algorithm I outline on the bug report notes; If anyone invents something better, I'd hope they post it
................
r45742 | oej | 2006-10-20 10:00:13 +0200 (Fr, 20 Okt 2006) | 2 lines
Doxygen corrections
................
r45743 | oej | 2006-10-20 10:14:14 +0200 (Fr, 20 Okt 2006) | 2 lines
Let's repair the SIP attack shield :-)
................
r45753 | rizzo | 2006-10-20 13:24:43 +0200 (Fr, 20 Okt 2006) | 17 lines
minor comment changes, code rearrangement and field renaming
to minimize diffs with future modifications.
The current implementation is problematic for the following reasons:
+ all insertions are O(N) because the event list does not have a tail
pointer;
+ there is only a single lock protecting both session and users queues.
+ the implementation of the queue itself is not documented.
I think i have figured it out, more or less, but am unclear on
whether there is proper locking in place
The rewrite (which i have working locally) uses a tailq so insertions
are O(1), separate locks for the event and session queues, and has
a documented implementation so hopefully we can figure out if/where
bug exist.
................
r45764 | russell | 2006-10-20 17:54:14 +0200 (Fr, 20 Okt 2006) | 2 lines
put the constants for whether methods can create a dialog or not in an enum
................
r45776 | file | 2006-10-20 21:04:23 +0200 (Fr, 20 Okt 2006) | 10 lines
Merged revisions 45775 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45775 | file | 2006-10-20 15:03:03 -0400 (Fri, 20 Oct 2006) | 2 lines
Pass DESTDIR and ASTSBINDIR so that the utilities get installed in the proper location (reported on asterisk-dev mailing list)
........
................
r45786 | rizzo | 2006-10-20 22:59:06 +0200 (Fr, 20 Okt 2006) | 12 lines
introduce sip_pvt_lock() and sip_pvt_unlock() wrappers to
lock these data structures.
This improve readability, and also hides the underlying
locking mechanism so it is a lot easier to add diagnostic
code, or move the object locks somewhere else, etc.
On passing, rename the lock field in sip_pvt to pvt_lock,
also for ease of readability.
................
r45819 | russell | 2006-10-21 20:50:38 +0200 (Sa, 21 Okt 2006) | 11 lines
Merged revisions 45818 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45818 | russell | 2006-10-21 14:49:46 -0400 (Sat, 21 Oct 2006) | 3 lines
Add a couple missing unregistrations of manager actions and remove duplicate
unregistrations of applications. (issue #8194, jmls)
........
................
r45820 | file | 2006-10-21 20:52:33 +0200 (Sa, 21 Okt 2006) | 10 lines
Merged revisions 45817 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r45817 | file | 2006-10-21 14:48:58 -0400 (Sat, 21 Oct 2006) | 2 lines
Don't use promotion on Darwin because it doesn't seem to work quite right in all cases, this should solve the unresolved symbol issue people have been seeing.
........
................
r45836 | rizzo | 2006-10-21 22:24:04 +0200 (Sa, 21 Okt 2006) | 6 lines
the default port number was erroneously stored in host order,
and reading from the config file used ntohs instead of htons.
this ought to be merged to 1.4 as well.
................
r45847 | file | 2006-10-22 06:44:43 +0200 (So, 22 Okt 2006) | 2 lines
Let's have build.h created a bit earlier so that func_version can use it and not stop the build on a fresh machine that has never had Asterisk installed on it before...
................
r45858 | rizzo | 2006-10-22 10:28:16 +0200 (So, 22 Okt 2006) | 11 lines
it is useless and possibly wrong to use ast_cli() to send the
reply back to http clients.
Use fprintf/fwrite instead, since we are already using a FILE *
to read the input.
If you wonder why, this is because it makes it trivial to
implement https support (as long as your system has funopen()).
And this is what i am going to put in with the next few commits...
................
r45869 | rizzo | 2006-10-22 14:02:35 +0200 (So, 22 Okt 2006) | 47 lines
Implement https support.
The changes are not large. Most of the diff comes from putting the
global variables describing an accept session into a structure, so
we can reuse the existing code for running multiple accept threads
on different ports.
Once this is done, and if your system has the funopen() library
function (and ssl, of course), it is just a matter of calling
the appropriate functions to set up the ssl connection on the
existing socket, and everything works on the secure channel now.
At the moment, the code is disabled because i have not implemented yet
the autoconf code to detect the presence of funopen(), and add -lssl
to main/Makefile if ssl libraries are present. And a bit of documentation
on the http.conf arguments, too.
If you want to manually enable https support, that is very simple
(step 0 1 2 will be eventually detected by ./configure, the
rest is something you will have to do anyways).
0. make sure your system has funopen(3). FreeBSD does, linux probably
does too, not sure about other systems.
1. uncomment the following line in main/http.c
// #define DO_SSL /* comment in/out if you want to support ssl */
2. add -lssl to AST_LIBS in main/Makefile
3. add the following options to http.conf
sslenable=yes
sslbindport=4433 ; pick one you like
sslcert=/tmp/foo.pem ; path to your certificate file.
4. generate a suitable certificate e.g. (example from mini_httpd's Makefile:
openssl req -new -x509 -days 365 -nodes -out /tmp/foo.pem -keyout /tmp/foo.pem
and here you go:
https://localhost:4433/asterisk/manager
now works.
................
r45892 | rizzo | 2006-10-22 21:09:25 +0200 (So, 22 Okt 2006) | 16 lines
Fix a few issues in the previous (disabled) HTTPS code,
and support linux as well (using fopencookie(), which should
be available in glibc).
Update configure.ac to check for funopen (BSD) and fopencookie(glibc),
and while we are at it also for gethostbyname_r
(the generated files need to be updated, or you need
to run bootstrap.sh yourself).
Document the new options in http.conf.sample
(names are only tentative, better ones are welcome).
At this point we can safely enable the option.
Anyone willing to try this on Sun and Apple platforms ?
................
r45893 | russell | 2006-10-22 21:34:30 +0200 (So, 22 Okt 2006) | 3 lines
regenerate the configure script and autoconfig.h.in to reflect recent changes
for https support for the built in http server
................
r45904 | rizzo | 2006-10-22 22:51:05 +0200 (So, 22 Okt 2006) | 3 lines
put duplicated code in functions.
................
r45905 | rizzo | 2006-10-22 22:59:38 +0200 (So, 22 Okt 2006) | 6 lines
simplify the flow of function check_user_full()
A large block needs reindentation now, but we don't do that because
it can be moved to a separate function.
................
r45915 | rizzo | 2006-10-22 23:08:07 +0200 (So, 22 Okt 2006) | 3 lines
more streamlining of check_user_full
................
r45917 | crichter | 2006-10-22 23:57:11 +0200 (So, 22 Okt 2006) | 17 lines
Merged revisions 45916 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r45916 | crichter | 2006-10-22 23:44:46 +0200 (Sun, 22 Oct 2006) | 9 lines
Merged revisions 45808 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r45808 | crichter | 2006-10-21 14:35:13 +0200 (Sat, 21 Oct 2006) | 1 line
fixed issue, that if chan_misdn is loaded and couldn't be initialized it would cause a segfault after 'reload'. Reported by Drew/Matt thx.
........
................
................
r45929 | file | 2006-10-23 02:33:20 +0200 (Mo, 23 Okt 2006) | 18 lines
Merged revisions 45928 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r45928 | file | 2006-10-22 20:27:39 -0400 (Sun, 22 Oct 2006) | 10 lines
Merged revisions 45927 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r45927 | file | 2006-10-22 20:25:28 -0400 (Sun, 22 Oct 2006) | 2 lines
Don't leak memory mmmk?
........
................
................
r45945 | rizzo | 2006-10-23 13:08:47 +0200 (Mo, 23 Okt 2006) | 31 lines
More cleanup of check_user_full with no functional change
apart from a small (but disabled by default) new option.
In detail:
+ introduce a new value for enum check_auth_result, AUTH_DONT_KNOW,
used (read below) when a function does not have a conclusive response.
Possibly this is the same as AUTH_NOT_FOUND, but need to check further.
+ move the large blocks (checking in the users list and in the peers
list, respectively) from check_user_full() to separate functions.
They return AUTH_DONT_KNOW in case they don't find a match, so
the caller know that it has to try the next method.
There is still some duplication of code here, but i
have not tried yet to remove it.
+ [new option] a new option in sip.conf, match_auth_username,
has been introduced, and disabled by default.
If set, and the incoming request carries authentication info,
the username to match in the users list is taken from there
rather than from the From: field.
[... 14182 lines stripped ...]
More information about the svn-commits
mailing list