[svn-commits] oej: branch 1.4 r47250 - in /branches/1.4: ./ channels/chan_sip.c

[svn-commits at lists.digium.com]

Author: oej
Date: Tue Nov  7 07:13:51 2006
New Revision: 47250

URL: http://svn.digium.com/view/asterisk?rev=47250&view=rev
Log:
Fixing the attack shield so it doesn't produce attacks... Issue 8265 - never reply to an ACK

Modified:
    branches/1.4/   (props changed)
    branches/1.4/channels/chan_sip.c

Propchange: branches/1.4/
------------------------------------------------------------------------------
Binary property 'branch-1.2-merged' - no diff available.

Modified: branches/1.4/channels/chan_sip.c
URL: http://svn.digium.com/view/asterisk/branches/1.4/channels/chan_sip.c?rev=47250&r1=47249&r2=47250&view=diff
==============================================================================
--- branches/1.4/channels/chan_sip.c (original)
+++ branches/1.4/channels/chan_sip.c Tue Nov  7 07:13:51 2006
@@ -4310,8 +4310,10 @@
 	} else if( sip_methods[intended_method].can_create == CAN_CREATE_DIALOG_UNSUPPORTED_METHOD) {
 		/* A method we do not support, let's take it on the volley */
 		transmit_response_using_temp(callid, sin, 1, intended_method, req, "501 Method Not Implemented");
-	} else if (intended_method != SIP_RESPONSE) {
-		/* This is a request outside of a dialog that we don't know about */
+	} else if (intended_method != SIP_RESPONSE && intended_method != SIP_ACK) {
+		/* This is a request outside of a dialog that we don't know about 
+			...never reply to an ACK!
+		*/
 		transmit_response_using_temp(callid, sin, 1, intended_method, req, "481 Call leg/transaction does not exist");
 	}
 	/* We do not respond to responses for dialogs that we don't know about, we just drop