[Asterisk-cvs] asterisk/doc CODING-GUIDELINES,1.1,1.2
markster at lists.digium.com
markster at lists.digium.com
Sat May 15 11:23:11 CDT 2004
Update of /usr/cvsroot/asterisk/doc
In directory mongoose.digium.com:/tmp/cvs-serv17639/doc
Modified Files:
CODING-GUIDELINES
Log Message:
Update coding guidelines, fix "say.c" compile on older compilers, update coding guidelines (includes bug #1631)
Index: CODING-GUIDELINES
===================================================================
RCS file: /usr/cvsroot/asterisk/doc/CODING-GUIDELINES,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- CODING-GUIDELINES 2 May 2004 19:24:05 -0000 1.1
+++ CODING-GUIDELINES 15 May 2004 15:34:31 -0000 1.2
@@ -6,6 +6,11 @@
Patches should be in the form of a unified (-u) diff.
+All code, filenames, function names and comments must be in ENGLISH.
+
+Do not declare variables mid-function (e.g. like GNU lets you) since it is
+harder to read and not portable to GCC 2.95 and others.
+
Don't annotate your changes with comments like "/* JMG 4/20/04 */";
Comments should explain what the code does, not when something was changed
or who changed it.
More information about the svn-commits
mailing list