[dahdi-commits] sruffell: linux/trunk r10047 - /linux/trunk/drivers/dahdi/wcte12xp/base.c

[SVN commits to the DAHDI project]

Author: sruffell
Date: Mon Jul 18 18:32:21 2011
New Revision: 10047

URL: http://svnview.digium.com/svn/dahdi?view=rev&rev=10047
Log:
wcte12xp: Close a potential race on driver unload.

The shutdown logic requires that all CPUs see that the INITIALIZED bit
has been cleared. Otherwise it may be possible for the workqueue to run
after the hardware resources have been released.

Signed-off-by: Shaun Ruffell <sruffell at digium.com>
Acked-by: Russ Meyerriecks <rmeyerriecks at digium.com>

Modified:
    linux/trunk/drivers/dahdi/wcte12xp/base.c

Modified: linux/trunk/drivers/dahdi/wcte12xp/base.c
URL: http://svnview.digium.com/svn/dahdi/linux/trunk/drivers/dahdi/wcte12xp/base.c?view=diff&rev=10047&r1=10046&r2=10047
==============================================================================
--- linux/trunk/drivers/dahdi/wcte12xp/base.c (original)
+++ linux/trunk/drivers/dahdi/wcte12xp/base.c Mon Jul 18 18:32:21 2011
@@ -2686,6 +2686,7 @@
 	remove_sysfs_files(wc);
 
 	clear_bit(INITIALIZED, &wc->bit_flags);
+	smp_mb__after_clear_bit();
 
 	del_timer_sync(&wc->timer);
 	flush_workqueue(wc->wq);