[dahdi-commits] tzafrir: linux/trunk r10383 - /linux/trunk/drivers/dahdi/xpp/xbus-core.c

SVN commits to the DAHDI project dahdi-commits at lists.digium.com
Wed Dec 21 12:10:19 CST 2011


Author: tzafrir
Date: Wed Dec 21 12:10:15 2011
New Revision: 10383

URL: http://svnview.digium.com/svn/dahdi?view=rev&rev=10383
Log:
xpp: bad module_put() when too many Astribanks

module_put() that was added while developing the sysfs code. The real
module_get()/module_put() pair were already removed at the time of
developing code for this branch. It was only triggered when using a
system with more than 32 (MAX_BUSES) Astribanks.

Signed-off-by: Oron Peled <oron.peled at xorcom.com>
Acked-By: Tzafrir Cohen <tzafrir.cohen at xorcom.com>

Modified:
    linux/trunk/drivers/dahdi/xpp/xbus-core.c

Modified: linux/trunk/drivers/dahdi/xpp/xbus-core.c
URL: http://svnview.digium.com/svn/dahdi/linux/trunk/drivers/dahdi/xpp/xbus-core.c?view=diff&rev=10383&r1=10382&r2=10383
==============================================================================
--- linux/trunk/drivers/dahdi/xpp/xbus-core.c (original)
+++ linux/trunk/drivers/dahdi/xpp/xbus-core.c Wed Dec 21 12:10:15 2011
@@ -1413,7 +1413,6 @@
 	xbus = xbus_alloc();
 	if(!xbus) {
 		ERR("%s: Failed allocating new xbus\n", __FUNCTION__);
-		module_put(THIS_MODULE);
 		return NULL;
 	}
 	snprintf(xbus->busname, XBUS_NAMELEN, "XBUS-%02d", xbus->num);




More information about the dahdi-commits mailing list