[dahdi-commits] sruffell: linux/trunk r9360 - /linux/trunk/drivers/dahdi/dahdi-base.c

SVN commits to the DAHDI project dahdi-commits at lists.digium.com
Mon Sep 20 15:33:03 CDT 2010


Author: sruffell
Date: Mon Sep 20 15:32:59 2010
New Revision: 9360

URL: http://svnview.digium.com/svn/dahdi?view=rev&rev=9360
Log:
dahdi: Remove unused parameter in three ioctl handlers.

The 'int cmd' parameter is unused and unneeded in dahdi_ioctl_getgains,
dahdi_ioctl_setgains, and dahdi_ioctl_chandiag.

Review: https://reviewboard.asterisk.org/r/905/

Signed-off-by: Shaun Ruffell <sruffell at digium.com>

Modified:
    linux/trunk/drivers/dahdi/dahdi-base.c

Modified: linux/trunk/drivers/dahdi/dahdi-base.c
URL: http://svnview.digium.com/svn/dahdi/linux/trunk/drivers/dahdi/dahdi-base.c?view=diff&rev=9360&r1=9359&r2=9360
==============================================================================
--- linux/trunk/drivers/dahdi/dahdi-base.c (original)
+++ linux/trunk/drivers/dahdi/dahdi-base.c Mon Sep 20 15:32:59 2010
@@ -3642,8 +3642,7 @@
 	return 0;
 }
 
-static int dahdi_ioctl_getgains(struct file *file,
-				unsigned int cmd, unsigned long data, int unit)
+static int dahdi_ioctl_getgains(struct file *file, unsigned long data, int unit)
 {
 	int res = 0;
 	struct dahdi_gains *gain;
@@ -3688,8 +3687,7 @@
 	return res;
 }
 
-static int dahdi_ioctl_setgains(struct file *file,
-				unsigned int cmd, unsigned long data, int unit)
+static int dahdi_ioctl_setgains(struct file *file, unsigned long data, int unit)
 {
 	int res = 0;
 	struct dahdi_gains *gain;
@@ -3766,7 +3764,7 @@
 	return res;
 }
 
-static int dahdi_ioctl_chandiag(struct file *file, int cmd, unsigned long data)
+static int dahdi_ioctl_chandiag(struct file *file, unsigned long data)
 {
 	unsigned long flags;
 	int channo;
@@ -4011,9 +4009,9 @@
 
 	case DAHDI_GETGAINS_V1: /* Intentional drop through. */
 	case DAHDI_GETGAINS:  /* get gain stuff */
-		return dahdi_ioctl_getgains(file, cmd, data, unit);
+		return dahdi_ioctl_getgains(file, data, unit);
 	case DAHDI_SETGAINS:  /* set gain stuff */
-		return dahdi_ioctl_setgains(file, cmd, data, unit);
+		return dahdi_ioctl_setgains(file, data, unit);
 	case DAHDI_SPANSTAT:
 		size_to_copy = sizeof(struct dahdi_spaninfo);
 		if (copy_from_user(&stack.spaninfo, user_data, size_to_copy))
@@ -4140,7 +4138,7 @@
 		break;
 	case DAHDI_CHANDIAG_V1: /* Intentional drop through. */
 	case DAHDI_CHANDIAG:
-		return dahdi_ioctl_chandiag(file, cmd, data);
+		return dahdi_ioctl_chandiag(file, data);
 	default:
 		return -ENOTTY;
 	}




More information about the dahdi-commits mailing list