<div dir="ltr">I'm fairly sure the patch to App Queue that was added to Asterisk 13+ should do the job... It causes agent priorities to "float up" over time so that new agents are included without excluding old agents.<div><br></div><div>I can't find it right now but there can't be that many app_queue patches to ast 13 in the last 18 months</div><div><br></div><div>Steve</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, 30 Nov 2018 at 09:18, Paddy Grice <<a href="mailto:paddy@wizaner.com">paddy@wizaner.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><u></u>
<div>
<div dir="ltr" align="left"><span class="m_-7683637604311525742914171309-30112018"><font face="Arial" color="#0000ff" size="2">Thanks Leon </font></span></div>
<div dir="ltr" align="left"><span class="m_-7683637604311525742914171309-30112018"><font face="Arial" color="#0000ff" size="2"></font></span> </div>
<div dir="ltr" align="left"><span class="m_-7683637604311525742914171309-30112018"><font face="Arial" color="#0000ff" size="2">I will implement and test but I knew there would be a fix
for what I believe is a short coming in app_queue. How do I suggest this as a
option to the base code?</font></span></div>
<div dir="ltr" align="left"><span class="m_-7683637604311525742914171309-30112018"><font face="Arial" color="#0000ff" size="2"></font></span> </div>
<div dir="ltr" align="left"><span class="m_-7683637604311525742914171309-30112018"><font face="Arial" color="#0000ff" size="2">Paddy</font></span></div><br>
<div class="m_-7683637604311525742OutlookMessageHeader" lang="en-us" dir="ltr" align="left">
<hr>
<font face="Tahoma" size="2"><b>From:</b> Leon Wright
[mailto:<a href="mailto:lwright@corpcloud.com.au" target="_blank">lwright@corpcloud.com.au</a>] <br><b>Sent:</b> 30 November 2018
02:17<br><b>To:</b> <a href="mailto:paddy@wizaner.com" target="_blank">paddy@wizaner.com</a>;
<a href="mailto:asterisk-users@lists.digium.com" target="_blank">asterisk-users@lists.digium.com</a><br><b>Cc:</b>
<a href="mailto:johnkiniston@gmail.com" target="_blank">johnkiniston@gmail.com</a><br><b>Subject:</b> Re: [asterisk-users] Queues and
penalties<br></font><br></div>
<div></div>
<div dir="ltr">
<div dir="ltr">Paddy,
<div><br></div>
<div>This appears to be how the queue app works. I ended up patching the queue
app:</div>
<div><br></div>
<div>
<div>diff --git a/apps/app_queue.c b/apps/app_queue.c</div>
<div>index e3a4e22..72072d0 100644</div>
<div>--- a/apps/app_queue.c</div>
<div>+++ b/apps/app_queue.c</div>
<div>@@ -4571,7 +4571,7 @@ static int ring_one(struct queue_ent *qe, struct
callattempt *outgoing, int *bus</div>
<div>
struct callattempt *cur;</div>
<div>
/* Ring everyone who shares this best metric (for ringall)
*/</div>
<div>
for (cur = outgoing; cur; cur = cur->q_next) {</div>
<div>-
if (cur->stillgoing &&
!cur->chan && cur->metric <= best->metric) {</div>
<div>+
if (cur->stillgoing &&
!cur->chan && cur->metric >= qe->min_penalty * 1000000
&& cur->metric <= qe->max_penalty * 1000000) {</div>
<div>
ast_debug(1, "(Parallel) Trying '%s' with metric %d\n", cur->interface,
cur->metric);</div>
<div>
ret |=
ring_entry(qe, cur, busies);</div>
<div>
}</div></div>
<div><br></div>
<div>So the penalties get calculated during the 'ringall' strategy and allowing
the queue app to exit, looping and raising the max penalty and calling the queue
app again.</div>
<div><br></div>
<div>Leon</div></div></div><br>
<div class="gmail_quote">
<div dir="ltr">On Thu, 29 Nov 2018 at 18:24, Paddy Grice <<a href="mailto:paddy@wizaner.com" target="_blank">paddy@wizaner.com</a>> wrote:<br></div>
<blockquote class="gmail_quote" style="PADDING-LEFT:1ex;MARGIN:0px 0px 0px 0.8ex;BORDER-LEFT:#ccc 1px solid"><u></u>
<div>
<div dir="ltr" align="left"><span class="m_-7683637604311525742m_-1213785864519627822140261310-29112018"><font face="Arial" color="#0000ff" size="2">Hi John</font></span></div>
<div dir="ltr" align="left"><span class="m_-7683637604311525742m_-1213785864519627822140261310-29112018"><font face="Arial" color="#0000ff" size="2"></font></span> </div>
<div dir="ltr" align="left"><span class="m_-7683637604311525742m_-1213785864519627822140261310-29112018"><font face="Arial" color="#0000ff" size="2">This works fine providing extensions 1001,1002 and 1003 are "Incall" or
"Paused" - the problem appears to be that is a handset say 1002 is "ringing"
then the 2xxx then the penalty is not honoured.</font></span></div>
<div dir="ltr" align="left"><span class="m_-7683637604311525742m_-1213785864519627822140261310-29112018"><font face="Arial" color="#0000ff" size="2"></font></span> </div>
<div dir="ltr" align="left"><span class="m_-7683637604311525742m_-1213785864519627822140261310-29112018"><font face="Arial" color="#0000ff" size="2">This is well described in the History section of the following link
<font size="2"><a href="https://wiki.freepbx.org/display/PPS/lazymembers+patch+to+app_queue" target="_blank">https://wiki.freepbx.org/display/PPS/lazymembers+patch+to+app_queue</a></font></font></span></div>
<div dir="ltr" align="left"><span class="m_-7683637604311525742m_-1213785864519627822140261310-29112018"><font face="Arial" color="#0000ff" size="2"></font></span> </div>
<div dir="ltr" align="left"><span class="m_-7683637604311525742m_-1213785864519627822140261310-29112018"><font face="Arial"><font color="#0000ff"><font size="2">As I say t<span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">his
seems to be a real shortcoming in app_queue.</span></font></font></font>
<div><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span> </div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">Any
ideas, suggestions, anyone want to work with me to sort this
?</span></font></div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"><span class="m_-7683637604311525742m_-1213785864519627822140261310-29112018">Paddy</span></span></font></div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"><span class="m_-7683637604311525742m_-1213785864519627822140261310-29112018"></span></span></font> </div></span></div>
<div dir="ltr" align="left"><span class="m_-7683637604311525742m_-1213785864519627822140261310-29112018"><font face="Arial" color="#0000ff" size="2"></font></span> </div>
<div dir="ltr" align="left">
<hr>
</div>
<div dir="ltr" align="left"><font face="Tahoma" size="2"><b>From:</b> John Kiniston
[mailto:<a href="mailto:johnkiniston@gmail.com" target="_blank">johnkiniston@gmail.com</a>] <br><b>Sent:</b> 28 November 2018
21:17<br><b>To:</b> <a href="mailto:paddy@wizaner.com" target="_blank">paddy@wizaner.com</a>; Asterisk Users Mailing List -
Non-Commercial Discussion<br><b>Subject:</b> Re: [asterisk-users] Queues and
penalties<br></font><br></div>
<div></div>
<div dir="ltr">
<div>This should work, How are you defining your timeouts in the queues.conf ?
<br><br></div>And to verify, in your extensions.conf you are calling Queue
with the queue name and the ruleset to apply from queuerules.conf?
<br></div><br>
<div class="gmail_quote">
<div dir="ltr">On Wed, Nov 28, 2018 at 12:45 PM Paddy Grice <<a href="mailto:paddy@wizaner.com" target="_blank">paddy@wizaner.com</a>>
wrote:<br></div>
<blockquote class="gmail_quote" style="PADDING-LEFT:1ex;MARGIN:0px 0px 0px 0.8ex;BORDER-LEFT:rgb(204,204,204) 1px solid"><u></u>
<div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">Hi
All </span></font></div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">I
have been looking at this problem for a few days/weeks now and after some
advice please.</span></font></div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">I
currently have a customer on 11.25.3 and I am in the process of upgrading
versions and OS (Debian) and all things that involves mysql -> PDO
etc</span></font></div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">The
problem I have is the customer want a simple call distribution like
this</span></font></div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">Extn
1001, 1002, 1003 to be called on an incoming call - if they don't answer
after 20 seconds then 2001, 2002, 2003 to be added to the ringing extensions
and if no one answers after another 20 seconds the add in 3001, 3002,
3003.</span></font></div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">Seems
a simple queue application to me</span></font></div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">1001,
1002 and 1003 in the queue with a penalty of 1 strategy
ringall</span></font></div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">2001,
2002 and 2003 in the queue with a penalty of 2 strategy
ringall</span></font></div></span></font></div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">3001,
3002 and 3003 in the queue with a penalty of 3 strategy
ringall</span></font></div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">and
rules </span></font></div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">increasing
the maxpenalty 1->2 after 20 seconds</span></font></div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">and
increasing maxpenalty 2->3 after another 20 seconds.</span></font></div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">But
this doesn't work if users don't answer!!</span></font></div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">if
user 1002 or (2001 etc) just lets his phone ring - he forgot to logoff
or DND then the penalty is ignored.</span></font></div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">There
seems to have been a patch for FreePBX on V13 - LazyMembers - but that is
all I can find and later versions have no mention of this
</span></font></div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">I
guess I can use autopause and some AMI / Script but this stops phones
ringing because of the timeout so the user has a ringing phone and then it
stops and then it starts again whereas the penalty just adds handsets into
the ringing group.</span></font></div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">This
seems to be a real shortcoming in app_queue.</span></font></div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">Any
ideas, suggestions, anyone want to work with me to sort this
?</span></font></div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018">Paddy
Grice</span></font></div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" color="#0000ff" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font></div></span></font><font face="Arial" size="2"></font> </div></div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>
<div><font face="Arial" size="2"><span class="m_-7683637604311525742m_-1213785864519627822gmail-m_-1820171214829832071073072019-28112018"></span></font> </div>--
<br>_____________________________________________________________________<br>--
Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" rel="noreferrer" target="_blank">http://www.api-digital.com</a>
--<br><br>Astricon is coming up October 9-11! Signup is available at:
<a href="https://www.asterisk.org/community/astricon-user-conference" rel="noreferrer" target="_blank">https://www.asterisk.org/community/astricon-user-conference</a><br><br>Check
out the new Asterisk community forum at: <a href="https://community.asterisk.org/" rel="noreferrer" target="_blank">https://community.asterisk.org/</a><br><br>New to Asterisk?
Start here:<br> <a href="https://wiki.asterisk.org/wiki/display/AST/Getting+Started" rel="noreferrer" target="_blank">https://wiki.asterisk.org/wiki/display/AST/Getting+Started</a><br><br>asterisk-users
mailing list<br>To UNSUBSCRIBE or update options visit:<br> <a href="http://lists.digium.com/mailman/listinfo/asterisk-users" rel="noreferrer" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-users</a></blockquote></div><br clear="all"><br>-- <br>
<div class="m_-7683637604311525742m_-1213785864519627822gmail_signature" dir="ltr">A human being should
be able to change a diaper, plan an invasion, butcher a hog, conn a ship,
design a building, write a sonnet, balance accounts, build a wall, set a bone,
comfort the dying, take orders, give orders, cooperate, act alone, solve
equations, analyze a new problem, pitch manure, program a computer, cook a
tasty meal, fight efficiently, die gallantly. Specialization is for
insects.<br>---Heinlein</div></div>--
<br>_____________________________________________________________________<br>--
Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" rel="noreferrer" target="_blank">http://www.api-digital.com</a> --<br><br>Check
out the new Asterisk community forum at: <a href="https://community.asterisk.org/" rel="noreferrer" target="_blank">https://community.asterisk.org/</a><br><br>New to Asterisk?
Start here:<br> <a href="https://wiki.asterisk.org/wiki/display/AST/Getting+Started" rel="noreferrer" target="_blank">https://wiki.asterisk.org/wiki/display/AST/Getting+Started</a><br><br>asterisk-users
mailing list<br>To UNSUBSCRIBE or update options visit:<br> <a href="http://lists.digium.com/mailman/listinfo/asterisk-users" rel="noreferrer" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-users</a></blockquote></div></div>
-- <br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" rel="noreferrer" target="_blank">http://www.api-digital.com</a> --<br>
<br>
Check out the new Asterisk community forum at: <a href="https://community.asterisk.org/" rel="noreferrer" target="_blank">https://community.asterisk.org/</a><br>
<br>
New to Asterisk? Start here:<br>
<a href="https://wiki.asterisk.org/wiki/display/AST/Getting+Started" rel="noreferrer" target="_blank">https://wiki.asterisk.org/wiki/display/AST/Getting+Started</a><br>
<br>
asterisk-users mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-users" rel="noreferrer" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-users</a></blockquote></div>