[Asterisk-Users] VoiceMail fromstring?

Tilghman Lesher tilghman at mail.jeffandtilghman.com
Mon Oct 13 21:21:25 MST 2003


On Monday 13 October 2003 22:18, Martin Pycko wrote:
> > However, the timezone is still not straight in the message body.
> > ${VM_DATE} doesn't seem to use the timezone matching routines
> > defined by the user's tz= setting.
>
> Well it's the task for those who add features to have a global-system
> thinking. The emailbody was added way before the timezones ...

You could have just said it was a bug, instead of insulting a
contributing developer.  Patch attached.

> > Also, there seems to be a character limit for the length of
> > "emailbody=" that is a bit short - I get the last part of my
> > messages chopped off at a predictable point (seems to be around the
> > 500th character of the emailbody= line that it gets snipped.)
>
> That can be easily changes since the static array is used.

Actually, no, a static array is not used.  The code assumes that a
minimum of twice the length of the email body (or 100 minimum) is of
sufficient length.  But it's easily changed.

                int vmlen = strlen(emailbody)*2;
                if (vmlen < 20)
                    vmlen = 100;
                passdata = alloca(vmlen);
                bzero( passdata, vmlen );

-Tilghman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vm2__bugfix__20031013.diff
Type: text/x-diff
Size: 5831 bytes
Desc: not available
Url : http://lists.digium.com/pipermail/asterisk-users/attachments/20031013/5e4fcce1/vm2__bugfix__20031013.bin


More information about the asterisk-users mailing list