[asterisk-scf-commits] asterisk-scf/integration/slice.git branch "operation-context-propogation" updated.

[Commits to the Asterisk SCF project code repositories]

branch "operation-context-propogation" has been updated
       via  36aeb49e7d04aa1f42b70d3b1badb0863caf2700 (commit)
      from  4fe2a822210c32ba513739998a3807a2e89a67c4 (commit)

Summary of changes:
 .../SessionCommunicationsIf.ice                    |   60 ++++++--------------
 1 files changed, 17 insertions(+), 43 deletions(-)


- Log -----------------------------------------------------------------
commit 36aeb49e7d04aa1f42b70d3b1badb0863caf2700
Author: Brent Eagles <beagles at digium.com>
Date:   Mon Jan 23 14:47:23 2012 -0330

    Removed some operation context's from operations that did not really need them.

diff --git a/slice/AsteriskSCF/SessionCommunications/SessionCommunicationsIf.ice b/slice/AsteriskSCF/SessionCommunications/SessionCommunicationsIf.ice
index 2b3a304..fd4fe24 100644
--- a/slice/AsteriskSCF/SessionCommunications/SessionCommunicationsIf.ice
+++ b/slice/AsteriskSCF/SessionCommunications/SessionCommunicationsIf.ice
@@ -1047,47 +1047,34 @@ module V1
 
         /**
          * Nicely shutdown the bridge. Participating sessions are disconnected.
+         *
+         * @note The shutdown operation is marked as idempotent as it really can be called repeatedly without
+         * damage. The first successful receipt of the operation should result in the object being "torn down". The
+         * target object should respond with ObjectNotExistException or simply ignore the request if it receives a
+         * repeat.
+         *
          */
-        void shutdown();
+        idempotent void shutdown();
 
         /**
          * Adds a listener object to the bridge. The listener will receive notification of future changes to the bridge
          * as they occur.
          *
-         * Note: this operation needs an operation context to be declared idempotent because it a.) is a key part of
-         * call setup operations and all reasonable efforts must be made to ensure success and consistency and b.) the
-         * addition of a listener will likely result in side effects. 
-         *
-         * @param operationContext Information about the logical operation context.
          * @param listener A reference to a BridgeListener object.
          *
-         * @throws OperationCallCancelledException if the operation needed to be cancelled.
-         *
          * @see BridgeListener
-         * @see AsteriskSCF::System::V1::OperationCallCancelledException
-         * @see AsteriskSCF::System::V1::OperationContext
          */
-        idempotent void addListener(AsteriskSCF::System::V1::OperationContext operationContext, BridgeListener* listener)
-            throws AsteriskSCF::System::V1::OperationCallCancelledException;
+        idempotent void addListener(BridgeListener* listener);
 
         /**
          * Removes a listener object from the bridge. The listener will cease receiving notifications of changes to the
          * bridge.
          *
-         * Note: this operation needs an operation context to be declared idempotent because it a.) is a key part of
-         * call setup operations and all reasonable efforts must be made to ensure success and consistency and b.) the
-         * addition of a listener will likely result in side effects. 
-         *
-         * @param operationContext Information about the logical operation context.
          * @param listener A reference to the listener object to be removed.
          *
-         * @throws OperationCallCancelledException if the operation needed to be cancelled.
-         *
          * @see BridgeListener
-         * @see AsteriskSCF::System::V1::OperationCallCancelledException
-         * @see AsteriskSCF::System::V1::OperationContext
          */
-        idempotent void removeListener(AsteriskSCF::System::V1::OperationContext opContext, BridgeListener* listener);
+        idempotent void removeListener(BridgeListener* listener);
 
         /**
          * Replaces a session that is on the bridge with another session. Useful for transfers, etc.
@@ -1119,40 +1106,25 @@ module V1
         /**
          * Set (or replace) cookies on the Bridge.
          *
-         * @param operationContext Information about the logical operation context.
-         *
          * @param cookies A sequence of one or more concrete objects, each of which are of a type derived from
          *        BridgeCookie.  The bridge will store these cookies on the bridge, replacing any existing cookies with
          *        matching types.
          *
-         * @throws OperationCallCancelledException if the operation needed to be cancelled.
-         *
-         * @see AsteriskSCF::System::V1::OperationCallCancelledException
-         * @see AsteriskSCF::System::V1::OperationContext
-         *
          * @note  There can only be one cookie of a given type associated
          *        with a Bridge.
          */
-        idempotent void setCookies(AsteriskSCF::System::V1::OperationContext operationContext, BridgeCookies cookies)
-            throws AsteriskSCF::System::V1::OperationCallCancelledException;
+        idempotent void setCookies(BridgeCookies cookies);
 
         /**
          * Remove cookies from the Bridge.
          *
-         * @param operationContext Information about the logical operation context.
-         *
          * @param cookies A sequence of one or more concrete objects,
          *        each of which are of a type derived from BridgeCookie.
          *        The bridge will remove any cookies on the bridge
          *        with types that match the ones in this sequence; the
          *        content of the supplied cookies is not compared.
-         *
-         * @throws OperationCallCancelledException if the operation needed to be cancelled.
-         *
-         * @see AsteriskSCF::System::V1::OperationCallCancelledException
-         * @see AsteriskSCF::System::V1::OperationContext
          */
-        idempotent void removeCookies(AsteriskSCF::System::V1::OperationContext operationContext, BridgeCookies cookies);
+        idempotent void removeCookies(BridgeCookies cookies);
 
         /**
          * Get cookies stored on the Bridge.
@@ -1266,10 +1238,12 @@ module V1
          */
         ["amd"]
         idempotent Bridge* createBridge(Session* initiator,
-            SessionSeq destinations,
-            BridgeListener* listener,
-            AsteriskSCF::SessionCommunications::PartyIdentification::V1::Caller callerID,
-            AsteriskSCF::SessionCommunications::PartyIdentification::V1::Redirections redirects);
+                AsteriskSCF::System::V1::OperationContext operationContext,
+                SessionSeq destinations,
+                BridgeListener* listener,
+                AsteriskSCF::SessionCommunications::PartyIdentification::V1::Caller callerID,
+                AsteriskSCF::SessionCommunications::PartyIdentification::V1::Redirections redirects)
+        throws AsteriskSCF::System::V1::OperationCallCancelledException;
 
         /**
          * Method called to remove a listener from the bridge manager.

-----------------------------------------------------------------------


-- 
asterisk-scf/integration/slice.git