[asterisk-scf-commits] asterisk-scf/release/sip.git branch "authexten" updated.

[Commits to the Asterisk SCF project code repositories]

branch "authexten" has been updated
       via  44db9747153ed1c73ff0d95cfc977ea5548403db (commit)
      from  572289496c4142e8cc748cfb641efd846b2a8dc0 (commit)

Summary of changes:
 src/AuthManager.cpp |   15 +--------------
 1 files changed, 1 insertions(+), 14 deletions(-)


- Log -----------------------------------------------------------------
commit 44db9747153ed1c73ff0d95cfc977ea5548403db
Author: Mark Michelson <mmichelson at digium.com>
Date:   Thu Mar 3 14:38:59 2011 -0600

    Remove a rant-ish comment from the code and deal with things when the time is right.

diff --git a/src/AuthManager.cpp b/src/AuthManager.cpp
index f6e97f1..6e0e688 100644
--- a/src/AuthManager.cpp
+++ b/src/AuthManager.cpp
@@ -145,20 +145,7 @@ std::vector<AuthHookPrx> AuthInstance::getHooks()
 static pj_status_t lookup_cred(pj_pool_t *pool, const pj_str_t *realm,
         const pj_str_t *acc_name, pjsip_cred_info *cred_info)
 {
-    //XXX I'm still not 100% sure I understand the purpose of this function. Apparently, when I call
-    //pjsip_srv_auth_verify(), it then will call into this function with a realm and account name, and
-    //I then fill in the cred_info so that pjsip can determine if the user has authenticated properly.
-    //Of course, it's not documented what I should return if things fail. It's also not documented
-    //whether I should dynamically allocate data in the cred_info or not. I mean, I'm given a pool, so...maybe?
-    
-    //Also, it would be super awesome if I were given ANYTHING from the dialog here so I might be able to
-    //pull mod_data from it and get information. Instead, I'm forced to store information in some sort of
-    //shared space, meaning potential resource contention. Lovely.
-
-    //Luckily all I'm focused on is adding the extension point into the code, the authentication itself
-    //is a separate task, so I can get to that when I get to that. For now I'll just be sure not to
-    //return PJ_SUCCESS so that it's clear that 
-
+    // Return non-success for now just so it doesn't seem like authentication is actually succeeding.
     return !PJ_SUCCESS;
 }
 

-----------------------------------------------------------------------


-- 
asterisk-scf/release/sip.git