[asterisk-scf-commits] asterisk-scf/integration/slice.git branch "configuration" updated.

[Commits to the Asterisk SCF project code repositories]

branch "configuration" has been updated
       via  648dc29242f3c62047ac4b70c3840b97e6f04728 (commit)
      from  b75b8f512a5071a0c571825ba97a88e53364a177 (commit)

Summary of changes:
 System/Component/ConfigurationIf.ice |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)


- Log -----------------------------------------------------------------
commit 648dc29242f3c62047ac4b70c3840b97e6f04728
Author: Joshua Colp <jcolp at digium.com>
Date:   Thu Dec 23 15:29:47 2010 -0400

    Address comments from code review.

diff --git a/System/Component/ConfigurationIf.ice b/System/Component/ConfigurationIf.ice
index 1f0f08b..dc399b1 100644
--- a/System/Component/ConfigurationIf.ice
+++ b/System/Component/ConfigurationIf.ice
@@ -40,14 +40,14 @@ module V1
 	 * Serial number of the configuration item. This number should be incremented each
 	 * time an update is sent to the setConfiguration method on the Configuration interface.
 	 *
-	 * If the serial number is older then is currently presently on the configured item then
+	 * If the serial number is older than is currently presently on the configured item then
 	 * an exception will be thrown indicating that the configured item has already been changed
 	 * from another source.
 	 *
 	 * The serial number check can be disabled by passing a serial number of -1. This will force
 	 * the update to proceed no matter what.
 	 */
-	int mSerialNumber;
+	int serialNumber;
     };
 
     /**
@@ -81,7 +81,7 @@ module V1
 	/**
 	 * Dictionary of configuration items for this group.
 	 */
-	ConfigurationItemDict mConfigurationItems;
+	ConfigurationItemDict configurationItems;
     };
 
     /**
@@ -90,7 +90,7 @@ module V1
     sequence<ConfigurationGroup> ConfigurationGroupSeq;
 
     /**
-     * Exception thrown when a configuration item serial number is older then is currently configured.
+     * Exception thrown when a configuration item serial number is older than is currently configured.
      */
     exception SerialConflict
     {
@@ -98,16 +98,16 @@ module V1
 	 * The configuration group that the item belongs to. This includes all configuration items so that
 	 * they can all be updated and retried.
 	 */
-	ConfigurationGroup mGroup;
+	ConfigurationGroup group;
 
 	/**
 	 * The configuration item that the serial conflict applies to.
 	 */
-	ConfigurationItem mConfigurationItem;
+	ConfigurationItem configurationItem;
     };
 
    /**
-    * The configuration interface provides methods that allow the manipulating of the configuration
+    * The configuration interface provides methods that allow the manipulation of the configuration
     * data for a specific component.
     *
     * This interface purposely does not provide explicit methods for individual group retrieval
@@ -145,7 +145,7 @@ module V1
 	* @throws SerialConflict when serial number of a configuration item is out of date.
 	*
 	*/
-       void setConfiguration(ConfigurationGroupSeq groups) throws SerialConflict;
+       idempotent void setConfiguration(ConfigurationGroupSeq groups) throws SerialConflict;
 
        /**
 	* Remove a configuration group or specific configuration items.

-----------------------------------------------------------------------


-- 
asterisk-scf/integration/slice.git