<div class="gmail_quote">On Mon, Feb 6, 2012 at 10:04 PM, Marcelo Pacheco <span dir="ltr"><<a href="mailto:marcelo@m2j.com.br">marcelo@m2j.com.br</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<u></u>
<div bgcolor="#ffffff" text="#000000">
I noticed openr2 doesn't discard signalling if the fixed bits
(usually 01) are different from the proper settings.<br>
I changed src/r2proto.c, function openr2_proto_handle_cas:<br>
<br>
adding:<br>
if ((cas & 3) != r2chan->r2context->cas_nonr2bits)<br>
{ // Treat NON CAS bits diferent than expected as an invalid CAS
bits<br>
r2chan->cas_tx_signal = OR2_CAS_INVALID;<br>
return 0;<br>
}<br>
/* pick up only the R2 bits */ <- This comment already existed<br>
<br>
In addition, ignore alarms (continue handling input CAS bits as
normal).<br>
</div></blockquote><div><br></div><div>I'm not sure I am following what you're doing here. You are basically taking the non cas bits by doing:</div><div><br></div><div>(cas & 3) ... this basically takes the CD bits only. Then you compare the CD bits to see if they are what we expect. If they are not what we expect, then you ignore the whole thing? how do you know the AB bits did not change?? you just assume that a change in bits CD will not happen at the same time than a change in AB. I don't think that's right.</div>
<div><br></div><div>In fact, the current code in openr2 seems to make more sense, it takes the bits that matter, and only if the bits that matter change, then we do something, otherwise, we ignore the bit changes in the bits that do not matter anyways.</div>
<div><br></div><div>Can you elaborate what is this supposed to fix?</div><div><br></div><div><br class="Apple-interchange-newline"><table border="0" cellspacing="0" cellpadding="0" width="648" style="width:486.3pt;border-collapse:collapse">
<tbody><tr style="height:60.55pt"><td style="border-right-style:none;border-bottom-style:none;border-left-style:none;border-width:initial;border-color:initial;border-top-style:dotted;border-top-color:rgb(128,176,214);border-top-width:1pt;padding-top:1.45pt;padding-right:5.75pt;padding-bottom:1.45pt;padding-left:5.75pt;height:60.55pt">
<p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;line-height:15px"><b><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(14,93,167)">Moises Silva<br>
</span></b><b><i><span lang="EN-CA" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)">Software Engineer, Development Manager</span></i></b><b><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(14,93,167)"></span></b></p>
<p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;line-height:15px"><span lang="EN-CA" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(0,92,165)"><a href="mailto:msilva@sangoma.com" target="_blank">msilva@sangoma.com</a></span></p>
<p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;line-height:15px"><span lang="EN-CA" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(0,92,165)">Sangoma Technologies</span></p>
<p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;line-height:15px"><span lang="EN-CA" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(0,92,165)">100 Renfrew Drive, Suite 100, Markham, ON L3R 9R6 Canada</span><span lang="EN-CA" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(255,192,0)"></span></p>
</td><td width="187" style="width:140.45pt;border-right-style:none;border-bottom-style:none;border-left-style:none;border-width:initial;border-color:initial;border-top-style:dotted;border-top-color:rgb(128,176,214);border-top-width:1pt;padding-top:1.45pt;padding-right:5.75pt;padding-bottom:1.45pt;padding-left:5.75pt;height:60.55pt">
<p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;line-height:15px"><span lang="EN-CA" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(0,92,165)"><br>t. +1 800 388 2475 (N. America)</span></p>
<p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;line-height:15px"><span lang="EN-CA" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(0,92,165)">t. +1 905 474 1990 x128</span></p>
<p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;line-height:15px"><span lang="EN-CA" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(0,92,165)">f. +1 905 474 9223</span></p>
<p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;line-height:15px"><span lang="EN-CA" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(31,73,125)"> </span></p></td><td width="149" rowspan="2" style="width:111.55pt;border-top-style:dotted;border-top-color:rgb(128,176,214);border-top-width:1pt;border-left-style:none;border-left-width:initial;border-left-color:initial;border-bottom-style:dotted;border-bottom-color:rgb(128,176,214);border-bottom-width:1pt;border-right-style:none;border-right-width:initial;border-right-color:initial;padding-top:1.45pt;padding-right:5.75pt;padding-bottom:1.45pt;padding-left:5.75pt;height:60.55pt">
<p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;line-height:15px"><a href="http://www.sangoma.com/contact?utm_source=signature&utm_medium=email&utm_campaign=email+signatures" target="_blank"><b><span style="color:rgb(31,73,125);text-decoration:none"><img border="0" width="96" height="15"></span></b></a><span style="color:rgb(31,73,125)"></span></p>
</td></tr><tr><td width="500" colspan="2" style="width:374.75pt;border-top-style:none;border-right-style:none;border-left-style:none;border-width:initial;border-color:initial;border-bottom-style:dotted;border-bottom-color:rgb(128,176,214);border-bottom-width:1pt;padding-top:1.45pt;padding-right:5.75pt;padding-bottom:1.45pt;padding-left:5.75pt">
<p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;line-height:15px"><a href="http://sangoma.com/products?utm_source=signature&utm_medium=email&utm_campaign=email%2Bsignatures" target="_blank"><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)">Products</span></a><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)"> | </span><a href="http://sangoma.com/solutions?utm_source=signature&utm_medium=email&utm_campaign=email%2Bsignatures" target="_blank"><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)">Solutions</span></a><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)"> | </span><a href="http://sangoma.com/about_us/events?utm_source=signature&utm_medium=email&utm_campaign=email%2Bsignatures" target="_blank"><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)">Events</span></a><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)"> | </span><a href="http://www.sangoma.com/contact?utm_source=signature&utm_medium=email&utm_campaign=email%2Bsignatures" target="_blank"><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)">Contact</span></a><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)"> | </span><a href="http://wiki.sangoma.com/?utm_source=signature&utm_medium=email&utm_campaign=email%2Bsignatures" target="_blank"><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)">Wiki</span></a><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)"> | </span><a href="http://www.facebook.com/pages/Sangoma-VoIP-Cards/43578453335?utm_source=signature&utm_medium=email&utm_campaign=email%2Bsignatures" target="_blank"><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)">Facebook</span></a><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)"> | </span><a href="http://www.twitter.com/sangoma?utm_source=signature&utm_medium=email&utm_campaign=email%2Bsignatures" target="_blank"><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)">Twitter</span></a><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)">`| | </span><span lang="PT-BR" style="font-size:8pt;line-height:12px;font-family:Arial,sans-serif;color:rgb(128,176,214)"><a href="http://www.youtube.com/sangomatechnologies?utm_source=signature&utm_medium=email&utm_campaign=email%2Bsignatures" target="_blank">YouTube</a></span></p>
</td></tr></tbody></table></div></div>