<div dir="ltr">Pari, great... I looked at the new source and will test it out later, but it sure looks to be good. FYI, I coded up method 1 and uploaded a patch to feature request #13694 after having some email discussion with Brandon. In my opinion, the ability to assign a voicemenu to interpret key presses while in a queue should be part of the GUI anyway. As your fix treads on part of the area that my patch also updates, you may not be able to simply apply the patch... manual intervention may be required!<br>
<br>Thanks<br>David <br><br><div class="gmail_quote">On Fri, Oct 17, 2008 at 11:03 AM, Pari Nannapaneni <span dir="ltr"><<a href="mailto:pari@digium.com">pari@digium.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi David,<br>
<br>
fixed as suggested in method 2<br>
<br>
check out branches/2.0 -r3961 or above<br>
thanks for bringing up the issue,<br>
<font color="#888888"><br>
Pari<br>
</font><div class="Ih2E3d"><br>
<br>
----- Original Message -----<br>
From: "David Kerr" <David@Kerr.net><br>
To: "bkruse" <<a href="mailto:bkruse@digium.com">bkruse@digium.com</a>>, "Asterisk GUI project discussion" <<a href="mailto:asterisk-gui@lists.digium.com">asterisk-gui@lists.digium.com</a>><br>
Sent: Sunday, October 5, 2008 2:44:40 PM GMT -06:00 US/Canada Central<br>
Subject: Re: [asterisk-gui] How to call custom Macros with Astersk GUI 2.0 ?<br>
<br>
</div><div><div></div><div class="Wj3C7c">I'm not very interested in creating a custom GUI just for myself. I would rather see bugs fixed so that I could use the GUI. Take the example cited above... adding "context=xxxx" into queues.conf<br>
<br>
There are a couple of approaches to fixing this.<br>
<br>
1) Modify the GUI to add the ability to specify a context for a queue. This would be a fairly easy fix, but very specific to context=.... it would not address any other statements that might be added through the file editor.<br>
<br>
2) Or, you could get to the heart of the problem and fix the GUI so that it doesn't blast away user edits. The route of the problem is this sequence of calls in queues.html<br>
var x = new listOfActions('queues.conf');<br>
x.new_action('delcat', cat, '', '');<br>
x.new_action('newcat', cat, '', ''); // create new context<br>
x.new_action('append', cat, 'fullname', ASTGUI.getFieldValue(DOM_edit_label));<br>
x.new_action('append', cat, 'strategy', ASTGUI.getFieldValue(DOM_edit_strategy));<br>
x.new_action('append', cat, 'timeout', ASTGUI.getFieldValue(DOM_edit_timeout));<br>
x.new_action('append', cat, 'wrapuptime', ASTGUI.getFieldValue(DOM_edit_wrapuptime));<br>
x.new_action('append', cat, 'autofill', ASTGUI.getFieldValue(DOM_edit_autofill));<br>
x.new_action('append', cat, 'autopause', ASTGUI.getFieldValue(DOM_edit_autopause));<br>
x.new_action('append', cat, 'joinempty', ASTGUI.getFieldValue(DOM_edit_joinempty));<br>
x.new_action('append', cat, 'leavewhenempty', ASTGUI.getFieldValue(DOM_edit_leavewhenempty));<br>
x.new_action('append', cat, 'reportholdtime', ASTGUI.getFieldValue(DOM_edit_reportholdtime));<br>
x.new_action('append', cat, 'maxlen', ASTGUI.getFieldValue(DOM_edit_maxlen));<br>
x.new_action('append', cat, 'musicclass', ASTGUI.getFieldValue(DOM_edit_musicclass));<br>
<br>
See how it starts with 'delcat'... that deletes everything in the category, then it creates a new one then appends all the settings entered in the GUI. Now I have not tested anything, but it would seam possible to check whether the "cat" already exists. If not then create it, else don't. Then use the 'update' parameter on new_action rather than 'append'.<br>
<br>
In either case, It would be better implemented in the master source. I suppose I could take a stab at coding a fix (but I'm not a javascript programmer, but fast learner) and then give it to you for consideration.<br>
<br>
Regards<br>
David<br>
<br>
<br>
</div></div></blockquote></div><br></div>