[asterisk-gui] GUI Hacks - August

[Andrew Latham]

Ideas / Issues
1. Limit the number of lines/accounts listed on the dashboard
2. Mass user import does not import outbound caller ID
3. Strange issue with duplicate and triplicate "type=peer" on extensions


~
Andrew "lathama" Latham
lathama at gmail.com

* Learn more about OSS http://en.wikipedia.org/wiki/Open-source_software
* Learn more about Linux http://en.wikipedia.org/wiki/Linux
* Learn more about Tux http://en.wikipedia.org/wiki/Tux



On Thu, Aug 5, 2010 at 10:34 AM, Andrew Latham <lathama at gmail.com> wrote:
> All
>
> Here is a list of things that we are doing with the GUI.  Christian
> "wawi" Jacobsen and I have made some changes.  Tzafrir Cohen also has
> some changes that I will mention.
>
> ## Typo
>
> Index: scripts/listfiles
> ===================================================================
> --- scripts/listfiles   (revision 5015)
> +++ scripts/listfiles   (working copy)
> @@ -3,7 +3,7 @@
>  SYSINFO_OUTPUT="/var/lib/asterisk/static-http/config/sysinfo_output.html"
>
>  #/bin/echo "<div id=list_files>" > $SYSINFO_OUTPUT
> -/bim/mkdir -p -- "$1"
> +/bin/mkdir -p -- "$1"
>  #/bin/echo "</div>" >> $SYSINFO_OUTPUT
>
>  if [ "$2" = "time" ]; then
>
>
> ## Broken filter
>
> Index: config/js/pbx2.js
> ===================================================================
> --- config/js/pbx2.js   (revision 5013)
> +++ config/js/pbx2.js   (working copy)
> @@ -206,7 +206,7 @@
>
>                var exten = ASTGUI.parseContextLine.getExten(line);
>                var options = line.afterChar('=');
> -               var params = options.betweenXY('|',')');
> +               var params = options.afterChar(',').afterChar(',').betweenXY(',',')');
>
>                if (params.contains('a') && params.contains('A')) {
>                        exten = ASTGUI.parseContextLine.getArgs(line)[0];
> @@ -243,7 +243,7 @@
>                var name = line.betweenXY('=',',');
>                name = name.trim();
>
> -               if(!sessionData.pbxinfo.hasOwnProperty(name)) {
> +               if(!sessionData.pbxinfo.conferences.hasOwnProperty(name)) {
>                        sessionData.pbxinfo.conferences[name] = new ASTGUI.customObject;
>                        sessionData.pbxinfo.conferences[name]['configOptions'] = '';
>                }
>
> ## ? (Christian is busy but will get him to reply)
>
> Index: config/js/meetme.js
> ===================================================================
> --- config/js/meetme.js (revision 5013)
> +++ config/js/meetme.js (working copy)
> @@ -214,9 +214,6 @@
>
>        if( isNewBridge == false ){ // delete/update old bridge values
>                if( parent.sessionData.pbxinfo.conferences[EDIT_BRIDGE]['configOptions'] ){
> -                       u.new_action('delete', 'default', 'exten', '',
> parent.sessionData.pbxinfo.conferences[EDIT_BRIDGE]['configOptions']
> ); // backward compatibility  with old gui
> -               }
> -               if( parent.sessionData.pbxinfo.conferences[EDIT_BRIDGE]['configOptions'] ){
>                        u.new_action('delete', ASTGUI.contexts.CONFERENCES, 'exten', '',
> parent.sessionData.pbxinfo.conferences[EDIT_BRIDGE]['configOptions']
> );
>                }
>                if( parent.sessionData.pbxinfo.conferences[EDIT_BRIDGE]['adminOptions'] ){
>
> ##
>
> Index: config/js/astman.js
> ===================================================================
> --- config/js/astman.js (revision 5013)
> +++ config/js/astman.js (working copy)
> @@ -464,7 +464,7 @@
>                                field = _$(field);
>                        }
>                        var required = $(field).attr('required');
> -                       if( required && required.isAstTrue() ){
> +                       if( required ){
>                                var x = field.value.trim() ;
>                                var pcn = ( field.className ) ? field.className : '' ;
>                                if( !x ){
>
>
>
> ## Missing or broken filter
>
> Index: config/js/callingrules.js
> ===================================================================
> --- config/js/callingrules.js   (revision 5013)
> +++ config/js/callingrules.js   (working copy)
> @@ -335,7 +335,7 @@
>                }
>
>                var t1_braces = (t1 == 'Skype') ? t1 : '${' + t1 + '}' ;
> -               var Trunk_Build_str = ',' + t1_braces + '/' +
> DOM_new_crl_tr_prepend.value + '${' + DOM_new_crl_tr_filter.value
> +',${EXTEN:' + tmp_stripx  + '})}' ;
> +               var Trunk_Build_str = ',' + t1_braces + '/' +
> DOM_new_crl_tr_prepend.value + '${EXTEN:' + tmp_stripx  + '}' ;
>                var foTrunk_Build_str = ',' ;
>
>                if(DOM_new_crl_foChkbx.checked){
>
>
>
> ## Small mistake
>
> Index: config/js/index.js
> ===================================================================
> --- config/js/index.js  (revision 5013)
> +++ config/js/index.js  (working copy)
> @@ -118,7 +118,7 @@
>                                sessionData.PLATFORM.isAST_1_6 = true ;
>                                sessionData.PLATFORM.isAST_1_6_1 = resp_lower.contains('1.6.1') ?
> true : false;
>                                ASTGUI.globals.sbcid_1 = 's,1,ExecIf($[ "${CALLERID(num)}"=""
> ]?SetCallerPres(unavailable))';
> -                               ASTGUI.globals.sbcid_2 = 's,1,ExecIf($[ "${CALLERID(num)}"=""
> ]?Set(CALLERID(all)=unknown <0000000>))';
> +                               ASTGUI.globals.sbcid_2 = 's,2,ExecIf($[ "${CALLERID(num)}"=""
> ]?Set(CALLERID(all)=unknown <0000000>))';
>                                sessionData.listOfCodecs = { // sessionData.listOfCodecs
>                                        'ulaw' : 'u-law' ,
>                                        'alaw' : 'a-law' ,
>
>
> ## Logo Hack (some Linux distros will not allow licenced or trademarked logos.)
>
> Index: config/index.html
> ===================================================================
> --- config/index.html   (revision 5015)
> +++ config/index.html   (working copy)
> @@ -30,7 +30,7 @@
>  <body topmargin=1 leftmargin=2>
>        <div class="header_row">
>                <div class="main_logo" id="main_logo">
> -                       <img src="images/digiumlogo.gif" align="left">
> +                       <!-- <img src="images/digiumlogo.gif" align="left"> --> <span
> style="font-size: 2em;">Tecnoera</span>
>                </div>
>                <div class="feedback_parent">
>                        <span id="feedback" class="feedback"></span>
>
>
> Tzafrirs hacks
> http://svn.debian.org/viewsvn/pkg-voip/asterisk-gui/trunk/debian/patches/datadir_path?view=markup
> http://svn.debian.org/viewsvn/pkg-voip/asterisk-gui/trunk/debian/patches/trademark?view=markup
>
> ~
> Andrew "lathama" Latham
> lathama at gmail.com
>
> * Learn more about OSS http://en.wikipedia.org/wiki/Open-source_software
> * Learn more about Linux http://en.wikipedia.org/wiki/Linux
> * Learn more about Tux http://en.wikipedia.org/wiki/Tux
>