<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 4, 2023 at 1:16 PM <<a href="mailto:asterisk@phreaknet.org">asterisk@phreaknet.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 4/4/2023 2:53 PM, George Joseph wrote:<br>
> <snip><br>
><br>
> Speaking of workflows... If you want to see the workflows and<br>
> actions we've written so far, check out the asterisk/asterisk-gh-test (the<br>
> .github/workflows directory) and asterisk/asterisk-ci-actions repos. If<br>
> you're experienced with GitHub workflows, feedback is appreciated.<br>
Thanks, George, et al, for all this amazing work. I admit Gerrit has <br>
grown on me a little over the years, but other developers I've discussed <br>
with do prefer GitHub and I'm eager to give this a try when it's all ready.<br>
<br>
One question from looking through some of the workflows that are up now:<br>
<a href="https://github.com/asterisk/asterisk-gh-test/blob/master/.github/workflows/CloseStaleIssues.yml" rel="noreferrer" target="_blank">https://github.com/asterisk/asterisk-gh-test/blob/master/.github/workflows/CloseStaleIssues.yml</a><br>
<br>
I'm a bit curious about the auto-closing functionality:<br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
* Do you think 14-21 days is a sufficient threshold for most issues?<br>
It seems potentially a bit low to me. For example, once an issue is<br>
triaged and opened, will it just be closed automatically 3 weeks<br>
later if it hasn't been resolved by then? Or are issues in the<br>
'open' state exempt from this, this is purely for triage to weed out<br>
junk issues?<br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> * Case in point: one vendor I deal with frequently has this annoying<br>
auto-close functionality in their system which triggers after about<br>
2 weeks or so. Often more time is required on one of our ends just<br>
to follow up on the last thing, so there is a lot of inevitable<br>
"commenting to avoid auto closure" and this just adds a lot of noise<br>
into the tickets.<br>
* Is there any connection with reviews/PRs in progress? Suppose an<br>
issue is open and maybe on the verge of being stale, but someone has<br>
submitted a PR against. Changes can often take much longer than 3<br>
weeks to merge, so it wouldn't make sense for an issue to close<br>
itself in that case. So I'm concerned perhaps that might not be<br>
sufficient time.<br></blockquote><div><br></div><div><div>We're still thinking about the issues process but...</div><div><br></div><div>The action allows you to specify labels that make an issue exempt from auto-closure. I was thinking that when a PR gets submitted, we'd look for the "Resolves: #issuenum" tag in the commit message, then add an "InProgress" label to the issue to prevent it from being auto closed. The issue would then get closed when the PR is closed.</div><div><br></div><div>I'm also thinking it would only close issues that have been inactive and assigned to the submitter. Like the "Waiting for Feedback" status in Jira.</div><div><br></div><div></div></div><div>Does that make sense?</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
I guess this will answer itself after the migration when we see how <br>
people interact with it, but curious if these were just defaults or if <br>
these were customized for the project.<br>
<br>
Thanks again for all this heavy lifting!<br>
<br>
NA<br>
<br>
</blockquote></div><div dir="ltr" class="gmail_signature"><div dir="ltr"><br></div></div></div>