<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Nov 30, 2020 at 2:18 AM Alexander Traud <<a href="mailto:pabstraud@compuserve.com">pabstraud@compuserve.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">In 2009, Asterisk 1.8 introduced a media format called "G.711 test-law" [1]. Furthermore, in chan_sip, default_format_capabilities mentioned testlaw. Five years later, Asterisk 13 removed testlaw from there [2]. However, it remained in general.<br>
<br>
For me, it looks like not just dead code but a merge mistake back in the year 2009. It looks like a format which was used to white-box test the change back then. The old "Review Board" is no longer online, so I cannot check any possible comments there.<br>
<br>
Any idea? I feel it is worth removal because it can create chaos [3].<br></blockquote><div><br></div><div>I don't see any reference to it in the testsuite so I _think_ it'd be OK to remove.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
[1] <<a href="https://github.com/asterisk/asterisk/commit/d8e0c584372c51b585a52efbe2375861bc09bdcf#diff-5fda6a239e770b39ac96e677778e231fb79dc190b473c9724d21997ae9fca3bf" rel="noreferrer" target="_blank">https://github.com/asterisk/asterisk/commit/d8e0c584372c51b585a52efbe2375861bc09bdcf#diff-5fda6a239e770b39ac96e677778e231fb79dc190b473c9724d21997ae9fca3bf</a>><br>
[2] <<a href="https://github.com/asterisk/asterisk/commit/a2c912e9972c91973ea66902d217746133f96026#diff-b46867aafe8df97c4c3e15a223f26dde97354b72e649bf6cb73215ac657364a2" rel="noreferrer" target="_blank">https://github.com/asterisk/asterisk/commit/a2c912e9972c91973ea66902d217746133f96026#diff-b46867aafe8df97c4c3e15a223f26dde97354b72e649bf6cb73215ac657364a2</a>><br>
[3] <<a href="https://issues.asterisk.org/jira/browse/ASTERISK-29185" rel="noreferrer" target="_blank">https://issues.asterisk.org/jira/browse/ASTERISK-29185</a>><br>
<br>
<br>
<br>
-- <br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" rel="noreferrer" target="_blank">http://www.api-digital.com</a> --<br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
   <a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" rel="noreferrer" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr" style="font-size:12.8px"><div dir="ltr" style="font-size:12.8px"><div style="font-family:tahoma,sans-serif;font-size:small"><span style="color:rgb(7,55,99)">George Joseph</span><br></div></div><div dir="ltr" style="font-size:small"></div><div style="font-family:tahoma,sans-serif;font-size:small"><span style="color:rgb(7,55,99)">Asterisk Software Developer</span><br></div><span style="color:rgb(7,55,99);font-family:tahoma,sans-serif;font-size:small">direct/fax +1 256 428 6012</span><br><div style="font-family:tahoma,sans-serif;font-size:small"><font color="#073763">Check us out at</font> <a href="http://www.sangoma.com/" style="color:rgb(17,85,204)" target="_blank">www.sangoma.com</a> and <a href="http://www.asterisk.org" target="_blank">www.asterisk.org</a><br></div><div style="font-family:tahoma,sans-serif;font-size:small"><img src="cid:ii_k3abte590" alt="image.png" width="184" height="32" style="margin-right: 0px;"></div></div></div></div></div></div></div></div></div>