<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p>Sounds good.  So after this is done am I correct that when my
      review against asterisk 13 is approved jenkins will 'gate' using
      the 13 branch of testsuite?  Will the testsuite also get minor
      branches (like 13.19)?<br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 12/15/2017 03:24 PM, George Joseph
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAP=uFEuHiixEnXyttVwLMDjywCf1+WCkY4_b2jxZxYFFv+Y6KQ@mail.gmail.com">
      <div dir="ltr"><br>
        <div class="gmail_extra"><br>
          <div class="gmail_quote">On Fri, Dec 15, 2017 at 10:56 AM,
            Corey Farrell <span dir="ltr"><<a
                href="mailto:git@cfware.com" target="_blank"
                moz-do-not-send="true">git@cfware.com</a>></span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <div text="#000000" bgcolor="#FFFFFF">
                <p>It would be nice to strip out some/most of the per
                  version conditionals in tests.  The need to always
                  cherry-pick changes is the only pitfall I see with
                  your proposal.  If a test never had per version
                  differences then the cherry-pick is trivial amount of
                  extra work, but for tests with differences per branch
                  it would mean dealing with conflicts.  In the
                  testsuite I think I'd rather deal with per branch
                  conditionals over merge with conflicts.</p>
              </div>
            </blockquote>
            <div>Given the low commit volume, even lower commit volume
              against existing tests, high compartmentalization and
              small nature of the files in the testsuite,  I don't see
              conflicts being a big thing.  If there are any, then
              they're probably justified.</div>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <div text="#000000" bgcolor="#FFFFFF">
                <p>I just want to propose an alternative way of (mostly)
                  accomplishing the goal.  We could create a tag '12'
                  from current master.  This would represent the last
                  revision of the testsuite known to work with Asterisk
                  12 and below.  We would then be free to remove
                  compatibility with EOL Asterisk branches from
                  testsuite master.  We would tag testsuite '14' soon
                  after September 26th, 2018 (EOL for Asterisk 14). 
                  This would avoid multiplying the number of gerrit
                  reviews for testsuite changes, but it would require
                  continuing to maintain version declarations for
                  supported versions of Asterisk.  I think this would be
                  a good trade-off so we aren't stuck with all the
                  1.8/11 baggage.</p>
              </div>
            </blockquote>
            <div>We were thinking of taking the current master, copying
              it to 13, 14, 15, and "legacy" then starting with the next
              release our release scripts would automatically create
              tags in the testsuite just as they do in asterisk.</div>
            <div><br>
            </div>
            <div>This also makes Jenkins much happier BTW.</div>
            <div><br>
            </div>
            <div><br>
            </div>
            <div> </div>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <div text="#000000" bgcolor="#FFFFFF">
                <div>
                  <div class="h5"> <br>
                    <div class="m_-6035844786044234573moz-cite-prefix">On
                      12/15/2017 11:59 AM, Kevin Harwell wrote:<br>
                    </div>
                    <blockquote type="cite">
                      <div dir="ltr">Greetings,
                        <div><br>
                        </div>
                        <div>We're thinking about adding a branching
                          system to the Asterisk Testsuite. Each branch
                          would be named the same as, and correspond to,
                          an Asterisk branch. So for instance the
                          following branches would probably be created:</div>
                        <div><br>
                        </div>
                        <div>13, 14, 15</div>
                        <div><br>
                        </div>
                        <div>For each release of Asterisk we will also
                          create a tag in the Testsuite that corresponds
                          to that release's tag. That way someone could
                          checkout both tags for easy testing</div>
                        <div><br>
                        </div>
                        <div>Other advantages? Most all, if not all, the
                          current versioning stuff found in the
                          Testsuite could go away, or be safely ignored
                          moving forward. The versioning has become a
                          bit cumbersome especially when you have to
                          make a backward incompatible change to a test.
                          Moving the version control out of the
                          Testsuite and into a version control system
                          should alleviate the need for this moving
                          forward.</div>
                        <div><br>
                        </div>
                        <div>Please let us know your thoughts and
                          considerations on moving forward with this
                          model. Especially any potential pitfalls or
                          problems you might see with it.</div>
                        <div><br>
                        </div>
                        <div>Thanks!</div>
                        <div><br>
                        </div>
                        <div>-- <br>
                          <div
                            class="m_-6035844786044234573gmail_signature"
                            data-smartmail="gmail_signature">
                            <div dir="ltr">
                              <pre style="padding:2px;border:1px solid rgb(114,99,77);background-color:rgb(238,238,238);color:rgb(0,0,0);overflow:auto">Kevin Harwell
Digium, Inc. | Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: <a href="http://digium.com" target="_blank" moz-do-not-send="true">http://digium.com</a> & <a href="http://asterisk.org" target="_blank" moz-do-not-send="true">http://asterisk.org</a></pre>
                            </div>
                          </div>
                        </div>
                      </div>
                      <br>
                      <fieldset
                        class="m_-6035844786044234573mimeAttachmentHeader"></fieldset>
                      <br>
                    </blockquote>
                    <br>
                  </div>
                </div>
              </div>
              <br>
              --<br>
              ______________________________<wbr>______________________________<wbr>_________<br>
              -- Bandwidth and Colocation Provided by <a
                href="http://www.api-digital.com" rel="noreferrer"
                target="_blank" moz-do-not-send="true">http://www.api-digital.com</a>
              --<br>
              <br>
              asterisk-dev mailing list<br>
              To UNSUBSCRIBE or update options visit:<br>
                 <a
                href="http://lists.digium.com/mailman/listinfo/asterisk-dev"
                rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.digium.com/<wbr>mailman/listinfo/asterisk-dev</a><br>
            </blockquote>
          </div>
          <br>
          <br clear="all">
          <div><br>
          </div>
          -- <br>
          <div class="gmail_signature" data-smartmail="gmail_signature">
            <div dir="ltr"><span style="font-size:12.8px">George Joseph</span><br
                style="font-size:12.8px">
              <span style="font-size:12.8px">Digium, Inc. | Software
                Developer</span><span style="font-size:12.8px"><br>
                445 Jan Davis Drive NW - Huntsville, AL 35806 - US<br>
              </span><span style="font-size:12.8px">Check us out at: </span><a
                href="http://www.digium.com/" rel="noreferrer"
                style="color:rgb(17,85,204);font-size:12.8px"
                target="_blank" moz-do-not-send="true">www.digium.com</a><span
                style="font-size:12.8px"> & </span><a
                href="http://www.asterisk.org/" rel="noreferrer"
                style="color:rgb(17,85,204);font-size:12.8px"
                target="_blank" moz-do-not-send="true">www.asterisk.org</a><br>
              <div><br>
              </div>
            </div>
          </div>
        </div>
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
    </blockquote>
    <br>
  </body>
</html>