<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 6, 2017 at 6:00 AM, Alexander Traud <span dir="ltr"><<a href="mailto:pabstraud@compuserve.com" target="_blank">pabstraud@compuserve.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> An earlier approach was to add support for setting pjproject's timer<br>
> (via a pjproject patch) and while that patch is still included here,<br>
> we don't use that call at the moment."<br>
<br>
OK, and what do we do with this code now?<br>
I am not used to leverage a version-controlled source code as pastebin or to keep dead code. Remove it? If not, it should at least work – configure is not able to find/match that feature at the moment. Remove or repair?<br></blockquote><div><br></div><div>That patch was submitted upstream and committed to the pjproject. However, the function</div><div> name got changed slightly from pjsip_evsub_set_uas_timeout() to</div><div>pjsip_evsub_uas_set_timeout() when Teluu merged it into pjproject. Asterisk never had a</div><div> commit that actually used the function so it does not matter. Asterisk's bundled pjproject</div><div> is currently 2.7.1 on the released branches and does not include the broken patch anymore.<br></div><div><br></div><div>Richard</div><br></div></div></div>