<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr">
<p></p>
<div>Hi,</div>
<div><br>
</div>
<div>I'm trying to fix a bug within the ast_rtp_codecs_payload_code(), there are multiple crashes in the procedure.</div>
<div><br>
</div>
<div>The latest being:</div>
<div><br>
</div>
<div>#0 0x000000000051f883 in ast_format_cmp (format1=0x2bf73b8, format2=0x151) at format.c:247</div>
<div><br>
</div>
<div>This line contains:</div>
<div><br>
</div>
<p></p>
<blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
<p></p>
<div>if (format1->codec != format2->codec) {</div>
<p></p>
<p></p>
<div><span class="Apple-tab-span" style="white-space:pre"></span>return AST_FORMAT_CMP_NOT_EQUAL;</div>
<p></p>
<p></p>
<div><span class="Apple-tab-span" style="white-space:pre"></span>}</div>
<p></p>
</blockquote>
<p></p>
<div></div>
<div><br>
</div>
<div>In the code before this line there are checks that 'format1' and 'format2' are not NULL however there are no checks to see if 'format1->codec' or 'format2->codec' are not NULL.</div>
<div><br>
</div>
<div>Therefore I have added the following code to check for this:</div>
<div><br>
</div>
<div> </div>
<div> if (format1->codec == NULL || format2->codec == NULL) {</div>
<div><span class="Apple-tab-span" style="white-space:pre"></span>return AST_FORMAT_CMP_NOT_EQUAL;</div>
<div><span class="Apple-tab-span" style="white-space:pre"></span>}</div>
<div><br>
</div>
<div>The question is, should 'codec' be NULL if 'format1' and 'format2' are not NULL? Is adding the above check, the correct fix?</div>
<div><br>
</div>
<div>Kind regards,</div>
<div><br>
</div>
<div>Ross</div>
<div><br>
</div>
<br>
<p></p>
</div>
</body>
</html>