<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4521/">https://reviewboard.asterisk.org/r/4521/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 28th, 2015, 10:16 a.m. UTC, <b>one47</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have applied a cleaned-up version of this patch. I do not believe you need the 1-second wait loop at-all, but the rest of the patch looks clean, and after some research I even worked out why it helps :)
Yes, I think it should be progressed.</pre>
</blockquote>
<p>On April 28th, 2015, 1:23 p.m. UTC, <b>Stefan Engström</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cool - where can I view the contents of your cleaned-up version?</pre>
</blockquote>
<p>On April 28th, 2015, 1:25 p.m. UTC, <b>one47</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FYI I have patched asterisk v.11, and reproduced the issue using a load-test setup.</pre>
</blockquote>
<p>On April 28th, 2015, 1:27 p.m. UTC, <b>one47</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is hardly worth me pushing a specific version to you - It is your patch with all of the whitespace and comment changes removed, and I then removed the 1-second delay loop. If you prefer I can email you my version direct - I do not think I can add it here?
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">aha, fair enough - I'll upload a new diff-revision too</pre>
<br />
<p>- Stefan</p>
<br />
<p>On April 28th, 2015, 2:47 p.m. UTC, Stefan Engström wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Stefan Engström.</div>
<p style="color: grey;"><i>Updated April 28, 2015, 2:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not in final form - What's essential to review is the extra check done before calling dtls_perform_handshake.
I'm aware that this patch is polluted with comments, bad spacing and ast_log-calls... I'll align the patch with https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines only if you judge the 'actual patch-contents' might be commitable</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, with this patch applied crashes has gone down to 0 in 30 days, and before patch it would crash once every 1-4 hours.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/13/res/res_rtp_asterisk.c <span style="color: grey">(434725)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4521/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>