<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On 24 Apr 2015, at 15:42, Russell Bryant <<a href="mailto:russell@russellbryant.net">russell@russellbryant.net</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Apr 24, 2015 at 8:31 AM, Joshua Colp <span dir="ltr"><<a href="mailto:jcolp@digium.com" target="_blank">jcolp@digium.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Olle E. Johansson wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Playing around following Matt's wiki page on gerrit usage, I created<br>
a team branch and did two commits. When pushing it with "git review<br>
{branch}" only the last commit shows up.<br>
<br>
Is that the way it's supposed to be? I thought the whole branch was<br>
the review subject, not just a single commit.<br>
</blockquote>
<br></span>
Gerrit works on a single commit (what it refers to as a patch set) that you want included into a specific branch. As a result you need to squash all commits into a single one, and if review feedback warrants further changes they also need to be squashed back into a single commit with the original changes. The single commit you post for review is what is reviewed and merged into the branch.<br></blockquote><div><br></div><div>Gerrit can also work on a patch series, and tracks dependencies between those patches.</div></div></div></div></blockquote><br></div><div>Define "patch series" - how do you commit a series of patches for review?</div><div><br></div><div>/O</div><br></body></html>